From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by sourceware.org (Postfix) with ESMTPS id B3470385DC0A for ; Fri, 8 Mar 2024 15:25:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3470385DC0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3470385DC0A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709911552; cv=none; b=DrnJ8JTjRN0sHjUdpCrDTYiqUAtIkE8hWIlHjAOJG436+maOfOG5kbbNlQ+i6v3l2J0TuYnLJ4tgjW1y1d0/hME8Q8vyesoZTEdZQd0ojJWITEx+ZX9T8sR4oDbI3/Hub7b7qCxNSfzo8eDonMOanFHExb6JgS+9L7f/DJ5hpRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709911552; c=relaxed/simple; bh=LrLCq8PyWAJmUmFcaEtdUT2BwU+yivsCOY66duWMZMw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=J7xTJuvR0t2qfYvYd43K3sk6cdLQwGBZCjtsWVnGR9dx30bTy3jYijNLIMvnrKqa5qPVAT/rUyptPezc5tW1vQEM+HJrj4P5AR2gs0SNfIa88+WrUQDxbmMG24XKKReys6s0+vg6ZXwVQNr/cXHzlM6VHUfpPwXLsR1GDDFZPzg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-60a0a1bd04eso5364377b3.1 for ; Fri, 08 Mar 2024 07:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709911546; x=1710516346; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HBNgzIvpdIybr4HcaW3CnybyOd/JVVvmVWEj7lvXhs8=; b=ChI2NlPwOE5+BYCQmfQ+OgbKHccHmGqRMTlK1yvOsj9u0ZIIbp4NVONHTNBRPkysMZ Gwbc4HCA+wZoFJQODap+GaaSFymhbhSwru/2+kX1v5YgUTbLuTXOBUPBaM9YPSjoh6MZ lIMnUfFMqFvUKG37Tzh+9AYDuGq5msQiN20DgghuSCYXsW25pnQmBfAXOOzkkD2PBHlx bZWaqF0UcEkUxoaLbGaQJpro8PUNth7D5SN2KZf8PtTdqNWQUAtCRluLVrDn0/EFbZCz gB9e8l1De7vAGQfCdTlmWYa3rTlgnZl/jDjwZHO8LQ/S6dawMb2O1uqATp8iM+FmJgRl B1yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709911546; x=1710516346; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HBNgzIvpdIybr4HcaW3CnybyOd/JVVvmVWEj7lvXhs8=; b=PpBmqZNovWcCR1u0Rmp+Z6oJQaNiglCjy10XFXzQV6TNRNRTlH7cknx5ES2AKRqy3P E7g63yhyhmdwBtWc60SgLYb1ctWZtJAbhXQ8TY2HqBFp0NAkQaSAm5ZLxhA7/slB5dfM glKik5oTBo5AVjoLzonu005B1KwNcVnkNj5CTZnh0GwIddoqYCCx8I04obxG7HvMt3py ruPxWgVs/WR6oTo3fxlROPNzXnRzvHx4a3fx/gExmtaaGs+iuQMtH/bfrIN6B/XmK2wI soS3zIDpwrSk3Wltmg93c7i+4iclj5m9rhjBLVFXAszz1JWh/gkGzoTQvIhIIFnOdave gQyA== X-Gm-Message-State: AOJu0YxcVOD7J5Pv5pcRYKBr0aSd01Q3195IUdQaBRKRK+guL5gfX8q8 Xl7B8b5LYiPzQrR1lPtCNxo5nFqOb2XEa/+PnsWRnFbh/5A9BAIyGzX4Omr+gTkJhiu4FoM1riv Qx8Cg9FHAur340AOEK87+HUcK/c9KejhS X-Google-Smtp-Source: AGHT+IHgw4Tzei/OJCAXCcBQA1gmHN42gK3hL62bdyhUdfXz7xlKbwNa+wcpHuVOtbzIHp0g1VO10Jv+bOJYdYNhoS8= X-Received: by 2002:a0d:df08:0:b0:609:60d0:34d3 with SMTP id i8-20020a0ddf08000000b0060960d034d3mr5516244ywe.42.1709911546020; Fri, 08 Mar 2024 07:25:46 -0800 (PST) MIME-Version: 1.0 References: <20240306232401.1408530-1-hjl.tools@gmail.com> <20240306232401.1408530-4-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Fri, 8 Mar 2024 07:25:09 -0800 Message-ID: Subject: Re: [PATCH v4 3/6] elf: Use mmap to map in read-only sections To: Alan Modra Cc: binutils@sourceware.org, goldstein.w.n@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 7, 2024 at 4:40=E2=80=AFPM Alan Modra wrote: > > On Wed, Mar 06, 2024 at 03:23:58PM -0800, H.J. Lu wrote: > > Add _bfd_mmap_readonly_tracked and _bfd_mmap_readonly_untracked to mmap > > in reado-only sections with size >=3D 4 * page size. > > These are better names than in the original patch, but I'm thinking > that _bfd_mmap_persistent, _bfd_mmap_temporary and > _bfd_munmap_temporary or some variation on that might better reflect > their use. Changed. > > (setup_group): Call _bfd_mmap_readonly_tracked instead of > > _bfd_alloc_and_read to map in the group section as read-only > > and allocate the memory for internal use separately. > > I doubt you will usually get to the minimum mmap size for SHT_GROUP > sections. So this change will often require a malloc'd buffer for > section contents. (The internal buffer is always at least as large as > the section contents. The current code uses the same buffer for both > external section contents and the internal representation.) So I > think it is better to continue to use _bfd_alloc_and_read here. Dropped. > Other than that, this is OK. > Thanks. --=20 H.J.