From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] gas/x86-64: properly distinguish low and high register ranges
Date: Mon, 30 Jul 2012 16:05:00 -0000 [thread overview]
Message-ID: <CAMe9rOpkWhd8idXjWVQSYTQu6xQyZHfG7SkN54m28xasgp8YeA@mail.gmail.com> (raw)
In-Reply-To: <500FB4C4020000780009058B@nat28.tlf.novell.com>
On Tue, Jul 24, 2012 at 11:56 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 24.07.12 at 16:16, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>> Can you add some testcases?
>
> I knew you would ask this, but sorry, this makes no sense - if test
> cases would are desirable here, they shouldn't be testing just the
> things that this patch fixes, but also any other invalid operand
> combinations. As an example - why would testing that "xlat [r11]"
> isn't accepted be needed, but not e.g. "xlat [ecx]"?
>
> Furthermore, this fixes actually broken behavior, so accepting
> the change shouldn't be dependent upon test case availability.
>
What broken behavior does this change fix? Why hasn't it been
tested in the testsuite?
--
H.J.
next prev parent reply other threads:[~2012-07-30 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 14:14 Jan Beulich
[not found] ` <CAMe9rOrY+ECKpfYM23heJB4Ma1BT9aFd2+-z1oVdhq3EiXwdRQ@mail.gmail.com>
2012-07-25 6:56 ` Jan Beulich
2012-07-30 16:05 ` H.J. Lu [this message]
2012-07-31 6:24 ` Jan Beulich
2012-07-31 15:49 ` H.J. Lu
2012-07-31 16:28 ` Jan Beulich
2012-07-31 18:45 ` H.J. Lu
2012-08-07 10:29 ` [PATCH, v2] " Jan Beulich
2012-08-07 14:02 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpkWhd8idXjWVQSYTQu6xQyZHfG7SkN54m28xasgp8YeA@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).