From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-109289-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 51691 invoked by alias); 4 Mar 2020 11:56:58 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 51681 invoked by uid 89); 4 Mar 2020 11:56:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:1337dfa, H*f:sk:1337dfa
X-HELO: mail-ot1-f67.google.com
Received: from mail-ot1-f67.google.com (HELO mail-ot1-f67.google.com) (209.85.210.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Mar 2020 11:56:57 +0000
Received: by mail-ot1-f67.google.com with SMTP id v19so1708024ote.8        for <binutils@sourceware.org>; Wed, 04 Mar 2020 03:56:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=wsgWeJaj1cgw/uEzuzo3n551OratRkZUfxhNRvLs8QQ=;        b=MhzUAIeKHZnLV64C7q3TRbXtuM/Fez7Sz3o8gmIWZqFOLwlZknIBZ0/ZlIJJedJV0Z         m4I7KhuGAMGJDqNuwpS2uVeK8ZEvflPwXXiR4jbJV/HsOHj3fFoe4b5lG0m3PTBGgrH+         QGy1lOGmBvf2xot7ZBnRo+fS7nlhxdsZw3b+FmTRb4bibUopWeIwvgUEbI4W/Rp899DV         +IMuLnbW7iOdZSIHBMKOiyZdPyAglP6Dw9w60GyJvI/UMk0LEqFvkJgcZi+mOm9uOYAa         TNBamWuIPYhKv0HxemLdBJX/N4au+aUMAfIyjLs8ARpn1bk9BXrZqRgH05GDoIpKTaM8         QOqQ==
MIME-Version: 1.0
References: <e50faefe-9bed-e844-7e7f-0cfd49395da4@suse.com> <1337dfaf-a8c4-b0f9-b127-769b2cc48718@suse.com>
In-Reply-To: <1337dfaf-a8c4-b0f9-b127-769b2cc48718@suse.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 04 Mar 2020 11:56:00 -0000
Message-ID: <CAMe9rOpm-t5ykhQS3r+fQDScK3J2JnYKUQpgwybe98h6O0EWvQ@mail.gmail.com>
Subject: Re: [PATCH 7/9] x86: fold (supposed to be) identical code
To: Jan Beulich <jbeulich@suse.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2020-03/txt/msg00096.txt

On Wed, Mar 4, 2020 at 1:40 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> The Q and L suffix exclusion checks in match_template() ought to be
> (kept) in sync as far as their FPU and SIMD aspects go. This was
> already violated by only the Q one checking for active broadcast.
> Convert the code such that there'll be only one instance of the logic,
> the more that subsequently the logic is liable to need further
> refinement / extension. (The alternative would be to drop all SIMD-ness
> from the L part, but it is in principle possible to enable all sorts of
> SIMD support with just a pre-386 CPU, via suitable .arch directives.)
>
> gas/
> 2020-03-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * config/tc-i386.c (match_template): Fold duplicate code in
>         logic rejecting certain suffixes in certain modes. Drop
>         pointless "else".
>

OK.

Thanks.

-- 
H.J.