From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by sourceware.org (Postfix) with ESMTPS id 7F7D13858D38 for ; Sat, 16 Mar 2024 15:36:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F7D13858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F7D13858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710603410; cv=none; b=fpwHfOAbIn5mSbzJN2fEBBnDZg8uDKhMp1JFgjinQdUOCKIapHJUw6sKosnzLFJN92VX53Jda1DWFeT25ZV9wbYv+6iB1JO7XpqglbMo4Jb+jYPaykvD0df+5hmFwq7cODeKDYxw0TlP/Bx4fvflLoVyKSQYg7c/Wa+ji4H+z5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710603410; c=relaxed/simple; bh=6cBl7wxML+/ZOe30FMDN8RrTK6ku2PV0cWBf6XhnVzg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=faygPhSo/hfzqPq66kUVxOS7LsTbKPiYSV1jMEdD08JagZznknvIlP5psm8Rdr4qzrRAwA1da7RvGb5r0G7tlx+tb9EAjNjv88pIofknHzV3v6NGLuW6+A9R+pHjFfYe9z/wAbprnmgZ+J4eOOtklApOI+JkDNlfKdJWfAXybcU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so2601813276.1 for ; Sat, 16 Mar 2024 08:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710603407; x=1711208207; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ck6o89sELkfxw2MCt/0cdIjWfXm0uxuk90TxB7Uy/aM=; b=Xs66qUcFSyQMtpFYwyK9ZkjsFXc9uGBhv9KqGav7d0BvrM7wDElZbBn+g212XkcWqC APXIGIuPTtAckJmQn269/TknN9tU+aj4MsY0u2O08gRT00GuObeSHTESMbi05WR38Ahm d39fwabuktPk3Midg0zyjo+kErDb+5v9gvCxGkcXFF/su3u6nWWllGBVBnu8QuarIFfb aai5ThSjfuIIIspX+8cP2guFIJeVk1/e4N7DbJLXWVzAv70m3yteNz3dZXXwIW0nzGCf lEqVLi4Pc2WxGrbrEJsL6bHtZZsPS7Miur4Paf88p/IyqS9IY86RlQnC6iY/f7cbzkOO NPjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710603407; x=1711208207; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ck6o89sELkfxw2MCt/0cdIjWfXm0uxuk90TxB7Uy/aM=; b=ZQCfbR3HYR2BqTsIpxAJFAWn+KChiVBMpBacu6P0AYqe8EwHent0AZN6X+7iyJS226 eL2PZFNk7MGG308h1lwIGCAKTKTUYnE8VrF1dj8MkOTMIg/b05odXLqecLbZWxjs9pqA cPDN0cQ4shyEFnBv4BgOp/TeRM7ybv9llTwGNHjmaLmRIIKtduVrVOCOXxeMwWzGYCFD vYzJkGguOcKapP+hBmhsfn+hhDCv6wdUchRt5Ea7EgLpbYdcu1n0ioTvwfYfYAfBeGii tYCFhW/RNnwsfkaOf0jdVccWyEM6YsC6SKdeMwA8QlknGoIt4GwKnABdCY2uNDweJy+9 3gdQ== X-Gm-Message-State: AOJu0YzpuLFNZvN858//eGse9Y/D30M66Z7gLBl8LOwbiF2fe0W1bCUo l6y5WGvqSk+wSjAJ3pspBHvtjC4xKyg30d27tsiGfrDtlIlw9VSxUy7qgFlaLveOtQ6NC6vuOhV PYUB5pjOv8EoSvnYX5u8QXff5fXnSO0ZOfbg= X-Google-Smtp-Source: AGHT+IGAF66Hfeclv0q8VWRknB2fp7MZpFIM5kFCFcdwxSRc1AdFs98GJyRZ9/OTq78nm6qsjx3Xz8ifIAlIcuDJBO8= X-Received: by 2002:a81:6fc5:0:b0:608:2b27:9e6d with SMTP id k188-20020a816fc5000000b006082b279e6dmr7413071ywc.28.1710603407445; Sat, 16 Mar 2024 08:36:47 -0700 (PDT) MIME-Version: 1.0 References: <20240316133932.352523-1-hjl.tools@gmail.com> <87cyrujiwi.fsf@igel.home> In-Reply-To: <87cyrujiwi.fsf@igel.home> From: "H.J. Lu" Date: Sat, 16 Mar 2024 08:36:11 -0700 Message-ID: Subject: Re: [PATCH] ld: Support LD_UNDER_TEST environment variable To: Andreas Schwab Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Mar 16, 2024 at 8:28=E2=80=AFAM Andreas Schwab wrote: > > On M=C3=A4r 16 2024, H.J. Lu wrote: > > > @@ -64,9 +77,16 @@ remote_exec host "mkdir -p tmpdir" > > if {[info exists ld_testsuite_bindir]} { > > set gcc_B_opt "-B$ld_testsuite_bindir/" > > } else { > > + if [info exists env(LD_UNDER_TEST)] { > > + file delete -force tmpdir/ld > > + } > > if {![file isdirectory tmpdir/ld]} then { > > catch "exec mkdir tmpdir/ld" status > > - catch "exec ln -s ../../ld-new tmpdir/ld/ld" status > > + if [info exists env(LD_UNDER_TEST)] { > > + catch "exec ln -s $env(LD_UNDER_TEST) tmpdir/ld/ld" status > > That won't do the right thing if LD_UNDER_TEST is relative. > The v2 patch: https://sourceware.org/pipermail/binutils/2024-March/133061.html checks the absolute full path instead. --=20 H.J.