From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-81459-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 14807 invoked by alias); 8 Oct 2013 15:34:02 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 14797 invoked by uid 89); 8 Oct 2013 15:34:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-oa0-f46.google.com
Received: from mail-oa0-f46.google.com (HELO mail-oa0-f46.google.com) (209.85.219.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 08 Oct 2013 15:34:01 +0000
Received: by mail-oa0-f46.google.com with SMTP id k14so7575930oag.19        for <binutils@sourceware.org>; Tue, 08 Oct 2013 08:33:59 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.182.53.196 with SMTP id d4mr1664242obp.7.1381246439712; Tue, 08 Oct 2013 08:33:59 -0700 (PDT)
Received: by 10.76.110.15 with HTTP; Tue, 8 Oct 2013 08:33:59 -0700 (PDT)
In-Reply-To: <52543F7202000078000F9B07@nat28.tlf.novell.com>
References: <5254349502000078000F9A3D@nat28.tlf.novell.com>	<525435E002000078000F9A55@nat28.tlf.novell.com>	<CAMe9rOqDp1_mAdthvC=kJt_71K4b59kBXEAguGNMBKhrw24Upg@mail.gmail.com>	<52543F7202000078000F9B07@nat28.tlf.novell.com>
Date: Tue, 08 Oct 2013 15:34:00 -0000
Message-ID: <CAMe9rOptKg-2WiZ7PRjgmhUz=gWzexfy6BsDy_MPVP95c-uQvw@mail.gmail.com>
Subject: Re: [PATCH 3/6] x86/MPX: suppress base/index swapping in Intel mode for bndmk, bndldx, and bndstx
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: kirill.yukhin@intel.com, Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
X-SW-Source: 2013-10/txt/msg00083.txt.bz2

On Tue, Oct 8, 2013 at 8:22 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 08.10.13 at 17:16, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>> On Tue, Oct 8, 2013 at 7:42 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> bndmk, bndldx, and bndstx assign special meaning to base and index
>>> registers, and hence silently swapping the registers should be
>>> suppressed.
>>>
>>> gas/
>>> 2013-10-08  Jan Beulich <jbeulich@suse.com>
>>>
>>>         * tc-i386.c (i386_intel_simplify_register): Suppress base/index
>>>         swapping for bndmk, bndldx, and bndstx.
>>>
>>> --- 2013-10-07/gas/config/tc-i386-intel.c
>>> +++ 2013-10-07/gas/config/tc-i386-intel.c
>>> @@ -291,6 +291,8 @@ i386_intel_simplify_register (expression
>>>    else if (!intel_state.index)
>>>      {
>>>        if (intel_state.in_scale
>>> +          || current_templates->start->base_opcode == 0xf30f1b /* bndmk */
>>> +          || (current_templates->start->base_opcode & ~1) == 0x0f1a /* bnd{ld,st}x */
>>>           || i386_regtab[reg_num].reg_type.bitfield.baseindex)
>>>         intel_state.index = i386_regtab + reg_num;
>>>        else
>>>
>>>
>>>
>>
>> We need a testcase for this.
>
> Which is included in patch 1!

Does that mean I got "make check" failure with patch 1 applied?
A patch shouldn't introduce a "make check" failure and a testcase
should be together with the change.


-- 
H.J.