From: "H.J. Lu" <hjl.tools@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Alan Modra <amodra@gmail.com>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] Support symbol+offset lookup in addr2line
Date: Thu, 3 Feb 2022 18:44:29 -0800 [thread overview]
Message-ID: <CAMe9rOptMuyo9KGLA6ESBrKfsYbpyRB7PTBFiC2pugzUSMOpOQ@mail.gmail.com> (raw)
In-Reply-To: <20220204023406.3nhhasy35hddxh6t@two.firstfloor.org>
On Thu, Feb 3, 2022 at 6:34 PM Andi Kleen <andi@firstfloor.org> wrote:
>
> On Thu, Dec 30, 2021 at 06:27:49PM +1030, Alan Modra wrote:
> > On Thu, Dec 23, 2021 at 09:55:07AM -0800, Andi Kleen wrote:
> > > This patch implements the necessary steps directly in addr2line,
> > > by looking up the symbol (with demangling if needed) and computing
> > > the offset.
> >
> > Looks OK to me.
>
> If there are no further objections, could someone please commit
> the patch? Thanks,
> -Andi
I pushed it for you.
--
H.J.
prev parent reply other threads:[~2022-02-04 2:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 17:55 Andi Kleen
2021-12-30 7:57 ` Alan Modra
2022-02-04 2:34 ` Andi Kleen
2022-02-04 2:44 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOptMuyo9KGLA6ESBrKfsYbpyRB7PTBFiC2pugzUSMOpOQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=andi@firstfloor.org \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).