From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14575 invoked by alias); 24 Apr 2016 01:43:12 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 14558 invoked by uid 89); 24 Apr 2016 01:43:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2709, our X-HELO: mail-qg0-f45.google.com Received: from mail-qg0-f45.google.com (HELO mail-qg0-f45.google.com) (209.85.192.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 24 Apr 2016 01:43:01 +0000 Received: by mail-qg0-f45.google.com with SMTP id f92so19893882qgf.0 for ; Sat, 23 Apr 2016 18:43:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=1vsWSOj3nuB7TxDCw8gbweyB20rRqAWEbTtFntpVbrA=; b=XF4G0j6iVRTWL+RRyeuJV4QASzOq4R6pTFoe4IJLCRHC68Mr0goDA87esJIRJyLIfJ Lokl27AOavPvfB9CfbCnD/B9CbygZFpoTqBOELAbbevtPf93OVFmrNMBgPMpwCFpgP+A uhegcp5+PYHF1YyW6wkV+RyOa+ejhKKegJBdBh021NI1/bq79ia+0LHFlxFqfRMZ1KPg Klqboq1tfc9Odhca7glR83er+kujTHt0hG79M2QJJC0RgADhNOQwX/HbEGDgANp33kRj 41DOeuwwh84Rdz/cLzJJKjSIFUuv1u4K6C347ds3VmeHnBlkrPFI2t2tYrm1ozd+fFsC sDDw== X-Gm-Message-State: AOPr4FVpGb6ZJZFxhXycV3eOTNULPjtPk+t17VdyG8Q4RYnOiZ8LtQdANXJSAdfCuSa5F6Pqqh74XkdTftcYEg== MIME-Version: 1.0 X-Received: by 10.140.23.139 with SMTP id 11mr27699933qgp.62.1461462179142; Sat, 23 Apr 2016 18:42:59 -0700 (PDT) Received: by 10.55.217.134 with HTTP; Sat, 23 Apr 2016 18:42:58 -0700 (PDT) In-Reply-To: <571BCC3A.6090700@imgtec.com> References: <20160223003208.GA30022@intel.com> <571A59A8.4000700@imgtec.com> <571A73BE.4000709@imgtec.com> <571AD1EE.1040005@imgtec.com> <571ADE8F.9000000@imgtec.com> <571B93C6.5030007@imgtec.com> <571BCC3A.6090700@imgtec.com> Date: Sun, 24 Apr 2016 01:43:00 -0000 Message-ID: Subject: Re: [committed, PATCH] Always create dynsym section with dynamic sections From: "H.J. Lu" To: Faraz Shahbazker Cc: Binutils Content-Type: multipart/mixed; boundary=001a11c14b0c0ab4a60531312e3b X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00398.txt.bz2 --001a11c14b0c0ab4a60531312e3b Content-Type: text/plain; charset=UTF-8 Content-length: 837 On Sat, Apr 23, 2016 at 12:25 PM, Faraz Shahbazker wrote: >>>> You said dynsym should be treated treated the same for static and >>>> dynamic executables. dynsymcount is number of dynsym + 1 in >>>> dynamic executable. Why isn't it true for static executable? >>> >>> It is, or at least used to be, before this patch. It still is for both, >>> before renumbering. But now the +1 only happens for dynamic executables >>> when renumbering. >> >> Then what is wrong to always +1 for both dynamic and static >> executables? > > Aah, now I see! Ever since the table was created, the count was at least 1. > You are saying it should always remain at least 1 no matter what. Had a quick > look through other uses of the field and it looks safe enough to me. > Here is a patch. Does it work for you? -- H.J. --001a11c14b0c0ab4a60531312e3b Content-Type: text/x-patch; charset=US-ASCII; name="0001-Always-count-the-NULL-entry-in-dynamic-symbol-table.patch" Content-Disposition: attachment; filename="0001-Always-count-the-NULL-entry-in-dynamic-symbol-table.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_indwufm00 Content-length: 2538 RnJvbSBmNTQyNzBmYzVhMzQyZWQ4ZWFkMTdlOTU3MzFjM2IwYzJlN2ExZWNj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IFNhdCwgMjMgQXByIDIwMTYgMTg6 Mzc6NTkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBBbHdheXMgY291bnQgdGhl IE5VTEwgZW50cnkgaW4gZHluYW1pYyBzeW1ib2wgdGFibGUKClRoZXJlIGlz IGFuIHVudXNlZCBOVUxMIGVudHJ5IGF0IHRoZSBoZWFkIG9mIGR5bmFtaWMg c3ltYm9sIHRhYmxlIHdoaWNoCndlIG11c3QgYWNjb3VudCBmb3IgaW4gb3Vy IGNvdW50IGV2ZW4gaWYgdGhlIHRhYmxlIGlzIGVtcHR5IG9yIHVudXNlZC4K CgkqIGVsZi1iZmQuaCAoZWxmX2xpbmtfaGFzaF90YWJsZSk6IFVwZGF0ZSBj b21tZW50cyBmb3IKCWR5bnN5bWNvdW50LgoJKiBlbGZsaW5rLmMgKF9iZmRf ZWxmX2xpbmtfcmVudW1iZXJfZHluc3ltcyk6IEFsd2F5cyBjb3VudCBmb3IK CXRoZSB1bnVzZWQgTlVMTCBlbnRyeSBhdCB0aGUgaGVhZCBvZiBkeW5hbWlj IHN5bWJvbCB0YWJsZS4KLS0tCiBiZmQvZWxmLWJmZC5oIHwgMiArLQogYmZk L2VsZmxpbmsuYyB8IDggKysrLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNCBp bnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Jm ZC9lbGYtYmZkLmggYi9iZmQvZWxmLWJmZC5oCmluZGV4IDVkY2U3MGUuLmRl NzIxZjAgMTAwNjQ0Ci0tLSBhL2JmZC9lbGYtYmZkLmgKKysrIGIvYmZkL2Vs Zi1iZmQuaApAQCAtNTIwLDcgKzUyMCw3IEBAIHN0cnVjdCBlbGZfbGlua19o YXNoX3RhYmxlCiAgIHVuaW9uIGdvdHBsdF91bmlvbiBpbml0X2dvdF9vZmZz ZXQ7CiAgIHVuaW9uIGdvdHBsdF91bmlvbiBpbml0X3BsdF9vZmZzZXQ7CiAK LSAgLyogVGhlIG51bWJlciBvZiBzeW1ib2xzIGZvdW5kIGluIHRoZSBsaW5r IHdoaWNoIG11c3QgYmUgcHV0IGludG8KKyAgLyogVGhlIG51bWJlciBvZiBz eW1ib2xzIGZvdW5kIGluIHRoZSBsaW5rIHdoaWNoIGlzIGludGVuZGVkIGZv cgogICAgICB0aGUgLmR5bnN5bSBzZWN0aW9uLiAgKi8KICAgYmZkX3NpemVf dHlwZSBkeW5zeW1jb3VudDsKIApkaWZmIC0tZ2l0IGEvYmZkL2VsZmxpbmsu YyBiL2JmZC9lbGZsaW5rLmMKaW5kZXggNmY2NzI2Ni4uMTc3NTFjZiAxMDA2 NDQKLS0tIGEvYmZkL2VsZmxpbmsuYworKysgYi9iZmQvZWxmbGluay5jCkBA IC05MDUsMTEgKzkwNSw5IEBAIF9iZmRfZWxmX2xpbmtfcmVudW1iZXJfZHlu c3ltcyAoYmZkICpvdXRwdXRfYmZkLAogCQkJICBlbGZfbGlua19yZW51bWJl cl9oYXNoX3RhYmxlX2R5bnN5bXMsCiAJCQkgICZkeW5zeW1jb3VudCk7CiAK LSAgLyogVGhlcmUgaXMgYW4gdW51c2VkIE5VTEwgZW50cnkgYXQgdGhlIGhl YWQgb2YgdGhlIHRhYmxlIHdoaWNoCi0gICAgIHdlIG11c3QgYWNjb3VudCBm b3IgaW4gb3VyIGNvdW50LiAgV2UgYWx3YXlzIGNyZWF0ZSB0aGUgZHluc3lt Ci0gICAgIHNlY3Rpb24sIGV2ZW4gaWYgaXQgaXMgZW1wdHksIHdpdGggZHlu YW1pYyBzZWN0aW9ucy4gICovCi0gIGlmIChlbGZfaGFzaF90YWJsZSAoaW5m byktPmR5bmFtaWNfc2VjdGlvbnNfY3JlYXRlZCkKLSAgICArK2R5bnN5bWNv dW50OworICAvKiBUaGVyZSBpcyBhbiB1bnVzZWQgTlVMTCBlbnRyeSBhdCB0 aGUgaGVhZCBvZiB0aGUgdGFibGUgd2hpY2ggd2UKKyAgICAgbXVzdCBhY2Nv dW50IGZvciBpbiBvdXIgY291bnQgZXZlbiBpZiB0aGUgdGFibGUgaXMgZW1w dHkuICAqLworICBkeW5zeW1jb3VudCsrOwogCiAgIGVsZl9oYXNoX3RhYmxl IChpbmZvKS0+ZHluc3ltY291bnQgPSBkeW5zeW1jb3VudDsKICAgcmV0dXJu IGR5bnN5bWNvdW50OwotLSAKMi41LjUKCg== --001a11c14b0c0ab4a60531312e3b--