From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 9D9763858D35 for ; Fri, 14 Jan 2022 14:03:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D9763858D35 Received: by mail-pj1-x1035.google.com with SMTP id a1-20020a17090a688100b001b3fd52338eso13079002pjd.1 for ; Fri, 14 Jan 2022 06:03:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jns2O2F0MFbU12zQvG0FMkoJUCEoYtIOqgi6xYIj0mg=; b=BagnPv9NsZRyWXyWx4rldWHzvER+ddfUGzu6rdCI1pmAdJ0iQGvqmp6wihFwsop6gt 43eg4RArbqjBzLK9rxLZbi4LJgcv6fky33qXqP4Togo9m4941+OIpqIH+zOBJ5JG4Vvw mL1xMIB9AylyLCwYpq7jEOWLJKXfKOGs7frkvSZfZXCH5SB0zlwqfEgtCxasgwbYtGvF 0/YvBexqc1KJw3fXuJYePKFrmCxraS1UNFndVW488zd3sUzmafdFjyGVYVO1A/f8Jxux GPyi4UbHmsAnq900/5eR+MXZ18ZJS5n+WjdwoCyeAJq5exjy3w5OcYbUJHR9CjjCiqU3 iJeQ== X-Gm-Message-State: AOAM532pKa5PqOTllTmUHg/DpACXnKPHhKsGsIF6MbKQxzD/Tn+k3fmm bpcmXkqxmMMzwcnPp6HQGJWeMCgHRDTP1dlEyznjjQZB X-Google-Smtp-Source: ABdhPJx8hX+yKX0vzvIZ3nIi9yEl1tm2tqzzz+m+V6TveH7KCSUzdQAquJk8XBXjZoNwPbvv8tIXK8NB1ocvmIx8+N0= X-Received: by 2002:a17:90b:4f86:: with SMTP id qe6mr19964086pjb.120.1642169003536; Fri, 14 Jan 2022 06:03:23 -0800 (PST) MIME-Version: 1.0 References: <20211229193949.146079-1-hjl.tools@gmail.com> <11e134a2-1ee7-bec4-fa03-1d76609923f7@suse.com> <5843914b-e666-3c55-2e5b-5b320d55cf51@suse.com> In-Reply-To: <5843914b-e666-3c55-2e5b-5b320d55cf51@suse.com> From: "H.J. Lu" Date: Fri, 14 Jan 2022 06:02:47 -0800 Message-ID: Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3021.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 14:03:26 -0000 On Fri, Jan 14, 2022 at 5:40 AM Jan Beulich wrote: > > On 14.01.2022 14:03, H.J. Lu wrote: > > On Fri, Jan 14, 2022 at 12:27 AM Jan Beulich wrote: > >> > >> On 29.12.2021 20:39, H.J. Lu via Binutils wrote: > >>> --- a/ld/testsuite/ld-elf/linux-x86.exp > >>> +++ b/ld/testsuite/ld-elf/linux-x86.exp > >>> @@ -185,6 +185,42 @@ run_ld_link_exec_tests [list \ > >>> "" \ > >>> "tmpdir/indirect-extern-access-2.so" \ > >>> ] \ > >>> + [list \ > >>> + "Run p_align-1a without PIE" \ > >>> + "$NOPIE_LDFLAGS" \ > >>> + "" \ > >>> + { p_align-1.c } \ > >>> + "p_align-1a" \ > >>> + "pass.out" \ > >>> + "$NOPIE_CFLAGS" \ > >>> + ] \ > >>> + [list \ > >>> + "Run p_align-1b with PIE" \ > >>> + "-pie" \ > >>> + "" \ > >>> + { p_align-1.c } \ > >>> + "p_align-1b" \ > >>> + "pass.out" \ > >>> + "-fpie" \ > >>> + ] \ > >>> + [list \ > >>> + "Run p_align-1c with -Wl,-z,max-page-size=0x1000 without PIE" \ > >>> + "$NOPIE_LDFLAGS -Wl,-z,max-page-size=0x1000" \ > >>> + "" \ > >>> + { p_align-1.c } \ > >>> + "p_align-1c" \ > >>> + "pass.out" \ > >>> + "$NOPIE_CFLAGS" \ > >>> + ] \ > >>> + [list \ > >>> + "Run p_align-1d with -Wl,-z,max-page-size=0x1000 with PIE" \ > >>> + "-pie -Wl,-z,max-page-size=0x1000" \ > >>> + "" \ > >>> + { p_align-1.c } \ > >>> + "p_align-1d" \ > >>> + "pass.out" \ > >>> + "-fpie" \ > >>> + ] \ > >>> ] > >> > >> The two PIE variants of this also fail for me on glibc 2.26. Looks > >> like LOAD segments' alignment isn't being honored there, at least > >> not if it's as big as it is here. > >> > > > > The PIE alignment needs the kernel fix: > > > > commit ce81bb256a224259ab686742a6284930cbe4f1fa > > Author: Chris Kennelly > > Date: Thu Oct 15 20:12:32 2020 -0700 > > > > fs/binfmt_elf: use PT_LOAD p_align values for suitable start address > > Well, then the test needs to be skipped if that fix is not in place. > After all you're testing binutils behavior here, not kernel or libc one. > I'm running a variety of (largely up-to-date) kernels on all of my > systems. But it looks like our kernel folks decided against backporting > this particular change. And I don't think you expect people to remember > to run the testsuite only on top of "certain" kernels? Care to submit a patch? -- H.J.