From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17465 invoked by alias); 27 Sep 2013 18:08:22 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 17452 invoked by uid 89); 27 Sep 2013 18:08:21 -0000 Received: from mail-ve0-f180.google.com (HELO mail-ve0-f180.google.com) (209.85.128.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 27 Sep 2013 18:08:21 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f180.google.com Received: by mail-ve0-f180.google.com with SMTP id jz11so2321861veb.11 for ; Fri, 27 Sep 2013 11:08:18 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.52.165.131 with SMTP id yy3mr6269700vdb.25.1380305298251; Fri, 27 Sep 2013 11:08:18 -0700 (PDT) Received: by 10.58.106.81 with HTTP; Fri, 27 Sep 2013 11:08:18 -0700 (PDT) In-Reply-To: <523CE553.9060401@archlinux.org> References: <20130920082810.15E0F7F9DD5@ulanbator.act-europe.fr> <523C3728.1000008@archlinux.org> <523CE553.9060401@archlinux.org> Date: Fri, 27 Sep 2013 18:08:00 -0000 Message-ID: Subject: Re: binutils-2.23.90 snapshot is available From: "H.J. Lu" To: Allan McRae Cc: Tristan Gingold , Binutils Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00145.txt.bz2 On Fri, Sep 20, 2013 at 5:16 PM, Allan McRae wrote: > On 20/09/13 21:53, Allan McRae wrote: >> On 20/09/13 18:28, Tristan Gingold wrote: >>> Hi, >>> >>> I have just uploaded prerelease 2.23.90 for binutils 2.24 at: >>> ftp://sourceware.org/pub/binutils/snapshots/binutils-2.23.90.tar.bz2 >>> >>> b278da68838a5548e671ad835576a8fe binutils-2.23.90.tar.bz2 >>> >>> This snapshot was sanity-checked for i686-pc-linux-gnu >>> Please test it for your favorite hosts/targets. >>> >>> Tristan. >> >> I see one new failure on Arch Linux x86_64-unknown-linux-gnu: >> FAIL: objcopy on compressed debug sections >> >> This happened since I last built from binutils trunk at the start of August. >> > > I bisected this to: > > https://sourceware.org/git/?p=binutils.git;a=commit;h=4ff704e222625f8bd160755902d8548c0a4ae2d8 > > * dwarf.c (dwarf_vmatoa): Rename to dwarf_vmatoa_1 and add a > > Allan We get cie_id from SAFE_BYTE_GET_AND_INC (cie_id, start, offset_size, end); The size of cie_id is offset_size, not fc->ptr_size. I checked this patch into trunk. OK for 2.24 branch? Thanks. -- H.J. -- diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 5f64635..95ada6f 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2013-09-27 H.J. Lu + + * dwarf.c (display_debug_frames): Pass offset_size to + print_dwarf_vma for cie_id. + 2013-09-20 Alan Modra * configure: Regenerate. diff --git a/binutils/dwarf.c b/binutils/dwarf.c index 8a233aa..bd73647 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -5249,7 +5249,7 @@ display_debug_frames (struct dwarf_section *section, printf ("\n%08lx ", (unsigned long) (saved_start - section_start)); print_dwarf_vma (length, fc->ptr_size); - print_dwarf_vma (cie_id, fc->ptr_size); + print_dwarf_vma (cie_id, offset_size); if (do_debug_frames_interp) { @@ -5385,7 +5385,7 @@ display_debug_frames (struct dwarf_section *section, printf ("\n%08lx %s %s FDE cie=%08lx pc=", (unsigned long)(saved_start - section_start), dwarf_vmatoa_1 (NULL, length, fc->ptr_size), - dwarf_vmatoa_1 (NULL, cie_id, fc->ptr_size), + dwarf_vmatoa_1 (NULL, cie_id, offset_size), (unsigned long)(cie->chunk_start - section_start)); if (fc->segment_size) diff --git a/binutils/testsuite/ChangeLog b/binutils/testsuite/ChangeLog index ac2de1f..6c98a13 100644 --- a/binutils/testsuite/ChangeLog +++ b/binutils/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2013-09-27 H.J. Lu + + * binutils-all/x86-64/compressed-1a.d: Updated for 64-bit addresses. + 2013-09-12 Nick Clifton * binutils-all/x86-64/compressed-1a.d: Update expected output to diff --git a/binutils/testsuite/binutils-all/x86-64/compressed-1a.d b/binutils/testsuite/binutils-all/x86-64/compressed-1a.d index 0dfbdc1..f1e4bbc 100644 --- a/binutils/testsuite/binutils-all/x86-64/compressed-1a.d +++ b/binutils/testsuite/binutils-all/x86-64/compressed-1a.d @@ -135,7 +135,7 @@ Contents of the .[z]?debug_str section: Contents of the .[z]?debug_frame section: -00000000 00000014 ffffffff CIE +00000000 0+014 ffffffff CIE Version: 1 Augmentation: "" Code alignment factor: 1 @@ -151,7 +151,7 @@ Contents of the .[z]?debug_frame section: DW_CFA_nop DW_CFA_nop -00000018 00000014 00000000 FDE cie=00000000 pc=0+0000..0+0002 +00000018 0+014 00000000 FDE cie=00000000 pc=0+0000..0+0002 -00000030 00000014 00000000 FDE cie=00000000 pc=0+0010..0+0015 +00000030 0+014 00000000 FDE cie=00000000 pc=0+0010..0+0015