From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 088383858C60 for ; Wed, 2 Nov 2022 16:26:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 088383858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x130.google.com with SMTP id be13so29106819lfb.4 for ; Wed, 02 Nov 2022 09:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kDEd1cHmpFQO9Uky9y68+njh3qV8gJ1LP8g70x7jyic=; b=Uaczwsv+G9IjzmQaLD7ZD5Ge6gEuHiUJS7IlO+gsQjb1xmsRCj5Dqf44a4fY6QpFj6 mqXqcT2QXvrlE4xXt5hmfN/1ckjOigfCc9198Bntn5OX5G5ePmXNw5vBHd7YnglIu77b VRt6yiCCWJ/ONsjainFJITefSSVlPHcsuJK2FkCu/+ZMLcGqiVHz2Rscv28qUrbcaagp sLT6B/gWbaS95GYjFtwAwmKn0ISZabscWuTvaYpZN0tLbhMEOtLwjxVQTo7PT9PvP/5R cq6U+ZCBCCH4qmXBCPUOwkiwi61NR0kPFO57yHEsCe0OKeqleEvQyhOAeaXBqXg7e4zx NC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kDEd1cHmpFQO9Uky9y68+njh3qV8gJ1LP8g70x7jyic=; b=n+okfXM4JAzE1eyyg/M92GR4aKrDy2FuO5VrHOxLDxUfk3Vtr8CrrSEd7wY3WqHNGT qvsuhQSFjX+kwDuWyH14vr71p8V1X8ro5aFEF/9ZZW5loy437M/u2Bvo+1VRutW/6LiM XoESPDSeN8QvtQ6JVcFw7vru4Z+FkSbMIamatRSeXPjuJGyGg8facJ4iShfBRkHRLMn6 McCck6ImMDX00Jt9goAwgOvnppZprg5WiHdBUt8jF5qolAg6FY3C8iFcVovK6YmKHMKj FOEeAawVADBDHuqp3RXCwyosvaZu4csQLl0yckbcggCbYDSI9n5bM666l4CZHQMN03Gy fyRQ== X-Gm-Message-State: ACrzQf2ZxxNT/+bYzfywpT+UIXNZmX4k34G1IMpbPc8rQn18s+8aFe00 LAkFQrngy2VUtr1ZXjufuHK9ECb88v2nqzv0iB4= X-Google-Smtp-Source: AMsMyM4tFgPccoSFnh+uomvhn8+RyLXv3PNg27nnAFfaeKTBienNCbUUAFx70+mOwEEZ3pS3VFZUh6ZMKIlsm9mfJRE= X-Received: by 2002:ac2:4c47:0:b0:4a2:c07b:4b62 with SMTP id o7-20020ac24c47000000b004a2c07b4b62mr9180155lfk.426.1667406367405; Wed, 02 Nov 2022 09:26:07 -0700 (PDT) MIME-Version: 1.0 References: <20221031030507.35588-1-haochen.jiang@intel.com> <20221031030507.35588-4-haochen.jiang@intel.com> <3666195d-32ac-62b8-a03d-41a3bb0bc32b@suse.com> In-Reply-To: <3666195d-32ac-62b8-a03d-41a3bb0bc32b@suse.com> From: "H.J. Lu" Date: Wed, 2 Nov 2022 09:25:30 -0700 Message-ID: Subject: Re: [PATCH 3/6] Support Intel CMPccXADD To: Jan Beulich Cc: Haochen Jiang , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3016.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 2, 2022 at 3:52 AM Jan Beulich wrote: > > On 31.10.2022 04:05, Haochen Jiang wrote: > > --- a/gas/config/tc-i386.c > > +++ b/gas/config/tc-i386.c > > @@ -1098,6 +1098,7 @@ static const arch_entry cpu_arch[] = > > SUBARCH (prefetchi, PREFETCHI, ANY_PREFETCHI, false), > > SUBARCH (avx_ifma, AVX_IFMA, ANY_AVX_IFMA, false), > > SUBARCH (avx_vnni_int8, AVX_VNNI_INT8, ANY_AVX_VNNI_INT8, false), > > + SUBARCH (cmpccxadd, CMPCCXADD, ANY_CMPCCXADD, false), > > ANY_CMPCCXADD shouldn't have been re-introduced here. It now being > there only means more code churn in my patch to sanitize all of this > dependencies handling. (Unless, as I'll mention there as an option, > we want to uniformly use ANY_... in [almost] all table entries). We discussed it. ANY_ doesn't hurt and it can be useful when there is a dependency in the future. > > --- a/opcodes/i386-opc.h > > +++ b/opcodes/i386-opc.h > > @@ -215,6 +215,8 @@ enum > > CpuAVX_IFMA, > > /* Intel AVX VNNI-INT8 Instructions support required. */ > > CpuAVX_VNNI_INT8, > > + /* Intel CMPccXADD instructions support required. */ > > + CpuCMPCCXADD, > > Just as a remark: Personally I would have considered it more readable > overall if this had the "CC" infix in lower case (like in the comment). > > Jan -- H.J.