From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by sourceware.org (Postfix) with ESMTPS id C13AA3858C52 for ; Thu, 29 Feb 2024 12:23:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C13AA3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C13AA3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709209437; cv=none; b=s6VvB54ZGCIJD9Z92fAEOtZtu9uioNwzbND1wryCJ/bKpevOrAGGXXHrr3DloDYpvAfUTfwZXn9wd5cjEZ1CuAwKbgFpOr35z6r3+glRsjBUwllY0VMr5l4bhuGy+xZhYRCWomMXDWuZpU3CsZKKNC+gLExP+U5Yi2EsEWjcg10= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709209437; c=relaxed/simple; bh=yX4eCECop1UYZjSYg7iih80rmLDApJHbb3Y5oswQEE0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=jLVXQjejjaxXgoJTVqj8KpOuJ6ekURTIy5wJ0JklFvO6eC1Ab4Sq2AbRvTUsazyPmo9Y9+AiXe5etoenNReuHpxIBwv4hJzBM2UvELVrpVjmWYtdX/n/nGiCcBof4FpIhrkvIazxE9WdE0TKfgvhzONnYGc+LCy6kvgIZZeoK54= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-609241c2696so9346657b3.0 for ; Thu, 29 Feb 2024 04:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709209435; x=1709814235; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qOSL5ZnW7Bayi69dQSjyNF8oIZ9MgA2TiCJ0gbbrMR8=; b=kgHmymQ/stkdSBn3p22ekWYcNXEJ/QhN4lG845o05xGNEwpS9wGWFxK0Vm9oN8jmLw CjrDRQ+umYl6URrAf5XZ2YnF8auingvZ3uyVScbFt5v5nPMf/OKqavrNP2qYzWvNLLEh 6Ar7adTTBc6MMfdC2qEcczZ49lJFsdmtLx6IjahciFNlmkEoSpIs+DXHZQe11j70LkdN f4VKKkDPXt2VEm7+AQY4Cz08jDialAjBQoyKZDmuxI7Y2UOFmwi+MlMWjMzMr3XqUsvv bEAr1s1hR2v2TwEfu5JnFEL8n7di6dSk4y9bszoJn5YXA9RyEPKGnFlaTqZpaja9agRc 8YkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709209435; x=1709814235; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qOSL5ZnW7Bayi69dQSjyNF8oIZ9MgA2TiCJ0gbbrMR8=; b=Ql6AVfwgQtKzmtjHiqCxrcGibVUuU54bvApxOmF1V5SS9ZHNdaw+Pv7PNE3XfviTak 6C+ISCmmsAy01EOojb14iMM2E10wKn+g2Vxgzn8r5UnOc0wNMT0w1pO8CsuGziLiEocs zn/eBgVIWAr/iiPQ26XK4AV3S7f+qiykytIBDKVhE90mU35dUnGiDQCxct40+lPt6Pwv vRSloVDusU3TwM0SgL10Ubu4s3zFJvhInH/1swLmpS5BVjf358u7rVmjxFn5irL2DHqU FTE5r3pQWO28xGn45Fq3Yep+/nuP6xfnb5McrekfpkZpwxlR5wkhQ6AFO2Mg03u5cTtN 42ow== X-Forwarded-Encrypted: i=1; AJvYcCUkzNiXJ6zIxqZNZeSzB404XrlixFij2a341mlMP2+xhaplr8MIXpL/JbdODABvqzeTGn9gE44WvxG8UxFwDdaYW/W0+lxPQg== X-Gm-Message-State: AOJu0YwJ65EqdFSbMEvBrViTbmBj24g2ItIIMvm8gNOE6FNZcYHG3j+z NpjN01Qo/+FEXPQf8K98VidPQWEaW0SQrS1jSAJV7v9kniklqznyIqg50Q4pzoz92GU86SttwHY bhgVWEIHe487AEgWAlVC1cvt98YE= X-Google-Smtp-Source: AGHT+IEzvQ2aimhcwx0zbzsmIfmkKKpCmkbrFJW5nxKgLSiSA1JJ2tU9m3YNqn2NE4KIg/t3FFL++Rw7QNQsDDSUbFY= X-Received: by 2002:a0d:c8c6:0:b0:607:7cd4:a72c with SMTP id k189-20020a0dc8c6000000b006077cd4a72cmr1781654ywd.2.1709209435024; Thu, 29 Feb 2024 04:23:55 -0800 (PST) MIME-Version: 1.0 References: <20240227090106.200134-1-lili.cui@intel.com> <9fab6a99-5403-43fb-aff2-778ae0c67faf@suse.com> <9311e856-d5b0-47ba-88fa-e1c266f9b48f@suse.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 29 Feb 2024 04:23:18 -0800 Message-ID: Subject: Re: [PATCH] Support APX NF To: "Cui, Lili" Cc: "Beulich, Jan" , "binutils@sourceware.org" , "Lu, Hongjiu" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 29, 2024 at 2:22=E2=80=AFAM Cui, Lili wrot= e: > > > On 29.02.2024 09:39, Cui, Lili wrote: > > >> On 28.02.2024 17:11, H.J. Lu wrote: > > >>> On Tue, Feb 27, 2024 at 1:02=E2=80=AFAM Cui, Lili wrote: > > >>>> > > >>>> gas/ChangeLog: > > >>>> > > >>>> * config/tc-i386.c (enum i386_error): Add unsupported_nf. > > >>>> (struct _i386_insn): Add has_nf. > > >>>> (need_evex_encoding): Ditto. > > >>>> (is_apx_evex_encoding): Ditto. > > >>>> (build_apx_evex_prefix): Encode the NF bit. > > >>>> (md_assemble): Handle unsupported_nf. > > >>>> (parse_insn): Handle Prefix_NF. > > >>>> (match_template): Check NF support. > > >>>> * testsuite/gas/i386/x86-64.exp: Add apx nf tests. > > >>>> * testsuite/gas/i386/x86-64-apx-nf-intel.d: New test. > > >>>> * testsuite/gas/i386/x86-64-apx-nf.d: Ditto. > > >>>> * testsuite/gas/i386/x86-64-apx-nf.s: Ditto. > > >>>> > > >>>> opcodes/ChangeLog: > > >>>> > > >>>> * i386-dis-evex.h: Add %XN to the instructions that suppor= t > > >>>> APX NF > > >> and > > >>>> add new instruction imul, popcnt, tzcnt and lzcnt to EVEX = table. > > >>>> * i386-dis-evex-reg.h: Ditto. > > >>>> * i386-dis.c (struct instr_info): Add nf. > > >>>> (struct dis386): Add "XN" for EVEX.NF. > > >>>> (get_valid_dis386): Set ins->vex.nf. > > >>>> (print_insn): Handle ins.vex.nf. > > >>>> (putop): Handle "%XN". > > >>>> * i386-opc.h (Prefix_NoOptimize): Adjust the value. > > >>>> (Prefix_NF): New. > > >>>> * i386-opc.tbl: Add new entries for the instructions that > > >>>> support APX > > >> NF. > > >>>> * i386-mnem.h: Regenerated. > > >>>> * i386-tbl.h: Regenerated. > > >>>> > > >>> > > >>> Please mention it in gas/NEWS. > > >> > > >> Hmm. I think it wants mentioning once APX support is actually comple= te. > > >> I don't think every sub-feature of it needs mentioning. > > >> > > > > > > Thanks Jan, since this place is easy to forget, I can create an initi= al one, and > > each sub-feature can be appended one by one after the NF, only one ment= ion > > is left at the end. > > > > > > --- a/gas/NEWS > > > +++ b/gas/NEWS > > > @@ -1,5 +1,7 @@ > > > -*- text -*- > > > > > > +* Initial support for Intel APX: NF It isn't initial support for Intel APX. Please use something like Support the NF feature in Intel APX. > > > + > > > > Personally I consider this confusing; imo APX shouldn't have been menti= oned > > in 2.42's gas/NEWS at all. Yet if you and H.J. firmly think that's the = way to go, > > so be it. > > > > For APX NF, it will be placed after 2.42 and belong to 2.43. Since we did= n't implement the entire APX in 2.42, we list the APX sub-feature that it h= as implemented. > > Changes in 2.42: > ... > * Initial support for Intel APX: 32 GPRs, NDD, PUSH2/POP2 and PUSHP/POPP. > > Thanks, > Lili. --=20 H.J.