From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 17F90385800A for ; Thu, 10 Nov 2022 17:23:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 17F90385800A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x533.google.com with SMTP id a13so4185040edj.0 for ; Thu, 10 Nov 2022 09:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TbyQHgR9PuSZ5cFylL9CxCgiE+8rOBl1tDrkRVDElyc=; b=lLh2S41i1AZm2UshDXIsSRufSUy5NJ5Hv2dnNlbbmGl2b5zh/mburGoEf8Mvto/CwW bu3/HVI3dHvCs+opQX3DQJIPmDzm9ZJ/c54t+BDgQC0pO3axn8BdKOmHxdEF1YcPG+e/ tcCifgdze5xDUr/P9uxN9B/YpmxHJh2/BKGxr+vlP9wo8nFOHk5lKF+6pQpXJNVfqhj9 UBXZ7Rehnb1ZNhvCpOr7iiv+FcqjsZvyWOvwxZRt9MZxCmm3hLZ4Qqw+bxE81TYLZQlH mylInhjtfF2MBNn9L5ZWKrruBvUN+3dLBRHoGnCQuY2eIUC6XEpJBEtB+gFxEnxeaVca zTGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TbyQHgR9PuSZ5cFylL9CxCgiE+8rOBl1tDrkRVDElyc=; b=RiUeS7vLhldZfBwS0qs9BMWoKD/Mo8vXTJwp207+qPFRcpMbt1xUqyNZYLRnH5+VuK 8qieRnx93X3VbL3u88l8Fe/jvbpdCq6MUshOJ/AUMQsQQE6nZJ3PtJ7Vb5Y+Vqg07NuU PYBOOLZJ/mstRvv0qQ1yKBeNggZgPhYa4lZLUK215Al9FZ6SY4hxCOQShp7wnVtDTPfO PvBUBqRdVgGHz9C5z5Rmn1byHZT1tvuiqdbKu1+q5FOyKUzqMhyFHhufwH0clItoM5ok hIueWWFMOfuhUNAqpDwPVDvm44RYUStvk1ZfGXN0V5N+9S00vXvYJqMJuzBU0W62ZhQY MPhw== X-Gm-Message-State: ACrzQf3WU7zICTxF7a1cghF9P2Edmv6zymXnzB0ND7pf6E/kBd265Cki CNDNXy/qAp6Fm5h0tj4W4M0HXFnS4frzQSy2g7ezpCOD X-Google-Smtp-Source: AMsMyM5H8u4IizWcwbUZSupiOrCdY4VBhB/guABHVo1yoGvA5NekeBnN/K/EUeVMA1TyBRwpt2aaO2Ol4hSELyyW28g= X-Received: by 2002:aa7:d9cf:0:b0:45d:2a5:2db8 with SMTP id v15-20020aa7d9cf000000b0045d02a52db8mr2779026eds.105.1668101033703; Thu, 10 Nov 2022 09:23:53 -0800 (PST) MIME-Version: 1.0 References: <25e8786d-289e-0521-baa2-2f2b85124dfe@suse.com> In-Reply-To: <25e8786d-289e-0521-baa2-2f2b85124dfe@suse.com> From: "H.J. Lu" Date: Thu, 10 Nov 2022 09:23:15 -0800 Message-ID: Subject: Re: [PATCH v2] x86: drop stray IsString from PadLock insns To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 10, 2022 at 4:12 AM Jan Beulich wrote: > > The need for IsString on the PadLock insns went away with the > introduction of RepPrefixOk. Drop these leftovers. > --- > v2: Also drop now dead code from tc-i386.c. > > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -11174,7 +11174,6 @@ i386_index_check (const char *operand_st > const insn_template *t = current_templates->start; > > if (t->opcode_modifier.isstring > - && !t->cpu_flags.bitfield.cpupadlock > && (current_templates->end[-1].opcode_modifier.isstring > || i.mem_operands)) > { > --- a/opcodes/i386-opc.tbl > +++ b/opcodes/i386-opc.tbl > @@ -1979,24 +1979,24 @@ lzcnt, 0xf30fbd, None, CpuLZCNT, Modrm|C > popcnt, 0xf30fb8, None, CpuPOPCNT, Modrm|CheckRegSize|No_bSuf|No_sSuf|No_ldSuf, { Reg16|Reg32|Reg64|Word|Dword|Qword|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } > > // VIA PadLock extensions. > -xstore-rng, 0xfa7c0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcrypt-ecb, 0xf30fa7c8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcrypt-cbc, 0xf30fa7d0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcrypt-ctr, 0xf30fa7d8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcrypt-cfb, 0xf30fa7e0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcrypt-ofb, 0xf30fa7e8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -montmul, 0xf30fa6c0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xsha1, 0xf30fa6c8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xsha256, 0xf30fa6d0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > +xstore-rng, 0xfa7c0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcrypt-ecb, 0xf30fa7c8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcrypt-cbc, 0xf30fa7d0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcrypt-ctr, 0xf30fa7d8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcrypt-cfb, 0xf30fa7e0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcrypt-ofb, 0xf30fa7e8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +montmul, 0xf30fa6c0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xsha1, 0xf30fa6c8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xsha256, 0xf30fa6d0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > // Aliases without hyphens. > -xstorerng, 0xfa7c0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcryptecb, 0xf30fa7c8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcryptcbc, 0xf30fa7d0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcryptctr, 0xf30fa7d8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcryptcfb, 0xf30fa7e0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > -xcryptofb, 0xf30fa7e8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > +xstorerng, 0xfa7c0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcryptecb, 0xf30fa7c8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcryptcbc, 0xf30fa7d0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcryptctr, 0xf30fa7d8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcryptcfb, 0xf30fa7e0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > +xcryptofb, 0xf30fa7e8, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > // Alias for xstore-rng. > -xstore, 0xfa7c0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|IsString|RepPrefixOk, {} > +xstore, 0xfa7c0, None, CpuPadLock, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|RepPrefixOk, {} > > // Multy-precision Add Carry, rdseed instructions. > adcx, 0x660f38f6, None, CpuADX, Modrm|CheckRegSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } OK. Thanks. -- H.J.