From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com
 [IPv6:2607:f8b0:4864:20::429])
 by sourceware.org (Postfix) with ESMTPS id 07CD438515D9
 for <binutils@sourceware.org>; Wed, 26 Jan 2022 13:29:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07CD438515D9
Received: by mail-pf1-x429.google.com with SMTP id y27so18503089pfa.0
 for <binutils@sourceware.org>; Wed, 26 Jan 2022 05:29:39 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=bEnSauJYSvh6bJHPoCtlLJ1zlYr3e/j8+R9GLkO5VhE=;
 b=8REpJmJRIWVZld4CFZHzIKSyNUUbpUU3e7liGoI7s62H2dyfJxmZ8haTsPwTFPuHyi
 RpdHQ+d7FJePdCHyHB2Zbk5Zoaoc70VhQDn+S4q1/iNAODT+n3//QsUc9/4HnYFyW/Qt
 a75Ufhk2pspCgTGixdv+zUwk/YjftZE5Rhaty5YUN5yv15Fu64n7oI/KvLfAzHIbPiuR
 usMdVkxZnqi0GsPmTDsskvG5arylcqxUsWj4rQMZpdM9EuhvOKY0dOVJUSSA+iYh1YP8
 ujQaZ4KFwVtqZOBBDcZ6x6oA29WkPn+pA9WvS6ZQVgCXl+ByoKYdf7FTQ8K3YFKSAz+B
 xBNA==
X-Gm-Message-State: AOAM5301QjFid9KBankgcH9mySCjwR//7Vi+jAj3aaX78e0YtpFSPCxo
 J8ArZMOED5MtwKOkEgeXFKFvLuYLEMsoY/Z9IrPR5RSX
X-Google-Smtp-Source: ABdhPJz0Qj/joJ0cgcec+8AlU0oSW+Uhec1NGIr946chfaTmP6gQpMFI3bBiBxC7KNP391CChwyDsi8PNmKNtBu9jrc=
X-Received: by 2002:a63:b24e:: with SMTP id t14mr19129499pgo.381.1643203778876; 
 Wed, 26 Jan 2022 05:29:38 -0800 (PST)
MIME-Version: 1.0
References: <20220125171527.209521-1-hjl.tools@gmail.com>
In-Reply-To: <20220125171527.209521-1-hjl.tools@gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 26 Jan 2022 05:29:03 -0800
Message-ID: <CAMe9rOq81evuuGmBo-WyT3Knzmn_HkaT-W2hvx=zrJWw6LkeYw@mail.gmail.com>
Subject: Re: [PATCH] bfd: Make bfd.stamp depend on source bfd.texi
To: Binutils <binutils@sourceware.org>
Cc: Tobias Burnus <tobias@codesourcery.com>, Nick Clifton <nickc@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3027.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2022 13:29:41 -0000

On Tue, Jan 25, 2022 at 9:15 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Make bfd.stamp depend on source bfd.texi to avoid regenerating
> doc/bfd.info for each make run.
>
>         PR binutils/28807
>         * Makefile.in: Regenerate.
>         * doc/local.mk (%D%/bfd.stamp): Depend on $(srcdir)/%D%/bfd.texi.
> ---
>  bfd/Makefile.in  | 5 +++--
>  bfd/doc/local.mk | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/bfd/Makefile.in b/bfd/Makefile.in
> index 5a9b32cd25c..b8e5ea0153f 100644
> --- a/bfd/Makefile.in
> +++ b/bfd/Makefile.in
> @@ -2504,8 +2504,9 @@ doc/%.stamp: $(srcdir)/%.h $(srcdir)/doc/doc.str $(MKDOC) doc/$(am__dirstamp)
>  doc/%.stamp: $(srcdir)/%.c $(srcdir)/doc/doc.str $(MKDOC) doc/$(am__dirstamp)
>         $(AM_V_GEN)$(REGEN_TEXI)
>
> -# Avoid the %.stamp generating a builddir/bfd.texi that overrides the srcdir/.
> -doc/bfd.stamp: doc/$(am__dirstamp) ; $(AM_V_at)touch $@
> +# Avoid the %.stamp generating a builddir/bfd.texi that overrides the
> +# srcdir/ as well as regenerating doc/bfd.info for each make run.
> +doc/bfd.stamp: $(srcdir)/doc/bfd.texi ; $(AM_V_at)touch $@
>
>  # We use bfdt.texi, rather than bfd.texi, to avoid conflicting with
>  # bfd.texi on an 8.3 filesystem.
> diff --git a/bfd/doc/local.mk b/bfd/doc/local.mk
> index 9bf4815d8c6..931942f874c 100644
> --- a/bfd/doc/local.mk
> +++ b/bfd/doc/local.mk
> @@ -118,8 +118,9 @@ REGEN_TEXI = \
>  %D%/%.stamp: $(srcdir)/%.c $(srcdir)/%D%/doc.str $(MKDOC) %D%/$(am__dirstamp)
>         $(AM_V_GEN)$(REGEN_TEXI)
>
> -# Avoid the %.stamp generating a builddir/bfd.texi that overrides the srcdir/.
> -%D%/bfd.stamp: %D%/$(am__dirstamp) ; $(AM_V_at)touch $@
> +# Avoid the %.stamp generating a builddir/bfd.texi that overrides the
> +# srcdir/ as well as regenerating doc/bfd.info for each make run.
> +%D%/bfd.stamp: $(srcdir)/%D%/bfd.texi ; $(AM_V_at)touch $@
>
>  # We use bfdt.texi, rather than bfd.texi, to avoid conflicting with
>  # bfd.texi on an 8.3 filesystem.
> --
> 2.34.1
>

I am checking it in.

-- 
H.J.