From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 5B2ED384B81F for ; Thu, 27 Oct 2022 00:12:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B2ED384B81F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x229.google.com with SMTP id d3so18323575ljl.1 for ; Wed, 26 Oct 2022 17:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KewICyoTx33g4HzE9mrJgaHi/3brTMmc+qFFZrW/4TI=; b=LCMo0QJl+hMdjeqvVSTqzPPiBbNN0VhHesAXXsnktCMtcMrMnTiFqh4RaVzOhSXprm XfARSHg690Q8DKcecx/9jmcdlP2hCEHU32Xq5/aZhTwkei7JMSj9L4OZvEUXtCp0xjxJ 9VqJ+jsQoWpdyNorjWSI6KDt3CuZ0JzHiPIIC9CibkCFdU/NhduubARZp0D6iu3APKs5 qZEgUroZNv2Db5YIj1z3tE9mdbtTVdZB63Uz/ly9rMrz34+NETu1GtV/8rWrf/9LfmIG gnk+p5d5tT5JF0xA9MBBrYCkVCuvpMKaXDdIkEXu+YQdTq4Ty0/UxXuIzDJdx23375GY Yilw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KewICyoTx33g4HzE9mrJgaHi/3brTMmc+qFFZrW/4TI=; b=nPOUOSpcOL9UtkP5m0PoPvKF2pTPkw+V09o1yP4XrsBr4OWjC2eioVdHkKzG7Vu9Tb YM+t4yEuXxEr4vr6Y02JKtyqERLN3BDcikPMq/3wFO/6HWOT1OHYsj/LzOX13QaFzcQ5 gUrFvUuW1ziZXeRYBFTUP316Y/2/bXKgO+/MLRuOO3r2ctDdzb2wWteBvuaAhPZuG5dE PCnlwDzhLHopLwXTuPiOix4fSyYZ95gbNLGTTKjV0nFZo8OFtYlrMV3aiWLz5jChmbT0 6MN8dueZzh37w1l7U7pOIFOBBxyu1AB+DB4/BeYO/L2ejJvz81iX9DLIL3iIADT+HmFF HE2w== X-Gm-Message-State: ACrzQf2P9LY8Xq2CoNsWOr2mmUyDTleJhnTh0xQTUtBFsEYnUi5zIwoJ 3rtjLujRL15e7l38F4VjXOfmKx8W8YQVDXFok/gsvZlRSLM= X-Google-Smtp-Source: AMsMyM7oVle7wZt2gPKQjbI+N4v4jF0IwWNj0Yl11ttiJBPY54h9Y+8y2WpiZ/bIOpBMSzwcs6fFh7BjRISTjAe01GA= X-Received: by 2002:a2e:874e:0:b0:277:38b:212a with SMTP id q14-20020a2e874e000000b00277038b212amr9717795ljj.363.1666829528612; Wed, 26 Oct 2022 17:12:08 -0700 (PDT) MIME-Version: 1.0 References: <06ff83d4-4633-a07b-70e5-a8e049981dd4@suse.com> <3ed9f6ae-ab9f-efc3-8b11-b3fd0a4dcfaa@suse.com> In-Reply-To: <3ed9f6ae-ab9f-efc3-8b11-b3fd0a4dcfaa@suse.com> From: "H.J. Lu" Date: Wed, 26 Oct 2022 17:11:32 -0700 Message-ID: Subject: Re: [PATCH v5 8/8] x86: further re-work insn/suffix recognition to also cover MOVSX To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3016.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 26, 2022 at 2:07 AM Jan Beulich wrote: > > On 25.10.2022 19:10, H.J. Lu wrote: > > On Tue, Oct 25, 2022 at 12:29 AM Jan Beulich wrote: > >> > >> PR gas/29524 > >> > >> Having templates with a suffix explicitly present has always been > >> quirky. After prior adjustment all that's left to also eliminate the > > > > I prefer keeping the current MOVS behavior. Please submit a new patch > > set without MOVS changes. > > You're kidding? If you _still_ think this patch isn't worth it despite > its merits, and despite it now only reducing the set of templates and > adjusting/extending the testsuite, without any changes to tc-i386.c you Without this change, the Pass2 change can be dropped. > can simply give your okay to the first 7 patches. Why would I spam the > list with an identical re-submission of those first 7 patches? > > Independent of that I'd like to understand the reasons for your > preference, in particular when considering the benefits as well as the > reported bug which is being fixed (and which you marked as WONTFIX for > a subjective reason). So far your objection was that the change > complicates the code. Now it actually simplifies it slightly by > halving the number of involved templates. > > Jan -- H.J.