From: "H.J. Lu" <hjl.tools@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Tristan Gingold <gingold@adacore.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Nick Clifton <nickc@redhat.com>,
binutils Development <binutils@sourceware.org>
Subject: Re: Ping [Patch v2] bfd elfxx-ia64: share code between elf32 and elf64
Date: Mon, 11 Jul 2011 16:20:00 -0000 [thread overview]
Message-ID: <CAMe9rOq9k3QDT7zB7Yr0TyKOFFS8k-Y-X5gLiRgTaqqNY8GApQ@mail.gmail.com> (raw)
In-Reply-To: <m2vcvbs4g5.fsf@igel.home>
On Sat, Jul 9, 2011 at 11:18 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Tristan Gingold <gingold@adacore.com> writes:
>
>> This patch shouldn't have made any functional change, but ...
>
> There is one functional change:
>
> @@ -2648,7 +2135,7 @@ count_dyn_reloc (bfd *abfd, struct elfNN_ia64_dyn_sym_info *dyn_i,
> rent->count = 0;
> dyn_i->reloc_entries = rent;
> }
> - rent->reltext = reltext;
> + rent->reltext |= reltext;
> rent->count++;
>
> return TRUE;
>
>
I am checking this as an obvious fix.
--
H.J.
----
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index a1b9197..e469ef2 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2011-07-11 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/12978
+ * elfnn-ia64.c (count_dyn_reloc): Fix a typo.
+
2011-07-09 Alan Modra <amodra@gmail.com>
PR ld/12942
diff --git a/bfd/elfnn-ia64.c b/bfd/elfnn-ia64.c
index bc31fca..3e2ee0b 100644
--- a/bfd/elfnn-ia64.c
+++ b/bfd/elfnn-ia64.c
@@ -2129,7 +2129,7 @@ count_dyn_reloc (bfd *abfd, struct
elfNN_ia64_dyn_sym_info *dyn_i,
rent->count = 0;
dyn_i->reloc_entries = rent;
}
- rent->reltext |= reltext;
+ rent->reltext = reltext;
rent->count++;
return TRUE;
next prev parent reply other threads:[~2011-07-11 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 12:56 [Patch] " Tristan Gingold
2011-05-17 13:04 ` H.J. Lu
2011-05-17 13:10 ` Tristan Gingold
2011-05-17 13:15 ` H.J. Lu
2011-05-17 15:12 ` [Patch v2] " Tristan Gingold
2011-05-23 8:00 ` Ping " Tristan Gingold
2011-05-24 13:50 ` Nick Clifton
2011-05-24 14:17 ` Tristan Gingold
2011-05-25 8:07 ` Nick Clifton
2011-05-25 12:03 ` Tristan Gingold
2011-07-05 19:06 ` Aurelien Jarno
2011-07-06 7:00 ` Tristan Gingold
2011-07-09 18:18 ` Aurelien Jarno
2011-07-10 11:53 ` Andreas Schwab
2011-07-11 16:20 ` H.J. Lu [this message]
2011-07-25 13:35 ` Tristan Gingold
2011-05-17 13:08 ` [Patch] " Andreas Schwab
2011-05-17 13:11 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOq9k3QDT7zB7Yr0TyKOFFS8k-Y-X5gLiRgTaqqNY8GApQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=aurelien@aurel32.net \
--cc=binutils@sourceware.org \
--cc=gingold@adacore.com \
--cc=nickc@redhat.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).