From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1396 invoked by alias); 11 Jul 2011 13:55:24 -0000 Received: (qmail 1386 invoked by uid 22791); 11 Jul 2011 13:55:23 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_FN,TW_FX X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jul 2011 13:55:09 +0000 Received: by qwa26 with SMTP id 26so2485022qwa.0 for ; Mon, 11 Jul 2011 06:55:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.27.198 with SMTP id j6mr3631094qcc.10.1310392508703; Mon, 11 Jul 2011 06:55:08 -0700 (PDT) Received: by 10.229.71.157 with HTTP; Mon, 11 Jul 2011 06:55:08 -0700 (PDT) In-Reply-To: References: <1149AB82-D754-4792-98C1-C677ABE5E712@adacore.com> <9F58AE27-C095-4B50-B3D4-1DF60454A382@adacore.com> <6ACB9B6C-7640-473A-9047-7AFB4C789D49@adacore.com> <4DDBB7CD.40902@redhat.com> <9C0F5E39-7514-4996-AA9B-26478EEAAD79@adacore.com> <4DDCADE9.4020405@redhat.com> <049A78A6-0E98-4631-BB9B-27A6B9527D37@adacore.com> <20110705182906.GB19197@volta.aurel32.net> Date: Mon, 11 Jul 2011 16:20:00 -0000 Message-ID: Subject: Re: Ping [Patch v2] bfd elfxx-ia64: share code between elf32 and elf64 From: "H.J. Lu" To: Andreas Schwab Cc: Tristan Gingold , Aurelien Jarno , Nick Clifton , binutils Development Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00110.txt.bz2 On Sat, Jul 9, 2011 at 11:18 AM, Andreas Schwab wro= te: > Tristan Gingold writes: > >> This patch shouldn't have made any functional change, but ... > > There is one functional change: > > @@ -2648,7 +2135,7 @@ count_dyn_reloc (bfd *abfd, struct elfNN_ia64_dyn_s= ym_info *dyn_i, > =A0 =A0 =A0 rent->count =3D 0; > =A0 =A0 =A0 dyn_i->reloc_entries =3D rent; > =A0 =A0 } > - =A0rent->reltext =3D reltext; > + =A0rent->reltext |=3D reltext; > =A0 rent->count++; > > =A0 return TRUE; > > I am checking this as an obvious fix. --=20 H.J. ---- diff --git a/bfd/ChangeLog b/bfd/ChangeLog index a1b9197..e469ef2 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2011-07-11 H.J. Lu + + PR ld/12978 + * elfnn-ia64.c (count_dyn_reloc): Fix a typo. + 2011-07-09 Alan Modra PR ld/12942 diff --git a/bfd/elfnn-ia64.c b/bfd/elfnn-ia64.c index bc31fca..3e2ee0b 100644 --- a/bfd/elfnn-ia64.c +++ b/bfd/elfnn-ia64.c @@ -2129,7 +2129,7 @@ count_dyn_reloc (bfd *abfd, struct elfNN_ia64_dyn_sym_info *dyn_i, rent->count =3D 0; dyn_i->reloc_entries =3D rent; } - rent->reltext |=3D reltext; + rent->reltext =3D reltext; rent->count++; return TRUE;