From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>,
Kong Lingling <lingling.kong@intel.com>,
"Jiang, Haochen" <haochen.jiang@intel.com>,
Lili Cui <lili.cui@intel.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] x86: fold special-operand insn attributes into a single enum
Date: Fri, 11 Nov 2022 11:48:31 -0800 [thread overview]
Message-ID: <CAMe9rOq=AO9D_0RGhAs95zEN=A_MXxgPVFszrBxazAwrEVpWgw@mail.gmail.com> (raw)
In-Reply-To: <3d6d6d28-d4ed-5871-e20b-62aaa89ca6d4@suse.com>
On Fri, Nov 11, 2022 at 12:22 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 11.11.2022 09:00, Jan Beulich via Binutils wrote:
> > On 10.11.2022 18:38, H.J. Lu wrote:
> >> On Thu, Nov 10, 2022 at 5:45 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>>
> >>> Attributes which aren't used together in any single insn template can be
> >>> converted from individual booleans to a single enum, as was done for a few
> >>> other attributes before. This is more space efficient. Collect together
> >>> all attributes which express special operand constraints (and which fit
> >>> the criteria for folding).
> >>
> >> These assumptions may not be all true for future new instructions.
> >
> > It seems pretty unlikely to me that any of these assumptions would break.
> > If one does, converting back to an individual bit is an easy option. I
> > think this minor risk is far outweighed by the benefits of the change. We
> > really have still some ways to go to reach reasonable data representation
> > within the generated opcode table (and of course also in the source table,
> > but that's an orthogonal direction of work, where I also have further
> > changes pending).
>
> I should probably expand: For most of these I don't expect new uses to appear
> at all. Note also that I left alone e.g. ImmExt, for having a bigger risk of
> a new conflicting use appearing.
>
> If you have concerns for a specific attribute, please voice it that way. I'm
> certainly willing to re-consider for individual attributes (albeit as said
> in the earlier reply, the way back for any individual one is easy); I'm not
> going to accept a blanket "no".
>
> Jan
Lingling, Lili, Haochen, do you have any comments?
Thanks.
--
H.J.
next prev parent reply other threads:[~2022-11-11 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 13:45 Jan Beulich
2022-11-10 17:38 ` H.J. Lu
2022-11-11 8:00 ` Jan Beulich
2022-11-11 8:22 ` Jan Beulich
2022-11-11 19:48 ` H.J. Lu [this message]
2022-11-14 1:38 ` Jiang, Haochen
2022-11-14 15:58 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOq=AO9D_0RGhAs95zEN=A_MXxgPVFszrBxazAwrEVpWgw@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=haochen.jiang@intel.com \
--cc=jbeulich@suse.com \
--cc=lili.cui@intel.com \
--cc=lingling.kong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).