From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7141 invoked by alias); 11 Apr 2017 00:08:32 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 7118 invoked by uid 89); 11 Apr 2017 00:08:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:209.85.216.193, H*RU:209.85.216.193 X-HELO: mail-qt0-f193.google.com Received: from mail-qt0-f193.google.com (HELO mail-qt0-f193.google.com) (209.85.216.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Apr 2017 00:08:30 +0000 Received: by mail-qt0-f193.google.com with SMTP id o36so5408652qtb.2 for ; Mon, 10 Apr 2017 17:08:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AblHIJmSjBwZu5aWTD0LNb2az+DpnKpnrKGSVxqO6ik=; b=Vf9EZa2XBJA99P9DD2o+vDdRiW4XuyH5HS80b2lZZaf01KoPkTTMEMKEPjNjjiRvvJ DRa2+Etfr/ouKBQ1ZthiiPmIfwsF20HdP6MAsxepao5/nRUNjslcy4gjVeP+OXj74jb5 MV5ILe3R0ne3PzmBBlIIj8rk3MCMuonlVpc40I1PBd0C2hAEGZNwbnxd8ALVjnE2sIQT CPy7xj2DaNpM0q0SPu2X/h7vKdhMjCRr6CGck8tTJHrwoRqpTey+e/cTXTm729XrjQvI SIUAsJQMTg6CR9OIDYgocO5jSVm+7VsPLt2oSzvJtDPG8LSlK9HSnDdRtMbE3sKfkPn0 fK6A== X-Gm-Message-State: AN3rC/70PfRni5qq1VUaODWz1jJNjOJ0vCFajP7+tUE+MnAGQChBQdW0egU/9wjEJM4+tLeLLkDxHWQey2E/7g== X-Received: by 10.237.43.130 with SMTP id e2mr5630850qtd.15.1491869309951; Mon, 10 Apr 2017 17:08:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.48.197 with HTTP; Mon, 10 Apr 2017 17:08:29 -0700 (PDT) In-Reply-To: <20170410235110.GF24006@bubble.grove.modra.org> References: <20170410041529.GB16711@bubble.grove.modra.org> <20170410235110.GF24006@bubble.grove.modra.org> From: "H.J. Lu" Date: Tue, 11 Apr 2017 00:08:00 -0000 Message-ID: Subject: Re: binutils testsuite pr21231b To: Alan Modra Cc: Binutils Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00115.txt.bz2 On Mon, Apr 10, 2017 at 4:51 PM, Alan Modra wrote: > On Mon, Apr 10, 2017 at 08:57:42AM -0700, H.J. Lu wrote: >> On Sun, Apr 9, 2017 at 9:15 PM, Alan Modra wrote: >> > You can't emit errors/warnings in _bfd_elf_parse_gnu_properties except >> > for those that will occur for all targets. Please fix. >> > >> >> Here is a patch to make generic ELF target vectors the last resort. > > Not a good idea. It sets a bad precedent that the target vector order > can be changed to suit poorly written code. Next thing you'll be > wanting x86_64_elf64_fbsd_vec to sort before x86_64_elf64_vec, or > someone else will want something similar for other targets, and we'll > have breakage if the vector order is changed. > BFD shouldn't try generic target vector before real one and config.bfd has # If we support any ELF target, then automatically add support for the # generic ELF targets. This permits an objdump with some ELF support # to be used on an arbitrary ELF file for anything other than # relocation information. case "${targ_defvec} ${targ_selvecs}" in *elf64* | *mips_elf32_n*) targ_selvecs="${targ_selvecs} elf64_le_vec elf64_be_vec elf32_le_vec elf32_be_vec" ;; *elf32*) targ_selvecs="${targ_selvecs} elf32_le_vec elf32_be_vec" ;; esac If generic ELF target vectors are moved first, we may run into similar problems. As for x86_64_elf64_fbsd_vec vs x86_64_elf64_vec, either there is already an issue, which we have been living with, or there is no issue at all. -- H.J.