From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7184 invoked by alias); 11 Feb 2020 11:27:59 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 7176 invoked by uid 89); 11 Feb 2020 11:27:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:6fbca20, H*f:sk:6fbca20, HX-Spam-Relays-External:209.85.167.196, H*RU:209.85.167.196 X-HELO: mail-oi1-f196.google.com Received: from mail-oi1-f196.google.com (HELO mail-oi1-f196.google.com) (209.85.167.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 11:27:57 +0000 Received: by mail-oi1-f196.google.com with SMTP id z2so12441607oih.6 for ; Tue, 11 Feb 2020 03:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HT5H2N8a2EZN3SBNTVTRUoHfl4BgeJlXW34GnFpEHzA=; b=izE5smbPZxcF9DIkJRrYavHQutWfuVIp7nHQ5jBwXyqSwKleCh7WkPIbaPBwJVww1y YcGD9VoFTKiyNBmQvdtupQOHazBov7kS0hZKWuUOM0DZ2wrabqaBU3VDl3VSs9gypLri ii6MiF7oB2HCFTegAAAExkGBZ6YpTvA6ohO/iLtECZjw6wdeN9gxItsjk8oELLgTZK0B WZnGU7T3QgsgbHLo9s3W+yZWJHUuyh1fp0wjHiZGUZrSJ31NHIHap++MRqsyyNJ6HxgN 836wZIwPL6Sz+5UbGE7UHg8hIJHSMdEoKf0SZsVCmkdh36fRcwAHO5khEY1wqmPdJ0QX vRIw== MIME-Version: 1.0 References: <1e1b8eba-93ff-39ed-460a-a922d12af27e@suse.com> <6fbca201-5ae8-cf70-0614-f7f2efa6628f@suse.com> In-Reply-To: <6fbca201-5ae8-cf70-0614-f7f2efa6628f@suse.com> From: "H.J. Lu" Date: Tue, 11 Feb 2020 11:27:00 -0000 Message-ID: Subject: Re: [PATCH v5 1/5] x86: also disallow non-byte/-word registers with byte/word suffix To: Jan Beulich Cc: "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00174.txt.bz2 On Tue, Feb 11, 2020 at 2:24 AM Jan Beulich wrote: > > Along the lines of be4c5e58bd ("x86: Always disallow double word suffix > with word general register") also adjust check_{byte,word}_reg(), to make > overall behavior consistent again in this regard. > > gas/ > 2020-02-XX Jan Beulich > > PR gas/25438 > * config/tc-i386.c (REGISTER_WARNINGS): Delete. > (check_byte_reg): Skip only source operand of CRC32. Drop Non- > 64-bit-only warning. > (check_word_reg): Consistently error on mismatching register > size and suffix. > * testsuite/gas/i386/general.s: Replace dword GPR with word one > for movw. Replace suffix / GPR for orb. > * testsuite/gas/i386/inval.s: Add tests for movw with dword and > byte GPRs as well as ones for inb/outb with a word accumulator. > * testsuite/gas/i386/general.l, testsuite/gas/i386/intelbad.l, > testsuite/gas/i386/inval.l: Adjust expectations. > OK. Thanks. -- H.J.