From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-99983-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 59709 invoked by alias); 11 Jan 2018 17:27:25 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 59689 invoked by uid 89); 11 Jan 2018 17:27:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Ha, Hx-languages-length:1046, Great
X-HELO: mail-oi0-f43.google.com
Received: from mail-oi0-f43.google.com (HELO mail-oi0-f43.google.com) (209.85.218.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jan 2018 17:27:23 +0000
Received: by mail-oi0-f43.google.com with SMTP id g128so2120040oib.11        for <binutils@sourceware.org>; Thu, 11 Jan 2018 09:27:23 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=LjIatAVrcABn4SC37fuGcaHeR8LGjPfS7yTLr+CXEbY=;        b=riIcXtZpfh2Ohmk8r2eykVxd73hqSmedqPENL2CWb8UhN12kox8MhOQh/UvrF7i9HQ         kXS1afx3Es2pMllH7QfHIwnq7+sO2+fPYlPVkvYqjItK+Fp7Sqp8C+FzL2pHWJHfb3GV         brz1Goq1U3O0IzQKgZlFV+OuJae2kzeKZySzFtlV8aZdCIYWPwMVnOWXTOffop67cGrL         bxUw9F4+BH1nU+hkry5Hl5yZNjl1TLBT1MCZ4L0zPspPwJ4jn49J7/Re88aVwaaiotKk         X5e/zneisD9iW/UPcuoFHwDbA1LRBF9uEiK6WvSbZs21qOOIFO27J4/M7/3UOwwsq4zS         cAkQ==
X-Gm-Message-State: AKwxytejPlLQts+up2DI7IfVKUBJaqMqFEQdzjpZNBOzuXQoZmdgz8Wx	GqqX2aGe0NfG02u4Q7j08fRchdTekb16IKTHBL0=
X-Google-Smtp-Source: ACJfBotXXpXQYwt3b9WMMNdWrM4dfeXkSsolV0e11ctVCirkXEJqMrxn+gBJp0B/cSkap36xpnPTfyztP2WkfjXdxdI=
X-Received: by 10.202.253.7 with SMTP id b7mr4405728oii.250.1515691641928; Thu, 11 Jan 2018 09:27:21 -0800 (PST)
MIME-Version: 1.0
Received: by 10.74.151.42 with HTTP; Thu, 11 Jan 2018 09:27:21 -0800 (PST)
In-Reply-To: <f104fb25-133d-0be7-7570-240dcb53c609@redhat.com>
References: <a742ee2a-9c3d-5b1f-526c-5b09309bb758@redhat.com> <CAMe9rOpyyq+F=t1yygFRbsBUorN-V6EdJtknr=vLkJVqHByUrQ@mail.gmail.com> <f104fb25-133d-0be7-7570-240dcb53c609@redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 11 Jan 2018 17:27:00 -0000
Message-ID: <CAMe9rOqCdWsk+16QgjxB3Tcovbp=6wT9ubEMzDDsp10vQ2hrDw@mail.gmail.com>
Subject: Re: 2.30 Branch Planned for Friday...
To: Nick Clifton <nickc@redhat.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2018-01/txt/msg00176.txt.bz2

On Thu, Jan 11, 2018 at 9:07 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi H.J.
>
>> I'd like to fix:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=22677
>>
>> with
>>
>> https://sourceware.org/ml/binutils/2018-01/msg00173.html
>
> Ha!  Great minds think alike. :-)
>
> I have just posted a very similar patch to the PR, although I
> think that we do not need any special case code for the PRE_INIT_ARRAY
> section as that is handled by a KEEP directive in the linker script.
> Hmm - unless there can be PREINIT_ARRAY sections whose name is not
> .preinit_array.  Which I suppose is possible...

Exactly.   Linker script for ld -r has:

 .preinit_array   0 :
  {
    KEEP (*(.preinit_array))
  }

It doesn't cover

 .section .preinit_array.01000,"aw",%preinit_array
 .p2align 2
 .word 0

in my testcase in my patch.

> Would you mind extending your patch to include this scenario ?
> I think that with that change in place I would be happy to approve it.
>

My patch does cover that with a testcase :-).


-- 
H.J.