public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Re: [Bug binutils/14355] New: crash in OP_VEX
       [not found] <bug-14355-70@http.sourceware.org/bugzilla/>
@ 2012-07-17 15:53 ` nick clifton
  2012-07-17 16:38   ` H.J. Lu
  0 siblings, 1 reply; 2+ messages in thread
From: nick clifton @ 2012-07-17 15:53 UTC (permalink / raw)
  To: H.J. Lu; +Cc: binutils, wbrana

Hi H.J.

Would you mind taking a look at this x86 bug report:

> http://sourceware.org/bugzilla/show_bug.cgi?id=14355

A simplistic fix appears to be this:

Index: opcodes/i386-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/i386-dis.c,v
retrieving revision 1.269
diff -u -3 -p -r1.269 i386-dis.c
--- opcodes/i386-dis.c  16 Jul 2012 12:58:29 -0000      1.269
+++ opcodes/i386-dis.c  17 Jul 2012 15:52:06 -0000
@@ -14661,6 +14661,7 @@ OP_VEX (int bytemode, int sizeflag ATTRI
         case vex256_mode:
           names = names_ymm;
           break;
+       case vex128_mode:
         case vex_vsib_q_w_dq_mode:
           names = vex.w ? names_ymm : names_xmm;
           break;

But I am not sure if that is the correct thing to do.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Bug binutils/14355] New: crash in OP_VEX
  2012-07-17 15:53 ` [Bug binutils/14355] New: crash in OP_VEX nick clifton
@ 2012-07-17 16:38   ` H.J. Lu
  0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2012-07-17 16:38 UTC (permalink / raw)
  To: nick clifton; +Cc: binutils, wbrana

On Tue, Jul 17, 2012 at 7:48 AM, nick clifton <nickc@redhat.com> wrote:
> Hi H.J.
>
> Would you mind taking a look at this x86 bug report:
>
>> http://sourceware.org/bugzilla/show_bug.cgi?id=14355
>
>
> A simplistic fix appears to be this:
>
> Index: opcodes/i386-dis.c
> ===================================================================
> RCS file: /cvs/src/src/opcodes/i386-dis.c,v
> retrieving revision 1.269
> diff -u -3 -p -r1.269 i386-dis.c
> --- opcodes/i386-dis.c  16 Jul 2012 12:58:29 -0000      1.269
> +++ opcodes/i386-dis.c  17 Jul 2012 15:52:06 -0000
> @@ -14661,6 +14661,7 @@ OP_VEX (int bytemode, int sizeflag ATTRI
>         case vex256_mode:
>           names = names_ymm;
>           break;
> +       case vex128_mode:
>         case vex_vsib_q_w_dq_mode:
>           names = vex.w ? names_ymm : names_xmm;
>           break;
>
> But I am not sure if that is the correct thing to do.
>

This is the wrong fix. The bug is in XOP implementation.
Someone from AMD should take a look.

-- 
H.J.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-17 16:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-14355-70@http.sourceware.org/bugzilla/>
2012-07-17 15:53 ` [Bug binutils/14355] New: crash in OP_VEX nick clifton
2012-07-17 16:38   ` H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).