From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by sourceware.org (Postfix) with ESMTPS id 4874E3858C56 for ; Thu, 13 Oct 2022 17:00:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4874E3858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf32.google.com with SMTP id i12so1672776qvs.2 for ; Thu, 13 Oct 2022 10:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GB4rnQQFC+UNETDen/bt2Td+TkueAqNz2khGZehERKk=; b=iVce+ycob01/Fd9sVTRXOvH4eMnnP+km9lFZ8ksMwBpFa6e0WDqDOJ2yT6JjqavrL2 EeKH2JAQaAuQeQMrYhbMsctEj/fvf2V4/X3g6kvEmXmX5nFjACGL2ShI7ig85uGZGMq1 3cEH19iQ2mFYvEMUJcW59CKCqjs1Z7popH6xRwKKoDF6ijaZgsMQEN/GTTIx7eiB7Czb 1It3tGIlKWGuiyhttuuM2gCTPcvE7ETLedjptyUxz8CzyDHvtof7kMh8t25JslEaES5W Wy5Wjzwd8yQiUYzzXgYP4APa0TlhN7WOolM2ZfuQ/y4qe/4BpZI1Eroro/m5w2Nvrdej Bv5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GB4rnQQFC+UNETDen/bt2Td+TkueAqNz2khGZehERKk=; b=bPSnVF/dhgUeMH6XJLdU6f8l1RN7AT1HW3zA2GrMhiGWIMzj7Q4XnDuWICF6opajoB O/ePlY+NI/eT76NL1ea5uTREjUipcUuIc7PJGiNfSqEbj9Uv8m4EvlBo/f3QXLhiqFK3 6ZE3ob1P/fsv+jKTwdq49sOdcRuyN1xu29V5CnKT2Lx+d9fhsja+EPLdQDk2c5z16/8B 1PF6EvtsaXcpmCfjCqxVAPjIzzVjtYLsOsmHS2pCOqIbBpvf2+rSzWYm4+zup6Q58E1y K7ZcZpXyeOM4s5YfCnoXUS6/Gbefq3C5hziWl8ziuLE0+HDwR7YOCc6KPLfD5c4dUoik UuAQ== X-Gm-Message-State: ACrzQf3AQFO4Fr7tQGcH+fqSU0z10co3AkGeBhp76zDU4qEsWG+aq7x/ iWc6oEg2uRj0/JHbyeLbekuEhdBRukVm4aa8oV2P5Ivc X-Google-Smtp-Source: AMsMyM5rYxCWB2UDicW0DInE2QnG+cxkRMHXPlXYdTqUL1Mv3orxcodBvxGXP3NDTVR30Wfx3XhOFRLDEzwfuq8B32Q= X-Received: by 2002:a05:6214:c42:b0:4b4:2d1:c752 with SMTP id r2-20020a0562140c4200b004b402d1c752mr536714qvj.28.1665680438399; Thu, 13 Oct 2022 10:00:38 -0700 (PDT) MIME-Version: 1.0 References: <20e2773a-2e47-869b-1900-709f8ad4cd6b@suse.com> <2981100a-17bf-623c-27fc-0da08279c3ff@suse.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 13 Oct 2022 10:00:02 -0700 Message-ID: Subject: Re: [PATCH v3 4/7] x86-64: further re-work insn/suffix recognition to also cover MOVSL To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 12, 2022 at 11:08 PM Jan Beulich wrote: > > On 12.10.2022 19:10, H.J. Lu wrote: > > On Wed, Oct 12, 2022 at 12:08 AM Jan Beulich wrote: > >> > >> On 11.10.2022 19:44, H.J. Lu wrote: > >>> On Wed, Oct 5, 2022 at 12:24 AM Jan Beulich wrote: > >>>> > >>>> PR gas/29524 > >>>> In order to make MOVSL{,Q} behave similarly to MOVSB{W,L,Q} and > >>>> MOVSW{L,Q} we need to defer parse_insn()'s emitting of errors unrelated > >>>> to prefix parsing. Utilize i.error just like match_template() does. > >>> > >>> Since movs{b,w,l,q} are string instructions, integer sign extensions > >>> require a suffix to specify the destination size. This is different from other > >>> integer instructions. Since only the new assembler allows the implicit suffix, > >>> it won't be easy to use. We should improve error messages, but allowing > >>> new syntax doesn't help much. > >> > >> It is an earlier change making most of this consistent with MOVZ*; it is > > > > MOVZ is different. There are no MOVZ string instructions. MOVS has > > different meanings in ISA. MOVS difference from MOVZ in assembly > > syntax should be expected. > > You've said so before, yes, but I continue to disagree. And as we can see > from the series things can be made work consistently (and imo nothing else > should have been done right from the beginning). > There are inconsistencies in ISA. AT&T syntax makes things more complex. People should either deal with it or leave it to compilers. I don't think we should make assembler more complex. -- H.J.