From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by sourceware.org (Postfix) with ESMTPS id 398C23858D32 for ; Mon, 17 Oct 2022 23:45:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 398C23858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x830.google.com with SMTP id s3so8763449qtn.12 for ; Mon, 17 Oct 2022 16:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bgvCoiC121Qg1ZiHfycDDFySNKNvsi8BUIeDGJlC5BQ=; b=acIuzeC4degAdfstTQ5sJhx9YMh/own9CN97drydmgZTntSP8tfqse/dFK4tbVtCRz 0ae/nP+HNbI7FWLs91oXAaVj2QhkAapXDLB6V/xzI4N3VmFHNBHXH2GDiY7LmWYFIf2T 7OxtSdynH9PLlVO7h6TraFA/sOnCs42wuNxVXW4DhuvANVMk4DajdNO48tL3uRcSRqgg YT1pehDUN40fc8KE9hmupl2XjtL88vZSmhf1Aku+i90lq0uEVcrGGY106kVcBrByENsI 0hVv9BTnWbzH6Ddg/qjc5xZosmOblTbPKfP6QHjEN+USilFMMI20iMQTLi8sY4kZ+Bby fVew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bgvCoiC121Qg1ZiHfycDDFySNKNvsi8BUIeDGJlC5BQ=; b=S8605Zerz1jpKVmQZSLTxu/y7EGJ0X8yiaW0RFxiANVDFuFYC0+znDLKlJ7JQNaZ0H i4d3fwNHOjFSf8Jr/8Zpe9XIMy2i27gs0JoVhWXva1OZpG/UWa/Md55JWYV6s8uYPEM/ kbDHF6vDP51B9zMhBGpD7ZYw+5pLvGiG7SIJHo4G5UrNlGvfV6d5YBkuVo14rm7VAX1T rQHuSWpu7bOjdVJxpoXBIJ5zIJs9WtvGTC3etWp4dUlWcoMBGruNB2p+s52su5Pv9WnG SCNg1Fn6y9PVjCeQV/bqfvOS5Ej0TDyDMkQx9cb1IdCUuTGfth6SLlNgT4qepIahiC92 XF0A== X-Gm-Message-State: ACrzQf3Rjc5zLEeaI6mT2/7hpy1airhfkg4iIlQhGQrMWQv5KJ2By1zY 3OmM1A1mYnQIMnU5jrESUWSgpYbWVzB5CRBX2ptK/qbm78w= X-Google-Smtp-Source: AMsMyM6OJegoccN85kzDmFysPHR7aYN1pyI2OVxvrkPJ6E2OjzsT3zw6AmIWuJl9mxYlqd31A6WjEmZAkDyNGed3dC0= X-Received: by 2002:a05:622a:100f:b0:39c:f1b9:6104 with SMTP id d15-20020a05622a100f00b0039cf1b96104mr103319qte.500.1666050321665; Mon, 17 Oct 2022 16:45:21 -0700 (PDT) MIME-Version: 1.0 References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-5-haochen.jiang@intel.com> <1d847a52-b1ff-b816-1507-7077724901bb@suse.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 17 Oct 2022 16:44:45 -0700 Message-ID: Subject: Re: [PATCH 04/10] Support Intel CMPccXADD To: Jan Beulich Cc: Haochen Jiang , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Oct 15, 2022 at 11:25 PM Jan Beulich wrote: > > On 14.10.2022 20:27, H.J. Lu wrote: > > On Fri, Oct 14, 2022 at 6:46 AM Jan Beulich wrote: > >> On 14.10.2022 11:12, Haochen Jiang wrote: > >>> --- a/opcodes/i386-opc.tbl > >>> +++ b/opcodes/i386-opc.tbl > >>> @@ -3296,3 +3296,24 @@ vpdpbsud, 0xf350, None, CpuAVX_VNNI_INT8, Modrm|Vex|Space0F38|VexVVVV|VexW0|Chec > >>> vpdpbsuds, 0xf351, None, CpuAVX_VNNI_INT8, Modrm|Vex|Space0F38|VexVVVV|VexW0|CheckRegSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { RegXMM|RegYMM|Unspecified|BaseIndex, RegXMM|RegYMM, RegXMM|RegYMM } > >>> > >>> // AVX_VNNI_INT8 instructions end. > >>> + > >>> +// CMPCCXADD instructions. > >>> + > >>> +cmpbexadd, 0x66e6, None, CpuCMPCCXADD|Cpu64, Modrm|Vex128|Space0F38|VexVVVV=1|SwapSources|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Reg32|Reg64, Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } > >> > >> Along the lines of the earlier comment - you want to use the > >> template here, eliminating the need for 16 almost identical lines _and_ > >> supplying all condition code representation in one go. > >> > >> Apart from that you forgot CheckRegSize here afaict. And please again > >> VexVVVV alone, without =1. Also for non-vector insns perhaps better plain > >> Vex instead of Vex128. Further these insns should allow for l and q > >> suffixes in AT&T mode. > > > > l and q suffixes here are totally unnecessary. For new instructions, > > suffixes should be required only if needed. > > I disagree, and I'd like to ask that decisions like this not be made behind > closed doors at Intel. As said many times - there needs to be consistency, > which is a prereq for predictability. A programmer shall not be required to > read gas sources to know for which insns suffixes are permitted and for We can improve documentation. A programmer should use SDM first. Suffixes should be used only when SDM doesn't address AT&T syntax needs. > which they aren't. Plus do you realize that "new insns" also covers RAO-INT, > where suffixes are permitted (as expected)? There is a discrepancy. > Jan -- H.J.