From: "H.J. Lu" <hjl.tools@gmail.com>
To: Roland McGrath <mcgrathr@google.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] parameterize elf32-i386 PLT generation
Date: Thu, 28 Jul 2011 11:42:00 -0000 [thread overview]
Message-ID: <CAMe9rOqE0oZGYD9fidnhZRdgTBM-A6qN-JUuXSiMWvvJop_W-A@mail.gmail.com> (raw)
In-Reply-To: <x57jaabzgxoa.fsf@frobland.mtv.corp.google.com>
On Wed, Jul 27, 2011 at 3:34 PM, Roland McGrath <mcgrathr@google.com> wrote:
> This patch must follow the "clean up elf32-i386-vxworks hooking mechanism"
> change I just posted, not yet committed.
>
> This parameterizes the elf32-i386 PLT generation code to be table-driven.
> This is preparatory to a reworked addition of the elf32-i386-nacl backend,
> which I first posted yesterday. That target uses different PLT code
> sequences and a different PLT entry size.
>
> Ok for trunk?
>
>
> Thanks,
> Roland
>
>
> bfd/
> * elf32-i386.c (struct elf_i386_plt_layout): New type.
> (GET_PLT_ENTRY_SIZE): New macro.
> (elf_i386_plt): New variable.
> (struct elf_i386_backend_data): New member `plt'.
> (elf_i386_arch_bed): Add initializer for it.
> (elf_i386_vxworks_arch_bed): Likewise.
> (elf_i386_allocate_dynrelocs): Use GET_PLT_ENTRY_SIZE.
> (elf_i386_plt_sym_val): Likewise.
> (elf_i386_relocate_section): Likewise.
> (elf_i386_finish_dynamic_symbol): Likewise.
> Also use other elf_i386_plt_layout members for PLT details.
> (elf_i386_finish_dynamic_sections): Likewise.
>
It is OK. Thanks.
--
H.J.
prev parent reply other threads:[~2011-07-27 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 9:16 Roland McGrath
2011-07-28 11:42 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqE0oZGYD9fidnhZRdgTBM-A6qN-JUuXSiMWvvJop_W-A@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=mcgrathr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).