public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] binutils: Run PR binutils/26160 test
Date: Fri, 4 Nov 2022 16:47:19 -0700	[thread overview]
Message-ID: <CAMe9rOqF8NwkBqWXXkk8rJix2Xr3=D9AMDAtWqy=tMemuo8nfg@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOpg=oWq_LdoDBQA0qbq3QF8H9se=pM_mxT+su08X9rwHQ@mail.gmail.com>

On Mon, Oct 31, 2022 at 6:02 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Mon, Oct 31, 2022 at 5:25 PM Alan Modra <amodra@gmail.com> wrote:
> >
> > On Mon, Oct 31, 2022 at 05:08:04PM -0700, H.J. Lu wrote:
> > > On Mon, Oct 31, 2022 at 4:04 PM Alan Modra <amodra@gmail.com> wrote:
> > > >
> > > > On Mon, Oct 31, 2022 at 09:24:07AM -0700, H.J. Lu wrote:
> > > > > Here is the patch to run the test.  But it failed with
> > > > >
> > > > > readelf: Warning: Cannot fetch indexed address: the .debug_addr
> > > > > section is missing
> > > > >
> > > > > Is this warning valid?
> > > >
> > > > Well, yes, because according to https://gcc.gnu.org/wiki/DebugFission
> > > > .debug_addr is found in the "linked binary".  I think the testcase is
> > > > incomplete without that object file.
> > >
> > > readelf output has been changed.   Here is the patch
> > > to run PR binutils/26160 test.
> >
> > Can we please have the .o file too rather than accepting a warning?
> > That would better test readelf's handling of .dwp files.
>
> The readelf input was generated by dwp which was the part of gold.
> There is no .o file.
>
> > Also, I think it would be nicer if the .dwp file was not compressed,
> > so that the test would run without bzip2 being installed.  It isn't
> > very large.
> >
>
> Since there are other binaries compressed with bzip2, the .dwp
> file doesn't resolve this issue.
>
> --
> H.J.

I am checking it in.


-- 
H.J.

      reply	other threads:[~2022-11-04 23:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-30  9:52 Add a testcase for PR binutils/26160 Alan Modra
2022-10-31 16:24 ` H.J. Lu
2022-10-31 23:04   ` Alan Modra
2022-11-01  0:08     ` [PATCH] binutils: Run PR binutils/26160 test H.J. Lu
2022-11-01  0:25       ` Alan Modra
2022-11-01  1:02         ` H.J. Lu
2022-11-04 23:47           ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOqF8NwkBqWXXkk8rJix2Xr3=D9AMDAtWqy=tMemuo8nfg@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).