From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 1D21A3858C83 for ; Tue, 15 Feb 2022 23:12:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D21A3858C83 Received: by mail-pl1-x62f.google.com with SMTP id x11so495181pll.10 for ; Tue, 15 Feb 2022 15:12:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=AKpTH2dLMOfleo9Y9FpqlqcMFjvTWddMqz0MxkoBaSc=; b=A2/ONQcP2814w8BNqG9y3Pjk+GHpWPHTA1CdTDs10RshEJ9aaHsSVOt7rTR7Q9dWhd A5Wf7lArDahVJxizJzfvuEwXibFUXebeeChKvbVUiKKkDiDHEmXAQ+v4TlH/aEQ3iTlO 58jRukf6yfMGTxjhN4BKW2ARaQ4qkOx2ORSyg8nTuV6aTwepeTF0V1eUSw2fgmAP0Bva JTcqU7sbqvAqNIN9m4Zjl2xGYqsU+BORsUI1OH/F4tCmajAJ4nD4znzvocNRPrhHM2h1 8KxANsh9qmbDCoq+mizdkt0aO5EXY39cGIWSWXjOlSTJhq49SqO7CAjJhOoiR6CGABOO Kk0A== X-Gm-Message-State: AOAM530yuso4Qq+Kdn8pVB5lWYs1ETyc2+PHvFh8hwYpo/ljiSBhGrqH ikrcV5lCm1eFHWXkjgHt9Ry+gWqqmDJG4wkb8aDW+wAW X-Google-Smtp-Source: ABdhPJzQQ1G2R7fSHFYRWtagLPkl8lxR37sbs61h35neUl64sn21mOz6rzPlk09SnIy37s9qLV/+Y1Ikbdc7ARbXXus= X-Received: by 2002:a17:90a:c68c:b0:1b9:c16a:35d3 with SMTP id n12-20020a17090ac68c00b001b9c16a35d3mr6947841pjt.120.1644966766997; Tue, 15 Feb 2022 15:12:46 -0800 (PST) MIME-Version: 1.0 References: <20220215230713.4096139-1-hjl.tools@gmail.com> In-Reply-To: <20220215230713.4096139-1-hjl.tools@gmail.com> From: "H.J. Lu" Date: Tue, 15 Feb 2022 15:12:11 -0800 Message-ID: Subject: Re: [PATCH] i386: Update I386_NEED_DYNAMIC_RELOC_TYPE_P for DT_TEXTREL To: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3027.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2022 23:12:49 -0000 On Tue, Feb 15, 2022 at 3:07 PM H.J. Lu wrote: > > Update I386_NEED_DYNAMIC_RELOC_TYPE_P to allow R_386_TLS_IE for relocation > in read-only section. > > bfd/ > > PR ld/28894 > * elfxx-x86.h (I386_NEED_DYNAMIC_RELOC_TYPE_P): Allow > R_386_TLS_IE. > > ld/ > PR ld/28894 > * testsuite/ld-i386/i386.exp: Run pr28894. > * testsuite/ld-i386/pr28894.d: New file. > * testsuite/ld-i386/pr28894.s: Likewise. > --- > bfd/elfxx-x86.h | 1 + > ld/testsuite/ld-i386/i386.exp | 1 + > ld/testsuite/ld-i386/pr28894.d | 3 +++ > ld/testsuite/ld-i386/pr28894.s | 7 +++++++ > 4 files changed, 12 insertions(+) > create mode 100644 ld/testsuite/ld-i386/pr28894.d > create mode 100644 ld/testsuite/ld-i386/pr28894.s > > diff --git a/bfd/elfxx-x86.h b/bfd/elfxx-x86.h > index 3219f363a9a..77fb1ad72bc 100644 > --- a/bfd/elfxx-x86.h > +++ b/bfd/elfxx-x86.h > @@ -80,6 +80,7 @@ > #define I386_NEED_DYNAMIC_RELOC_TYPE_P(TYPE) \ > (I386_SIZE_TYPE_P (TYPE) \ > || I386_RELATIVE_RELOC_TYPE_P (TYPE) \ > + || (TYPE) == R_386_TLS_IE \ > || (TYPE) == R_386_TLS_LE \ > || (TYPE) == R_386_TLS_LE_32) > #define X86_NEED_DYNAMIC_RELOC_TYPE_P(IS_X86_64, TYPE) \ > diff --git a/ld/testsuite/ld-i386/i386.exp b/ld/testsuite/ld-i386/i386.exp > index d997c757325..fadbd160420 100644 > --- a/ld/testsuite/ld-i386/i386.exp > +++ b/ld/testsuite/ld-i386/i386.exp > @@ -510,6 +510,7 @@ run_dump_test "pr27491-4" > run_dump_test "dt-relr-1a" > run_dump_test "dt-relr-1b" > run_dump_test "pr28870" > +run_dump_test "pr28894" > > if { !([istarget "i?86-*-linux*"] > || [istarget "i?86-*-gnu*"] > diff --git a/ld/testsuite/ld-i386/pr28894.d b/ld/testsuite/ld-i386/pr28894.d > new file mode 100644 > index 00000000000..a8d1111eb1f > --- /dev/null > +++ b/ld/testsuite/ld-i386/pr28894.d > @@ -0,0 +1,3 @@ > +#as: --32 > +#ld: -shared -melf_i386 --warn-shared-textrel --fatal-warnings > +#error: .*warning: creating DT_TEXTREL in a shared object > diff --git a/ld/testsuite/ld-i386/pr28894.s b/ld/testsuite/ld-i386/pr28894.s > new file mode 100644 > index 00000000000..1d3e3f37f3e > --- /dev/null > +++ b/ld/testsuite/ld-i386/pr28894.s > @@ -0,0 +1,7 @@ > + .text > + addl foo@INDNTPOFF, %eax > + .section .tbss,"awT",@nobits > + .globl foo > + .hidden foo > +foo: > + .byte 0 > -- > 2.35.1 > I am backporting this to 2.38 branch. -- H.J.