From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id D9C0E3856DF0 for ; Thu, 28 Jul 2022 15:25:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9C0E3856DF0 Received: by mail-pl1-x62a.google.com with SMTP id v18so2073026plo.8 for ; Thu, 28 Jul 2022 08:25:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o+7YqSjKFiFlutwc+t1hc8J48q0ZQzkuXW9Ijhn7luc=; b=AxPZPAvsnGmGpcRgOO3OxLZFRi5U9fFrG4Ws2Gn/9FZOChD1XGK9AK8b+B2moZP6/D zDZ06p4SvR2oe0jJy+AW1T8G5NuLJtQQLei671Wd2/acKgcWFQ4WKITmW/56RkL8JMJS fzIg9JzrYtxdLLVwvUsEk/WXO3/yzOd8nFNuN7JGpaqpVMt2hGJQ3DklS0AodK/pxmmH xrZJ/Lx8c5aR7n5pg+8s0eheg83EzatoPL5/nk88lLrKPSE4gZ9PjfppVuB9FUCb0cus ZLUVvrTUHKetpJxO7pHWOtrW7v2C+omAzR4XveAGq3MlaWX3rtuKY1UlxB6E+8daDGzJ UyAw== X-Gm-Message-State: AJIora/Xr5zOrtUZxXfPO6KV3vMHJn6gxr1ezkRP2x3O/SFxWzteghmQ bOxIUZscrd/1QpczM03+TWK1AlGS6BP3WMGK95eQezac X-Google-Smtp-Source: AGRyM1vCHMXnfE/0U8KnUjUy3UttIlSJ6gkckqTgM3yds2TDxvV7GRfabVg1w3AtpPTJ9TIL+233/FGiMTKu/Ki1Lfw= X-Received: by 2002:a17:902:a502:b0:15e:c251:b769 with SMTP id s2-20020a170902a50200b0015ec251b769mr27310677plq.115.1659021953758; Thu, 28 Jul 2022 08:25:53 -0700 (PDT) MIME-Version: 1.0 References: <60599e84-edcb-f81d-0377-42337127ecda@suse.com> In-Reply-To: <60599e84-edcb-f81d-0377-42337127ecda@suse.com> From: "H.J. Lu" Date: Thu, 28 Jul 2022 08:25:17 -0700 Message-ID: Subject: Re: [PATCH] x86: SKINIT with operand needs IgnoreSize To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 15:25:55 -0000 On Thu, Jul 28, 2022 at 4:33 AM Jan Beulich wrote: > > Without it in 16-bit mode a pointless operand size prefix would be > emitted. > > --- a/opcodes/i386-opc.tbl > +++ b/opcodes/i386-opc.tbl > @@ -2068,7 +2068,7 @@ clgi, 0xf01dd, None, CpuSVME, No_bSuf|No > invlpga, 0xf01df, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} > invlpga, 0xf01df, None, CpuSVME, AddrPrefixOpReg, { Acc|Word|Dword|Qword, RegC|Dword } > skinit, 0xf01de, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} > -skinit, 0xf01de, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Acc|Dword } > +skinit, 0xf01de, None, CpuSVME, No_bSuf|IgnoreSize|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Acc|Dword } > stgi, 0xf01dc, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} > vmgexit, 0xf30f01d9, None, CpuSEV_ES, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} > vmload, 0xf01da, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} Can you add a testcase? Thanks. -- H.J.