From: "H.J. Lu" <hjl.tools@gmail.com>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: amodra@gmail.com, tromey@redhat.com, binutils@sourceware.org
Subject: Re: [PATCH 3/5] remove deleted BFDs from the archive cache
Date: Fri, 17 Aug 2012 16:10:00 -0000 [thread overview]
Message-ID: <CAMe9rOqUYv9p64kjjF+2i_k6HwTjXGtMRSz6CjOn+49-XKmHqQ@mail.gmail.com> (raw)
In-Reply-To: <201208171556.q7HFuUNL016929@ignucius.se.axis.com>
On Fri, Aug 17, 2012 at 8:56 AM, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
>> From: "H.J. Lu" <hjl.tools@gmail.com>
>> Date: Fri, 17 Aug 2012 07:04:18 +0200
>
>> On Thu, Aug 16, 2012 at 8:53 PM, Hans-Peter Nilsson
>> <hans-peter.nilsson@axis.com> wrote:
>> > With this I still see FAILS for cris-elf and cris-linux-gnu (but
>> > not for arm-unknown-eabi, mipsisa32r2el-unknown-linux-gnu,
>> > mmix-knuth-mmixware):
>> > Running /tmp/hpautotest-binutils/bsrc/src/binutils/testsuite/binutils-all/ar.exp ...
>> > FAIL: ar long file names (bfdtest1)
>> > FAIL: ar thin archive (bfdtest1)
>> >
>> > and in binutils.log:
>> > Executing on host: /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 tmpdir/artest.a (timeout = 300)
>> > /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 exited with status 1
>> > /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 exited with status 1
>> > FAIL: ar long file names (bfdtest1)
>> > ...
>> > Executing on host: /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 tmpdir/artest.a (timeout = 300)
>> > /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 exited with status 1
>> > /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 exited with status 1
>> > FAIL: ar thin archive (bfdtest1)
>> >
>> > Looking closer, it seems bfdtest1 is a new test, and a host
>> > program, which might explain the test-result differences.
>> > Shouldn't bfdtest1 be present and tested for native builds only?
>> >
>>
>> bfdtest1 is built the same as other programs.
>
> Not *test* programs. It seems bfdtest1 is used as input to ar
> in the failing tests.
>
>> valgrind
>> reports:
>>
>> ==3884==
>> ==3884== Invalid read of size 8
>> ==3884== at 0x403D85: bfd_generic_openr_next_archived_file (archive.c:765)
>> ==3884== by 0x402CCA: main (bfdtest1.c:60)
>> ==3884== Address 0x4c35ec0 is 208 bytes inside a block of size 296 free'd
>> ==3884== at 0x4A079AE: free (vg_replace_malloc.c:427)
>> ==3884== by 0x40D9B7: bfd_close (opncls.c:726)
>> ==3884== by 0x402C9D: main (bfdtest1.c:53)
>> ==3884==
>>
>> My new test is doing its job. There is a real bug.
>
> That might be, but I'm not sure random binary files for other
> architectures are expected to be valid input to ar. Is it?
> Ungracious failure surely, but I'm inclined to just skip the
> test (for my targets surely, for non-native if acceptable).
That is not what I saw. bfdtest1 takes an archive as
input:
/export/build/gnu/binutils-cross/build-cris-elf/binutils/bfdtest1
tmpdir/artest.a
Executing on host:
/export/build/gnu/binutils-cross/build-cris-elf/binutils/bfdtest1
tmpdir/artest.a (timeout = 300)
spawn -ignore SIGHUP
/export/build/gnu/binutils-cross/build-cris-elf/binutils/bfdtest1
tmpdir/artest.a^M
/export/build/gnu/binutils-cross/build-cris-elf/binutils/bfdtest1
exited with status 1
/export/build/gnu/binutils-cross/build-cris-elf/binutils/bfdtest1
exited with status 1
FAIL: ar long file names (bfdtest1)
It failed because bfdtest1 segfaulted.
--
H.J.
next prev parent reply other threads:[~2012-08-17 16:01 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 14:55 Tom Tromey
2012-08-03 16:12 ` Alan Modra
2012-08-03 20:56 ` Tom Tromey
2012-08-08 22:47 ` Tom Tromey
2012-08-09 10:35 ` Alan Modra
2012-08-15 20:14 ` H.J. Lu
2012-08-15 21:30 ` Tom Tromey
2012-08-16 14:47 ` Alan Modra
2012-08-16 16:31 ` H.J. Lu
2012-08-16 18:14 ` Tom Tromey
2012-08-16 18:33 ` H.J. Lu
2012-08-16 18:45 ` Tom Tromey
2012-08-16 18:49 ` H.J. Lu
2012-08-16 18:55 ` Tom Tromey
2012-08-16 20:33 ` Tom Tromey
2012-08-16 20:38 ` H.J. Lu
2012-08-16 21:11 ` H.J. Lu
2012-08-16 21:35 ` H.J. Lu
2012-08-17 1:01 ` Alan Modra
2012-08-17 1:06 ` H.J. Lu
2012-08-17 2:44 ` Alan Modra
2012-08-17 4:56 ` Hans-Peter Nilsson
2012-08-17 5:04 ` Alan Modra
2012-08-17 5:08 ` H.J. Lu
2012-08-17 5:30 ` H.J. Lu
2012-08-17 5:42 ` H.J. Lu
2012-08-17 5:45 ` H.J. Lu
2012-08-17 6:01 ` H.J. Lu
2012-08-17 13:10 ` H.J. Lu
2012-08-17 16:50 ` Hans-Peter Nilsson
2012-08-17 16:01 ` Hans-Peter Nilsson
2012-08-17 16:10 ` H.J. Lu [this message]
2012-08-17 16:14 ` Hans-Peter Nilsson
2012-08-17 16:13 ` Tom Tromey
2012-08-17 16:26 ` H.J. Lu
2012-08-17 16:51 ` Tom Tromey
2012-08-17 17:11 ` H.J. Lu
2012-08-17 17:22 ` Tom Tromey
2012-08-17 17:22 ` H.J. Lu
2012-08-17 19:03 ` Tom Tromey
2012-08-17 19:13 ` H.J. Lu
2012-08-18 4:37 ` Alan Modra
2012-08-21 9:55 ` Tom Tromey
2012-08-17 1:17 ` Alan Modra
2012-08-17 15:36 ` Tom Tromey
2012-08-17 15:38 ` H.J. Lu
2012-08-17 15:43 ` Tom Tromey
2012-08-17 0:48 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqUYv9p64kjjF+2i_k6HwTjXGtMRSz6CjOn+49-XKmHqQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hans-peter.nilsson@axis.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).