From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 493893856DCB for ; Wed, 18 May 2022 17:39:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 493893856DCB Received: by mail-pl1-x62c.google.com with SMTP id d22so2436404plr.9 for ; Wed, 18 May 2022 10:39:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6qgXeDPaMtkIemBhZM79oaQ/cqjz/bLmHt0ath4cTlY=; b=OFquHOvDe9dNCLa3GEOUmANLq73puscSAiZI/NGWK4cwsEZfCVwOd3Bxl5outKi9Cd 3sdsltFWWpq3ogaYzhq1UHPH+pwlhAeyrrxZQ5uI7xlRaObE8aTCxNmS/NqNHWTSV8sZ uHWjvi4BMPtLRDMuGowgaI9XpAgxMWzcmPrJC0mdTz74dDTUs5M0OSFK2Du4BlzAYMjm gwL03/6IA1Qn2kVe1LvDYDtuzBPz4s8QBK+ZRLpn/kDSu0VwRHSsXWmcP1K1Myp/3PjI Nykk0ypGqGwiTGSiRxLYW9ykkF5UtaON/N5nqK6GG7/FaiE6+1i1jLp04Dt0UdWFhTk0 Q67Q== X-Gm-Message-State: AOAM532Jp+AT/9bbb+mc66hvnhT6AOShuW5SyvSRmddfj6j1CI/mH7HM QZ0FHcUu9quhXYxtWD7ay3U14ot5UfHB7GWlO6LJ3iTB X-Google-Smtp-Source: ABdhPJyUrOPez8/BT2QMUHZFd5WRfIfHJ5CggAm4xe5W/ID+dRaDLS/UObeD70jZ9EpnnzWIn97hqQEdcTp/VzMrSHc= X-Received: by 2002:a17:902:d482:b0:15e:a06a:db0a with SMTP id c2-20020a170902d48200b0015ea06adb0amr510399plg.38.1652895557325; Wed, 18 May 2022 10:39:17 -0700 (PDT) MIME-Version: 1.0 References: <22e18c57-bd7d-eac7-6494-8c9cfdc4bd8d@suse.com> In-Reply-To: <22e18c57-bd7d-eac7-6494-8c9cfdc4bd8d@suse.com> From: "H.J. Lu" Date: Wed, 18 May 2022 10:38:41 -0700 Message-ID: Subject: Re: [PATCH] x86/Intel: test non-legacy VCVT{,U}SI2SH insn forms To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3019.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2022 17:39:19 -0000 On Mon, Apr 11, 2022 at 11:57 PM Jan Beulich wrote: > > For an unclear reason corresponding AVX512F tests were apparently not > cloned or used as reference here, and instead the bogus legacy forms of > the insns (with the embedded rounding specifier not last) were used. > --- > Ideally the legacy forms wouldn't have been supported by gas in the > first place, but I guess it's too late now for correcting this mistake. > > Note that in some other (pre-FP16) tests we also have some legacy > instances left. Perhaps we want to retain those for making sure they > continue to work even if modern code better wouldn't use them. > Ultimately even those forms aren't MASM-compatible, but I'll get to that > later. > > --- a/gas/testsuite/gas/i386/avx512_fp16.s > +++ b/gas/testsuite/gas/i386/avx512_fp16.s > @@ -891,7 +891,7 @@ _start: > vcvtsh2usi edx, WORD PTR [ecx+254] #AVX512-FP16 Disp8(7f) > vcvtsh2usi edx, WORD PTR [edx-256] #AVX512-FP16 Disp8(80) > vcvtsi2sh xmm6, xmm5, edx #AVX512-FP16 > - vcvtsi2sh xmm6, xmm5, {rn-sae}, edx #AVX512-FP16 HAS_SAE RC_CTRL > + vcvtsi2sh xmm6, xmm5, edx, {rn-sae} #AVX512-FP16 HAS_SAE RC_CTRL > vcvtsi2sh xmm6, xmm5, DWORD PTR [esp+esi*8+0x10000000] #AVX512-FP16 > vcvtsi2sh xmm6, xmm5, DWORD PTR [ecx] #AVX512-FP16 > vcvtsi2sh xmm6, xmm5, DWORD PTR [ecx+508] #AVX512-FP16 Disp8(7f) > @@ -972,7 +972,7 @@ _start: > vcvtuqq2ph xmm6, ZMMWORD PTR [ecx+8128] #AVX512-FP16 Disp8(7f) > vcvtuqq2ph xmm6{k7}{z}, QWORD PTR [edx-1024]{1to8} #AVX512-FP16 BROADCAST_EN Disp8(80) MASK_ENABLING ZEROCTL > vcvtusi2sh xmm6, xmm5, edx #AVX512-FP16 > - vcvtusi2sh xmm6, xmm5, {rn-sae}, edx #AVX512-FP16 HAS_SAE RC_CTRL > + vcvtusi2sh xmm6, xmm5, edx, {rn-sae} #AVX512-FP16 HAS_SAE RC_CTRL > vcvtusi2sh xmm6, xmm5, DWORD PTR [esp+esi*8+0x10000000] #AVX512-FP16 > vcvtusi2sh xmm6, xmm5, DWORD PTR [ecx] #AVX512-FP16 > vcvtusi2sh xmm6, xmm5, DWORD PTR [ecx+508] #AVX512-FP16 Disp8(7f) > --- a/gas/testsuite/gas/i386/x86-64-avx512_fp16.s > +++ b/gas/testsuite/gas/i386/x86-64-avx512_fp16.s > @@ -933,9 +933,9 @@ _start: > vcvtsh2usi r12, WORD PTR [rcx+254] #AVX512-FP16 Disp8(7f) > vcvtsh2usi r12, WORD PTR [rdx-256] #AVX512-FP16 Disp8(80) > vcvtsi2sh xmm30, xmm29, r12 #AVX512-FP16 > - vcvtsi2sh xmm30, xmm29, {rn-sae}, r12 #AVX512-FP16 HAS_SAE RC_CTRL > + vcvtsi2sh xmm30, xmm29, r12, {rn-sae} #AVX512-FP16 HAS_SAE RC_CTRL > vcvtsi2sh xmm30, xmm29, edx #AVX512-FP16 > - vcvtsi2sh xmm30, xmm29, {rn-sae}, edx #AVX512-FP16 HAS_SAE RC_CTRL > + vcvtsi2sh xmm30, xmm29, edx, {rn-sae} #AVX512-FP16 HAS_SAE RC_CTRL > vcvtsi2sh xmm30, xmm29, DWORD PTR [rbp+r14*8+0x10000000] #AVX512-FP16 > vcvtsi2sh xmm30, xmm29, DWORD PTR [r9] #AVX512-FP16 > vcvtsi2sh xmm30, xmm29, DWORD PTR [rcx+508] #AVX512-FP16 Disp8(7f) > @@ -1030,9 +1030,9 @@ _start: > vcvtuqq2ph xmm30, ZMMWORD PTR [rcx+8128] #AVX512-FP16 Disp8(7f) > vcvtuqq2ph xmm30{k7}{z}, QWORD PTR [rdx-1024]{1to8} #AVX512-FP16 BROADCAST_EN Disp8(80) MASK_ENABLING ZEROCTL > vcvtusi2sh xmm30, xmm29, r12 #AVX512-FP16 > - vcvtusi2sh xmm30, xmm29, {rn-sae}, r12 #AVX512-FP16 HAS_SAE RC_CTRL > + vcvtusi2sh xmm30, xmm29, r12, {rn-sae} #AVX512-FP16 HAS_SAE RC_CTRL > vcvtusi2sh xmm30, xmm29, edx #AVX512-FP16 > - vcvtusi2sh xmm30, xmm29, {rn-sae}, edx #AVX512-FP16 HAS_SAE RC_CTRL > + vcvtusi2sh xmm30, xmm29, edx, {rn-sae} #AVX512-FP16 HAS_SAE RC_CTRL > vcvtusi2sh xmm30, xmm29, DWORD PTR [rbp+r14*8+0x10000000] #AVX512-FP16 > vcvtusi2sh xmm30, xmm29, DWORD PTR [r9] #AVX512-FP16 > vcvtusi2sh xmm30, xmm29, DWORD PTR [rcx+508] #AVX512-FP16 Disp8(7f) > OK. Thanks. -- H.J.