From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-82949-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 1225 invoked by alias); 25 Feb 2014 16:53:18 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 1210 invoked by uid 89); 25 Feb 2014 16:53:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-oa0-f47.google.com
Received: from mail-oa0-f47.google.com (HELO mail-oa0-f47.google.com) (209.85.219.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 25 Feb 2014 16:53:14 +0000
Received: by mail-oa0-f47.google.com with SMTP id h16so691653oag.20        for <binutils@sourceware.org>; Tue, 25 Feb 2014 08:53:12 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.183.3.102 with SMTP id bv6mr2259036obd.18.1393347191317; Tue, 25 Feb 2014 08:53:11 -0800 (PST)
Received: by 10.76.151.164 with HTTP; Tue, 25 Feb 2014 08:53:11 -0800 (PST)
In-Reply-To: <20140225162451.GB75072@msticlxl7.ims.intel.com>
References: <20140220151936.GA1312@msticlxl7.ims.intel.com>	<CAMe9rOps3fYbJvx0v+6gm2jd=UrDT-0in8adyAUpfQk8AvNy2g@mail.gmail.com>	<20140224132223.GA39232@msticlxl7.ims.intel.com>	<CAMe9rOqiBVCGAUY-q_HKfnxFVz2tspNCytPNz2mB1hVKrNxajQ@mail.gmail.com>	<20140225094128.GB31394@msticlxl7.ims.intel.com>	<CAMe9rOrExVo8jbWf_jyefFxoUd0oYXOvdZK4YK5YkEv9Ma4jcQ@mail.gmail.com>	<CAMe9rOrJb0qCEmznJ08vmc+BjCJwfQQ6i=Oq_rSZTfoo30fG2A@mail.gmail.com>	<20140225162451.GB75072@msticlxl7.ims.intel.com>
Date: Tue, 25 Feb 2014 16:53:00 -0000
Message-ID: <CAMe9rOqjHOoYhGUnYQri4cJfA+N4hYCyDYp_AWR7XvJf-YBevg@mail.gmail.com>
Subject: Re: [PATCH, i386][3/3] Update to match latest AVX512 spec.
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ilya Tocar <tocarip.intel@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
X-SW-Source: 2014-02/txt/msg00153.txt.bz2

On Tue, Feb 25, 2014 at 8:24 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> >>> vcvtps2ph supports memory destination.  Please add AVX512F testcases
>> >>> with memory destination.
>> >>>
>> >> We already have such tests. See e. g. on lines 6883-6890 in
>> >> gas/testsuite/gas/i386/avx512f.s we have:
>> >>
>> >>         vcvtps2ph       $0xab, %zmm6, (%ecx)     # AVX512F
>> >>         vcvtps2ph       $0xab, %zmm6, (%ecx){%k7}        # AVX512F
>> >>         vcvtps2ph       $123, %zmm6, (%ecx)      # AVX512F
>> >>         vcvtps2ph       $123, %zmm6, -123456(%esp,%esi,8)        # AVX512F
>> >>         vcvtps2ph       $123, %zmm6, 4064(%edx)  # AVX512F Disp8
>> >>         vcvtps2ph       $123, %zmm6, 4096(%edx)  # AVX512F
>> >>         vcvtps2ph       $123, %zmm6, -4096(%edx)         # AVX512F Disp8
>> >>
>> >> Do we need additional tests?
>> >
>> > Yes, please test with memory destination for:
>> >
>> > vcvtps2ph, 3, 0x661D, None, 1, CpuAVX512F,
>> > Modrm|EVex=1|Masking=2|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE,
>> > { Imm8, Imm8, RegZMM|RegMem }
> This variant is removed in my patch. What exactly should I test?
>>
>> Also for
>>
>> vcvtps2ph, 4, 0x661D, None, 1, CpuAVX512F,
>> Modrm|EVex=1|Masking=3|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE,
>> { Imm8, Imm8, RegZMM, RegYMM|RegMem }
> This is reg-reg version with SAE, which is already tested on e. g.
> line 2602 in gas/testsuite/gas/i386/avx512f.s:
>
>         vcvtps2ph       $0xab, {sae}, %zmm5, %ymm6{%k7}  # AVX512F
>
> Also instruction can't have memory operand and SAE at the same time.

OK.  I checked it in for you.

Thanks.


-- 
H.J.