From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 94BDF3858D32 for ; Wed, 30 Nov 2022 00:00:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 94BDF3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-142b72a728fso19108666fac.9 for ; Tue, 29 Nov 2022 16:00:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0XdHVTTzov8FvUi+53M15CktRAj2v4KEpiooLHirDSY=; b=WGDFIo3+i0Lxdtou8bDmhpxztyeF49/dJRDMXbksDUnHLZv1oQMPL21CUkxi4eGbaS lGWTCcs9W8ollpWB5lYNvRzxT+CuT0e+YZDWhZkqal29raXlRBDOZCK54gt5gt1l0UY6 GOxCrcJscpBGpB5I2hYTkwDk0GOFREZkmtPRAIEn/4KgFD7OJbsg//jwMG7HWzGBJwrF 3r1Adfr4N9cd4AFZX/3bnx3Sptxy4q5xyxbkNaXvRbzQozulaVJFuhhoNEEsDZeE5ZHH UMbnrdSb6htEbXWruEyEriE+3eSyKudLhfVCLnKFp55eWNdOprhG/ztMLJNESL/lMTSg VaPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0XdHVTTzov8FvUi+53M15CktRAj2v4KEpiooLHirDSY=; b=LVG6aZdKT5O3UNegL65Y1uNI4G4pSZc1qonUFWOsNcunyLS4KNxoPahNANDmF54v6X z00ZyXOUM7BU1QAIqesCf/x10jRq8U2xCcepvCU83uvIAjdE9wBZ/yE1AajmjxR+egXa 5f2WF+WyE2SgCX1Yp8aVsAb4b5rr5AGJEkovAy+FpFi1ghNoTMwT+j8J6iE6LKERnVvX xdk4Myc339VtwXHRi6T9znh41i9jp5Jn1nFHraqw8TKkXm9yK5zIBQ39338yS7Agl6w4 tosyxPDKHjkLvOf5XKrvxQ2g53l8RaujCkPY3G1if0WF4NDBmD1Lhurya+Rpbb06AehY 3iXg== X-Gm-Message-State: ANoB5pliYTSw9ZAly5hks/M7mSEUNuBn9YHU5ZyPFV15mF6UZB7J9Ze0 VK5UHOQrbottgAyn1PnpzXhp1XTl5OWAmaqvkrAj6/Pa X-Google-Smtp-Source: AA0mqf7h9LFw29jwuJAP/dhCLsPENsJToLD3SdchDUkMZOo6HMIlpBAJ9uNrGX6nWoH63Kl7KYWn9NQa88RrPraWmAw= X-Received: by 2002:a05:6870:cb45:b0:13b:8bb8:5c5b with SMTP id oz5-20020a056870cb4500b0013b8bb85c5bmr28350079oab.298.1669766422652; Tue, 29 Nov 2022 16:00:22 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Tue, 29 Nov 2022 15:59:46 -0800 Message-ID: Subject: Re: [PATCH 1/3] x86: extend FPU test coverage for AT&T / Intel mnemonic differences To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3016.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 24, 2022 at 12:57 AM Jan Beulich wrote: > > Before touching the templates, let's ensure we actually cover things: > For one FSUB{,R} and FDIV{,R} would better be tested with operands in > both possible orders. And then -mmnemonic=intel wasn't tested at all. > > --- a/gas/testsuite/gas/i386/compat.d > +++ b/gas/testsuite/gas/i386/compat.d > @@ -8,18 +8,22 @@ Disassembly of section .text: > > 0+ <.text>: > [ ]*[a-f0-9]+: dc e3 fsub %st,%st\(3\) > +[ ]*[a-f0-9]+: d8 e3 fsub %st\(3\),%st > [ ]*[a-f0-9]+: de e1 fsubp %st,%st\(1\) > [ ]*[a-f0-9]+: de e3 fsubp %st,%st\(3\) > [ ]*[a-f0-9]+: de e3 fsubp %st,%st\(3\) > [ ]*[a-f0-9]+: dc eb fsubr %st,%st\(3\) > +[ ]*[a-f0-9]+: d8 eb fsubr %st\(3\),%st > [ ]*[a-f0-9]+: de e9 fsubrp %st,%st\(1\) > [ ]*[a-f0-9]+: de eb fsubrp %st,%st\(3\) > [ ]*[a-f0-9]+: de eb fsubrp %st,%st\(3\) > [ ]*[a-f0-9]+: dc f3 fdiv %st,%st\(3\) > +[ ]*[a-f0-9]+: d8 f3 fdiv %st\(3\),%st > [ ]*[a-f0-9]+: de f1 fdivp %st,%st\(1\) > [ ]*[a-f0-9]+: de f3 fdivp %st,%st\(3\) > [ ]*[a-f0-9]+: de f3 fdivp %st,%st\(3\) > [ ]*[a-f0-9]+: dc fb fdivr %st,%st\(3\) > +[ ]*[a-f0-9]+: d8 fb fdivr %st\(3\),%st > [ ]*[a-f0-9]+: de f9 fdivrp %st,%st\(1\) > [ ]*[a-f0-9]+: de fb fdivrp %st,%st\(3\) > [ ]*[a-f0-9]+: de fb fdivrp %st,%st\(3\) > --- a/gas/testsuite/gas/i386/compat.s > +++ b/gas/testsuite/gas/i386/compat.s > @@ -1,18 +1,22 @@ > # Check SYSV mnemonic instructions. > .text > fsub %st,%st(3) > + fsub %st(3),%st > fsubp > fsubp %st(3) > fsubp %st,%st(3) > fsubr %st,%st(3) > + fsubr %st(3),%st > fsubrp > fsubrp %st(3) > fsubrp %st,%st(3) > fdiv %st,%st(3) > + fdiv %st(3),%st > fdivp > fdivp %st(3) > fdivp %st,%st(3) > fdivr %st,%st(3) > + fdivr %st(3),%st > fdivrp > fdivrp %st(3) > fdivrp %st,%st(3) > --- a/gas/testsuite/gas/i386/compat-intel.d > +++ b/gas/testsuite/gas/i386/compat-intel.d > @@ -9,18 +9,22 @@ Disassembly of section .text: > > 0+ <.text>: > [ ]*[a-f0-9]+: dc e3 fsubr st\(3\),st > +[ ]*[a-f0-9]+: d8 e3 fsub st,st\(3\) > [ ]*[a-f0-9]+: de e1 fsubrp st\(1\),st > [ ]*[a-f0-9]+: de e3 fsubrp st\(3\),st > [ ]*[a-f0-9]+: de e3 fsubrp st\(3\),st > [ ]*[a-f0-9]+: dc eb fsub st\(3\),st > +[ ]*[a-f0-9]+: d8 eb fsubr st,st\(3\) > [ ]*[a-f0-9]+: de e9 fsubp st\(1\),st > [ ]*[a-f0-9]+: de eb fsubp st\(3\),st > [ ]*[a-f0-9]+: de eb fsubp st\(3\),st > [ ]*[a-f0-9]+: dc f3 fdivr st\(3\),st > +[ ]*[a-f0-9]+: d8 f3 fdiv st,st\(3\) > [ ]*[a-f0-9]+: de f1 fdivrp st\(1\),st > [ ]*[a-f0-9]+: de f3 fdivrp st\(3\),st > [ ]*[a-f0-9]+: de f3 fdivrp st\(3\),st > [ ]*[a-f0-9]+: dc fb fdiv st\(3\),st > +[ ]*[a-f0-9]+: d8 fb fdivr st,st\(3\) > [ ]*[a-f0-9]+: de f9 fdivp st\(1\),st > [ ]*[a-f0-9]+: de fb fdivp st\(3\),st > [ ]*[a-f0-9]+: de fb fdivp st\(3\),st > --- /dev/null > +++ b/gas/testsuite/gas/i386/compat-intel2.d > @@ -0,0 +1,31 @@ > +#as: -mmnemonic=intel > +#objdump: -d -Mintel-mnemonic > +#name: i386 float Intel mnemonic (2) > +#source: compat.s > + > +.*: +file format .* > + > +Disassembly of section .text: > + > +0+ <.text>: > +[ ]*[a-f0-9]+: dc eb fsub st\(3\),st > +[ ]*[a-f0-9]+: d8 e3 fsub st,st\(3\) > +[ ]*[a-f0-9]+: de e9 fsubp st\(1\),st > +[ ]*[a-f0-9]+: de eb fsubp st\(3\),st > +[ ]*[a-f0-9]+: de eb fsubp st\(3\),st > +[ ]*[a-f0-9]+: dc e3 fsubr st\(3\),st > +[ ]*[a-f0-9]+: d8 eb fsubr st,st\(3\) > +[ ]*[a-f0-9]+: de e1 fsubrp st\(1\),st > +[ ]*[a-f0-9]+: de e3 fsubrp st\(3\),st > +[ ]*[a-f0-9]+: de e3 fsubrp st\(3\),st > +[ ]*[a-f0-9]+: dc fb fdiv st\(3\),st > +[ ]*[a-f0-9]+: d8 f3 fdiv st,st\(3\) > +[ ]*[a-f0-9]+: de f9 fdivp st\(1\),st > +[ ]*[a-f0-9]+: de fb fdivp st\(3\),st > +[ ]*[a-f0-9]+: de fb fdivp st\(3\),st > +[ ]*[a-f0-9]+: dc f3 fdivr st\(3\),st > +[ ]*[a-f0-9]+: d8 fb fdivr st,st\(3\) > +[ ]*[a-f0-9]+: de f1 fdivrp st\(1\),st > +[ ]*[a-f0-9]+: de f3 fdivrp st\(3\),st > +[ ]*[a-f0-9]+: de f3 fdivrp st\(3\),st > +#pass > --- a/gas/testsuite/gas/i386/i386.exp > +++ b/gas/testsuite/gas/i386/i386.exp > @@ -178,6 +178,7 @@ if [gas_32_check] then { > run_dump_test "i386-intel" > run_dump_test "compat" > run_dump_test "compat-intel" > + run_dump_test "compat-intel2" > run_dump_test "arch-1" > run_dump_test "arch-2" > run_dump_test "arch-3" > OK Thanks. -- H.J.