From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 5125D3858417 for ; Thu, 1 Dec 2022 18:20:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5125D3858417 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-1322d768ba7so3090132fac.5 for ; Thu, 01 Dec 2022 10:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RUIBk3gBBcBqXWsi6RqBKZxgdyMZFu+ywF8q5eChJcY=; b=OMeW+SIFuxZOqqL3YeIXhlDeC+g5Yh1JVq2b8IgIg2EOflxPTmRFqabAFNvxrrwIPK riwAa/inBp+s+dka+HNfn9PcXebHTQ/IOxKJEHqw5RXgRFpDcwBWUDehm5sxOp0qc+it GmOMslEjbt2AhVWhvto42h6kBcnKd9kP92vVVI+CMo+U2emD2nV6LhxUgD3MaNPxUZeC 5AhgR4egFEdWRm8c9KdN2LNJ8sbaHRRXBQWxuZRpGAJo3KBKCJuCRXoUWVdR6vVZxfTH 0hdJ0T8DeA2bvs5zMilBCGWxcVTb0aJfkOorAVbKqGUF7a8WzVVXLdrRKJEp7KL8E/xM DHUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RUIBk3gBBcBqXWsi6RqBKZxgdyMZFu+ywF8q5eChJcY=; b=KpbwcUUmDYUhCCko5c5R1bZPtbsj7EzOhQHdIcBDjedmlF0exdNByxoGXG5blaQ/Wd yfI/5xXkz5ehFxFZKpZp/JZYmQZ8dyNili5me5Br6KfVgn9NJg/iTYm+OzNl7SmBqMvd 8b0rJXc9t22rhoe+DDu4Sw8E5nWT/WtkzFE0yHdRhcbhYGr6dMkXa0Xp+bkmWYGC0+Tq 0bikPDfpuLvCbyvb9tvArDG/P8WYB028DI9K0mlEj3eBkGj56/CCgJwI6J6YRwvZN5ha 8iCx4VXA8pfiFidz/qGKeP6wuZeb33tsFVhPIQwnvzA/aHMaiMBjdILOPbvxXuMiEopc rwgA== X-Gm-Message-State: ANoB5plqPpDzuYH1h11hcN2nHJEl/k94cIc0M08dxQTsQYSEm6NPYy7M TLx93U/T6gHW6lJXLRaY8fj6Q3G6s7ImIIcO2tWhCMULMHw= X-Google-Smtp-Source: AA0mqf7IQLCBuuWug2UEfHuXpmGzBSmd6fZzKZMewvPK3cm+cOJ6AFGu0LrQSLyx7GkWwvuvZ3Az16OoMVkYbRSEj5c= X-Received: by 2002:a05:6870:cb45:b0:13b:8bb8:5c5b with SMTP id oz5-20020a056870cb4500b0013b8bb85c5bmr33683156oab.298.1669918854387; Thu, 01 Dec 2022 10:20:54 -0800 (PST) MIME-Version: 1.0 References: <20221122181927.251937-1-hjl.tools@gmail.com> <6a5d4918-919a-8b6b-822b-17ce38488629@suse.com> <3f038bc9-6188-9bc4-d73c-51cc633fd69d@suse.com> <063e5b0a-8a77-2734-330a-6bc7466546eb@suse.com> In-Reply-To: <063e5b0a-8a77-2734-330a-6bc7466546eb@suse.com> From: "H.J. Lu" Date: Thu, 1 Dec 2022 10:20:18 -0800 Message-ID: Subject: Re: [PATCH v2] x86: Remove libopcodes dependency To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3016.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 30, 2022 at 11:21 PM Jan Beulich wrote: > > On 30.11.2022 23:15, H.J. Lu wrote: > > On Tue, Nov 29, 2022 at 11:31 PM Jan Beulich wrote: > >> On 29.11.2022 20:38, H.J. Lu wrote: > >>> On Tue, Nov 29, 2022 at 1:22 AM Jan Beulich wrote: > >>>> On 29.11.2022 00:49, H.J. Lu wrote: > >>>>> On Thu, Nov 24, 2022 at 2:19 AM Jan Beulich wrote: > >>>>>> On 22.11.2022 19:19, H.J. Lu wrote: > >>>>>>> --- a/gas/Makefile.am > >>>>>>> +++ b/gas/Makefile.am > >>>>>>> @@ -446,6 +446,12 @@ development.exp: $(BFDDIR)/development.sh > >>>>>>> $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ > >>>>>>> | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ > >>>>>>> > >>>>>>> +$(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: \ > >>>>>>> + @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ > >>>>>>> + $(srcdir)/../opcodes/i386-reg.tbl \ > >>>>>>> + $(srcdir)/../opcodes/i386-opc.h > >>>>>>> + cd ../opcodes; make gen-i386-tbl > >>>>>> > >>>>>> I've made a patch to gas/Makefile.am as you have requested in reply to > >>>>>> my series. I will want to put that through some more testing, so I will > >>>>>> submit a v3 of that only a little later (and of course only unless you > >>>>>> submit a v2 of your patch earlier that I would also end up being okay > >>>>>> with). In the course of doing so I noticed a few more issues with your > >>>>>> change: > >>>>>> > >>>>>> For one I don't think you can put @MAINT@ on a continued line, as the > >>>>>> line continuation might then be hidden when @MAINT@ expands to #. The > >>>>>> list of dependencies wants expressing via a variable, which would then > >>>>>> be used immediately after @MAINT@ without any line continuation > >>>>>> following. > >>>>> > >>>>> Fixed. > >>>> > >>>> No, the same problem is still there. You either need to use a very long > >>>> line, or you need to introduce a variable holding the list of prereqs, > >>>> like I've done in my series. > >>> > >>> I got > >>> > >>> $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: > >> > >> Note the missing line continuation here. > > > > They are on the same line: > > > > $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: > > $(srcdir)/../opcodes/i386-opc.tbl \ > > Oh, okay - just a UI presentation issue then here. > > > or > > > > $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: # > > $(srcdir)/../opcodes/i386-opc.tbl \ > > Here, though, this is an issue, because the line continuation then is > past the comment character. > > Jan It looks like # foo \ bar 2 lines are treated as a single line. -- H.J.