From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-76383-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 28484 invoked by alias); 30 Jul 2012 17:05:17 -0000
Received: (qmail 28475 invoked by uid 22791); 30 Jul 2012 17:05:15 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jul 2012 17:04:53 +0000
Received: by vbkv13 with SMTP id v13so5493635vbk.0        for <binutils@sourceware.org>; Mon, 30 Jul 2012 10:04:53 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.52.95.171 with SMTP id dl11mr10261266vdb.120.1343667892994; Mon, 30 Jul 2012 10:04:52 -0700 (PDT)
Received: by 10.58.179.79 with HTTP; Mon, 30 Jul 2012 10:04:52 -0700 (PDT)
In-Reply-To: <500EDBB502000078000903BB@nat28.tlf.novell.com>
References: <500EDBB502000078000903BB@nat28.tlf.novell.com>
Date: Mon, 30 Jul 2012 17:05:00 -0000
Message-ID: <CAMe9rOqyWV9QZYMb=XqVE70MO8ne3hf7ZYQPtpKUTF67Anc-oQ@mail.gmail.com>
Subject: Re: [PATCH] x86: adjust diagnostic for bad 4-bit immediates
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: binutils@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00296.txt.bz2

On Tue, Jul 24, 2012 at 8:30 AM, Jan Beulich <JBeulich@suse.com> wrote:
> The current error message for bad imm4 operands wasn't really helpful,
> and was pointing at the wrong operand in Intel mode. Since non-constant
> operands are being taken care of by other means anyway, adjust it to
> simply state that the constant doesn't fit.
>
> 2012-07-24  Jan Beulich <jbeulich@suse.com>
>
>         * config/tc-i386-intel.c (match_template): Adjust error message
>         for 'bad_imm4' case.
>
> --- a/gas/config/tc-i386.c
> +++ b/gas/config/tc-i386.c
> @@ -4347,7 +4347,7 @@ check_reverse:
>           err_msg = _("invalid instruction suffix");
>           break;
>         case bad_imm4:
> -         err_msg = _("Imm4 isn't the first operand");
> +         err_msg = _("Constant doesn't fit in 4 bits");
>           break;
>         case old_gcc_only:
>           err_msg = _("only supported with old gcc");
>

Error message starts with the lower case.  OK with
that change.

-- 
H.J.