From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3867 invoked by alias); 17 Feb 2020 15:43:35 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 3798 invoked by uid 89); 17 Feb 2020 15:43:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:b09a16d, H*i:sk:b09a16d, H*RU:209.85.167.193, HX-Spam-Relays-External:209.85.167.193 X-HELO: mail-oi1-f193.google.com Received: from mail-oi1-f193.google.com (HELO mail-oi1-f193.google.com) (209.85.167.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 15:43:33 +0000 Received: by mail-oi1-f193.google.com with SMTP id z2so17060264oih.6 for ; Mon, 17 Feb 2020 07:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=94c85ZRYble8nRtHIbZRI03n5lO1uoiUkbDl4YfyPOo=; b=VQgzLc9vqvBypnZod9oQUlCM/apwmdNL2T5EwSs0BiobOYdxy1YVaIMIt9raNyqcaO mLQvtXcq4X+8NEnQ0+jxHgKU56ahVm7UOWQ4IB5OYu8z1+tqu7Kev0+abSumjmCT9y+t 9byZuXgaLdIgXreQidO1tk+Nn61xYOcWsyJeB7hkG9QmNBVvF/JxWE2vOhJdkPlBGULM JbFJ7hRNzGuwtkQ6UQLTzezFJY0xw7whjXT6bcoTbOlaniymNTq3EMi4nA6bTdQvW2r0 etztxO7EUycMjL+b8PrbKkkNXpe8i9GovymM4wZDuKg24iZrTBm6Y+PG9m9Hi0i3AsS4 6tbA== MIME-Version: 1.0 References: <20200217152740.GA270001@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 17 Feb 2020 15:43:00 -0000 Message-ID: Subject: Re: [PATCH] x86: Replace CpuABM with CpuPOPCNT To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00402.txt.bz2 On Mon, Feb 17, 2020 at 7:40 AM Jan Beulich wrote: > > On 17.02.2020 16:27, H.J. Lu wrote: > > AMD ABM has 2 instructions: popcnt and lzcnt. ABM CPUID feature bit has > > been reused for lzcnt and a POPCNT CPUID feature bit is added for popcnt. > > This patch removes CpuABM and adds CpuPOPCNT. It changes ABM to enable > > both lzcnt and popcnt, changes SSE4.2 to also enable popcnt. > > I don't think removing support for something may have in active and > working use is a good idea. Adding some better mechanism as > _suggested_ replacement is of course fine, but people would better > not be forced to change their _correct_ code because of gas side > change. No assembly code changes are needed. The .abm directive still works as before. My patch only changes assembler internal implementation. -- H.J.