From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by sourceware.org (Postfix) with ESMTPS id B76383858CDA for ; Mon, 29 Jan 2024 13:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B76383858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B76383858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706533218; cv=none; b=dB+Wi+We35S/L9lfwxgQJkyKXgjsNbqDbuvFhtAYmT8TcBNvOjfWliZsKx8xu6H/CaK1fApNwXXJw4Qg3c2h1bWHeCxWQYcZzASeDaw8rJX3s0FwpO6t2ly6TRPLxM9DKHRE2SHcpD8hR6Vp98tEZv/pNJwEi0JCySoXl/KexHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706533218; c=relaxed/simple; bh=UTwWDjFmePEU5f+yAENkHEI3DBOqKeIG33qhMUhWxL4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=aVU/9yJlguqk/dyx9jvmsKhMtwjZhP9SEiPDhg68d56Psvm9PvE0qTQgA2zXSqPV9Y/SPmFNHPitjW2kg/C2KcQbSs3gJNog3u312ZwWAeCzKHWYpp3+JRNqkp+9BJ/GBBp0R+mXOtEC5mYYxu5OPiLSFF1ZBTqhO14hK5O/cas= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-dc236729a2bso2798794276.0 for ; Mon, 29 Jan 2024 05:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706533216; x=1707138016; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h1Amrrs3MfWOJfzwC3/zXYwLjHKQLkWgOs/Zi8qkm4k=; b=MWhcZ5ZA8AskgDkvGKubgkBAdJMByvZVruiBFab37H7gfSpR05Gcqps9DAQSokrwwm gmNL7uLbJs4o2TfTsf7zT8I8YYUt6tKO9Sbtyt0ucX5f5ZCCtIEq4wNe2D0kpcuC7jTL oxpmvMH8RYKlUwCXvEIP0B3ddPLzDsi4ql+2wIypzCGVLilUmh8b+29wTkNXqfoYAe5g LAoIRYOD8WPkGaHxqhWntCXMEkIVxYlhGAGtsgRqk8qZjDiBBOFFa6bDcyn7fgiLjBUk 7HSJxzRTQzs1wzv1iT1TNq77fUb7GYf6sLgTIS7xR+I5VDuVR2Z3LEOcqDHRpZaGe24q 4Yfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706533216; x=1707138016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h1Amrrs3MfWOJfzwC3/zXYwLjHKQLkWgOs/Zi8qkm4k=; b=BGrM45lid2d4d1IVWZfsHwagetoMWrLJA7Mo/hn9jYql0zqUwxtWJjUgFzOCaD8bHs CrUygEJYIpWgSMyuBGd0Iq7zIB0McONyAdgY/Xr8qMRwOzn6PHHGcyzfYEdQBgt5xwuf 6g8jeQjPbet2onVjhIn9gRE6ShvduTg05lRNuBjOadsv9pF5L14o7F47/etMSYSFogzu jGctf9FWBNDW30BG8e9ZxQ66cyKMkwEDiMDU5lQFV4LTOf5WT+LktYXu+hMv77FKeGWY P4RAORZbbdr+3DTWbzMf3MbijZ8EMZr8xfyKus5vC6OUJupULJq9OBgMBWMLrw6dVSrm DITA== X-Gm-Message-State: AOJu0YxLTTH4ZJtYdhgFc5E7NuMVtDpfT940qrhS/24XctGexzXh2yUC MUMF8ureRSxIbRHoUYB4w4X8cuMxYgUXXTabhdHO5yzbKmTIYBDmq7BgjqZmuizVE4++6D7yPIy qtk5vQi30xlT8H+YKbAofBeMHmAU= X-Google-Smtp-Source: AGHT+IFgBCf/k56BIPYhTPaI7S+2UQI5TL+AZcFLnmzAz/YBVGZ9ImLsR5fLyfUxu7z41tFimkHB9Kj/Oe/ooFmtLGA= X-Received: by 2002:a25:ab02:0:b0:dc6:1869:991a with SMTP id u2-20020a25ab02000000b00dc61869991amr2414693ybi.5.1706533215867; Mon, 29 Jan 2024 05:00:15 -0800 (PST) MIME-Version: 1.0 References: <20240126214553.46536-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 29 Jan 2024 04:59:39 -0800 Message-ID: Subject: Re: [PATCH v2] ld: Turn on --error-execstack/--error-rwx-segments To: Jan Beulich Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3014.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jan 28, 2024 at 11:33=E2=80=AFPM Jan Beulich wr= ote: > > On 28.01.2024 16:04, H.J. Lu wrote: > > If there is no objection, I will check it tomorrow. > > I'm surprised here: Shouldn't a non-trivial (small !=3D trivial) change > like this require active approval? At the very least I can only once > again mention that waiting for just a single day is too little, imo. > My patch changes a "warning": [hjl@gnu-cfl-3 ld]$ touch x.s [hjl@gnu-cfl-3 ld]$ gcc -c x.s [hjl@gnu-cfl-3 ld]$ ld -shared -z stack-size=3D0x123400 --fatal-warnings --warn-execstack --no-error-execstack x.o ld: warning: x.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker [hjl@gnu-cfl-3 ld]$ echo $? 1 [hjl@gnu-cfl-3 ld]$ to an error: [hjl@gnu-cfl-3 ld]$ ./ld-new -shared -z stack-size=3D0x123400 --fatal-warnings --warn-execstack --no-error-execstack x.o ./ld-new: error: x.o: is triggering the generation of an executable stack because it does not have a .note.GNU-stack section ./ld-new: failed to set dynamic section sizes: file format not recognized [hjl@gnu-cfl-3 ld]$ I view it as trivial since it only corrects the incorrect linker message. --=20 H.J.