public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ilya Tocar <tocarip.intel@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH, i386] Update to match latest AVX512 spec.
Date: Wed, 19 Feb 2014 20:56:00 -0000	[thread overview]
Message-ID: <CAMe9rOr20VMkcdQobM+F2Xmi=39NRwUof2rN8rw7GvSQPLkjZQ@mail.gmail.com> (raw)
In-Reply-To: <20140219171629.GA53104@msticlxl7.ims.intel.com>

On Wed, Feb 19, 2014 at 9:16 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:

> Attached is gzipped patch. Testing passes. There are a few trailing whitespaces,
> but only in auto-generated files.

I checked in this patch to avoid trailing space in generated files.

-- 
H.J.
--
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index f861eca..df34675 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,11 @@
+2014-02-19  H.J. Lu  <hongjiu.lu@intel.com>
+
+ * i386-gen.c (output_cpu_flags): Don't output trailing space.
+ (output_opcode_modifier): Likewise.
+ (output_operand_type): Likewise.
+ * i386-init.h: Regenerated.
+ * i386-tbl.h: Likewise.
+
 2014-02-12  Ilya Tocar  <ilya.tocar@intel.com>

  * i386-dis.c (MOD enum): Add MOD_0FC7_REG_3, MOD_0FC7_REG_4,
diff --git a/opcodes/i386-gen.c b/opcodes/i386-gen.c
index 343f58d..59f7e09 100644
--- a/opcodes/i386-gen.c
+++ b/opcodes/i386-gen.c
@@ -713,7 +713,10 @@ output_cpu_flags (FILE *table, bitfield *flags,
unsigned int size,

   for (i = 0; i < size - 1; i++)
     {
-      fprintf (table, "%d, ", flags[i].value);
+      if (((i + 1) % 20) != 0)
+ fprintf (table, "%d, ", flags[i].value);
+      else
+ fprintf (table, "%d,", flags[i].value);
       if (((i + 1) % 20) == 0)
  {
   /* We need \\ for macro.  */
@@ -801,7 +804,10 @@ output_opcode_modifier (FILE *table, bitfield
*modifier, unsigned int size)

   for (i = 0; i < size - 1; i++)
     {
-      fprintf (table, "%d, ", modifier[i].value);
+      if (((i + 1) % 20) != 0)
+        fprintf (table, "%d, ", modifier[i].value);
+      else
+        fprintf (table, "%d,", modifier[i].value);
       if (((i + 1) % 20) == 0)
  fprintf (table, "\n      ");
     }
@@ -842,12 +848,15 @@ output_operand_type (FILE *table, bitfield
*types, unsigned int size,

   for (i = 0; i < size - 1; i++)
     {
-      fprintf (table, "%d, ", types[i].value);
+      if (((i + 1) % 20) != 0)
+ fprintf (table, "%d, ", types[i].value);
+      else
+ fprintf (table, "%d,", types[i].value);
       if (((i + 1) % 20) == 0)
  {
   /* We need \\ for macro.  */
   if (macro)
-    fprintf (table, "\\\n%s", indent);
+    fprintf (table, " \\\n%s", indent);
   else
     fprintf (table, "\n%s", indent);
  }

      parent reply	other threads:[~2014-02-19 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 17:16 Ilya Tocar
2014-02-19 20:12 ` H.J. Lu
2014-02-19 20:56 ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOr20VMkcdQobM+F2Xmi=39NRwUof2rN8rw7GvSQPLkjZQ@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=tocarip.intel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).