From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by sourceware.org (Postfix) with ESMTPS id 6D4FA3860766 for ; Tue, 23 Apr 2024 13:59:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D4FA3860766 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D4FA3860766 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713880766; cv=none; b=SW0cbL3v5qrdstKichhQHL4Y4mOmGL6mofUYC2emOVQAAiYBQPX5ImwoF9kM/crRHCEoDZ1mQ6hl4H0j7qVPXjmjxIiADKlp9/ni+0ALHZbzjwz5112ys1JZhyiYgDrw3XhgRG+xY/Msh/41l2mHq54JddFuE1816S2NS5Pl++I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713880766; c=relaxed/simple; bh=nDXHSy4hlyWb9syIu8+7rCcVoE/MxnTw91lajWc44ig=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=PUjmMl8v8uRLIc0fjp/tM9nG5m2Xzd72cXqhdqB6Lnr5t0niTBLnIBFfXscs4nrQ078sDm9zPzxX0or2d+TxFgGCsuX95eybGHtadqFog9yPOp+QgAkFivJgbrXmjfqCLm8gpbanq3APVNw5SfKsOHyxLlTA3hlchkIdNPvszKo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-61b2218ab6fso39738917b3.1 for ; Tue, 23 Apr 2024 06:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713880764; x=1714485564; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E6L7hxeayTJiJJXeRdoqg0eS0MteQQGGYGX+H39OX90=; b=H/3JYfhLyx2qw+LFAzwzPCTB++7z4cHh/xD+/JaB28r+kpR/+Xo5gZlIhKFtN/8iCi MWURZMVM1OeN3i5QjLsDRPEtemw+uRc+1RJVSzErS3uB37XXwZHaDFZtOUuzHA1/JQYa 4k7NShDVqnNR7v1TGqau7FCsQrzNrzst30ZgdXzmtvjThkk4Ot2MlVcXlOMIUk/lMK2S mSzqV2v4RPaNoOcYfglHrPIrRYe9OSV+s2jjTlUfNyj5V49VE0ecRGuVxf1+yJovs4Cb cEw+o3UsQFAeydJVEscaD9pzFdsSI4GwGLsaBDfcH9prytXHsgqPjnLOGsoXmeF7EG6e cKOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713880764; x=1714485564; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E6L7hxeayTJiJJXeRdoqg0eS0MteQQGGYGX+H39OX90=; b=im1hn0c64v4Gz4vzTrSmIcqYKI4E8n4cVzmwoLPqgFROfOJ32IIVVH/mzZQ3OooVm+ b+13SsLNC/VKaqyo/QdWuwB36zsQTAm+8fFbmEmvit0CBOsbUvWjOHg3lT1wXh7b6Fiq JG8vHs3iU+5ucoHtdgwGVUpC4Ge2Q9uhZKTuiWjL2giIauAGYm92U3Li+18dzF5aHvhC aGTVrkv/7tE7ZNo4BggVpzXJ7uS8g1nsTMtrR0BgQjbiMueBCPRtTWiZGkOmk1t3FyxQ +u+9KvsTx57s1h/aGSp6kzKI1aOBIQcIsIh96yS7ubrutpPD2d7VxGOB0rz5pyYgRniD 6Hww== X-Gm-Message-State: AOJu0YzCXld7iP+5of+HYYcMEd57C8KcyW5VP7QxEGa8xwZQiUkoRjC4 uxrAyUpIzetWo3JUhaN85t5sZ+msFAYAwzK8RmmdgwMM6I6bmU5+cRPXsqgByui7Yv3P0TurhfA KEXhrXmAiHMO10IuzfbKBBt7e9wAq+sZS X-Google-Smtp-Source: AGHT+IFlJApQqQ1D5JQ43ZbpOAor+v6MPGAyVvXk+nT8ISsV6qY6mesvvaYzzXkBp+DEZztnyDQ3OtWWEU+IIawrZwA= X-Received: by 2002:a05:690c:81:b0:611:bdd:4534 with SMTP id be1-20020a05690c008100b006110bdd4534mr14158581ywb.3.1713880763718; Tue, 23 Apr 2024 06:59:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Tue, 23 Apr 2024 06:58:47 -0700 Message-ID: Subject: Re: use copy_private_symbol_data in objcopy To: Alan Modra Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3018.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 23, 2024 at 4:42=E2=80=AFAM Alan Modra wrote= : > > osympp appearing twice here is not a bug. > > PR 14493 > * objcopy.c (copy_object): Run the symbols through > bfd_copy_private_symbol_data. > > diff --git a/binutils/objcopy.c b/binutils/objcopy.c > index d91ba123c01..634ebae3fc3 100644 > --- a/binutils/objcopy.c > +++ b/binutils/objcopy.c > @@ -3380,6 +3380,13 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_= info_type *input_arch) > symcount =3D filter_symbols (ibfd, obfd, osympp, isympp, symcount)= ; > } > > + for (i =3D 0; i < symcount; i++) This failed to compile with GCC 14 on 32-bit hosts: /export/gnu/import/git/sources/binutils-gdb/binutils/objcopy.c: In function =E2=80=98copy_object=E2=80=99: /export/gnu/import/git/sources/binutils-gdb/binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: =E2=80=98unsigned int=E2=80=99 and =E2=80=98long int=E2=80=99 [-Werror=3Dsi= gn-compare] 3383 | for (i =3D 0; i < symcount; i++) | ^ > + if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i])= ) > + { > + status =3D 1; > + return false; > + } > + > if (dhandle !=3D NULL) > { > bool res; > > -- > Alan Modra > Australia Development Lab, IBM --=20 H.J.