public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Richard Henderson <rth@twiddle.net>
Cc: Andreas Krebbel <krebbel@linux.vnet.ibm.com>,
	David Miller <davem@davemloft.net>,
	aj@suse.com, 	libc-alpha@sourceware.org,
	Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] S/390: Fix two issues with the IFUNC optimized mem* routines
Date: Fri, 31 Aug 2012 19:16:00 -0000	[thread overview]
Message-ID: <CAMe9rOr2Vic9vENNbRf5_z22-kMS2Uu-6Lsgd_Xi6bctw6CF4w@mail.gmail.com> (raw)
In-Reply-To: <5040CCC6.4030809@twiddle.net>

On Fri, Aug 31, 2012 at 7:40 AM, Richard Henderson <rth@twiddle.net> wrote:
> On 08/30/2012 06:02 PM, H.J. Lu wrote:
>> @@ -3470,6 +3470,25 @@ elf_i386_relocate_section (bfd *output_bfd,
>
> Don't do these sorts of things in relocate_section.
>
> Do them in relax_section where you still have time
> to remove the got entry if it becomes unused.
>

This is an excellent idea.  But  relax_section is too late for
x86 and x86-64.  I need to do it in size_dynamic_sections
so that we can get proper GOT entries.


-- 
H.J.

  reply	other threads:[~2012-08-31 18:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <503E009B.3080302@linux.vnet.ibm.com>
     [not found] ` <CAMe9rOrmiF3VZOBNvEbMV5jFNog1-_EoPoT9rHTUQFsANaSD8w@mail.gmail.com>
     [not found]   ` <503E3930.5040603@linux.vnet.ibm.com>
     [not found]     ` <20120829.125208.824114683359549094.davem@davemloft.net>
     [not found]       ` <503F14A3.8070801@linux.vnet.ibm.com>
     [not found]         ` <CAMe9rOozW=4q_a=nmNvbZhsXooRZ4opvTTNtq2WHcGSSd2ONOw@mail.gmail.com>
2012-08-31  1:10           ` H.J. Lu
2012-08-31 14:43             ` Richard Henderson
2012-08-31 19:16               ` H.J. Lu [this message]
2012-09-01 16:51                 ` Richard Henderson
2012-09-01 17:22                   ` H.J. Lu
2012-09-01 21:25                     ` Richard Henderson
2012-09-02 14:50                       ` H.J. Lu
2012-09-02 19:41                         ` Richard Henderson
2012-09-02 20:06                           ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOr2Vic9vENNbRf5_z22-kMS2Uu-6Lsgd_Xi6bctw6CF4w@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=aj@suse.com \
    --cc=binutils@sourceware.org \
    --cc=davem@davemloft.net \
    --cc=krebbel@linux.vnet.ibm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).