From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1607 invoked by alias); 31 Aug 2012 18:09:25 -0000 Received: (qmail 1583 invoked by uid 22791); 31 Aug 2012 18:09:24 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 31 Aug 2012 18:09:10 +0000 Received: by vcbfl13 with SMTP id fl13so4078123vcb.0 for ; Fri, 31 Aug 2012 11:09:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.65.10 with SMTP id t10mr6633429ves.48.1346436548988; Fri, 31 Aug 2012 11:09:08 -0700 (PDT) Received: by 10.58.234.39 with HTTP; Fri, 31 Aug 2012 11:09:08 -0700 (PDT) In-Reply-To: <5040CCC6.4030809@twiddle.net> References: <503E009B.3080302@linux.vnet.ibm.com> <503E3930.5040603@linux.vnet.ibm.com> <20120829.125208.824114683359549094.davem@davemloft.net> <503F14A3.8070801@linux.vnet.ibm.com> <5040CCC6.4030809@twiddle.net> Date: Fri, 31 Aug 2012 19:16:00 -0000 Message-ID: Subject: Re: [PATCH] S/390: Fix two issues with the IFUNC optimized mem* routines From: "H.J. Lu" To: Richard Henderson Cc: Andreas Krebbel , David Miller , aj@suse.com, libc-alpha@sourceware.org, Binutils Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00510.txt.bz2 On Fri, Aug 31, 2012 at 7:40 AM, Richard Henderson wrote: > On 08/30/2012 06:02 PM, H.J. Lu wrote: >> @@ -3470,6 +3470,25 @@ elf_i386_relocate_section (bfd *output_bfd, > > Don't do these sorts of things in relocate_section. > > Do them in relax_section where you still have time > to remove the got entry if it becomes unused. > This is an excellent idea. But relax_section is too late for x86 and x86-64. I need to do it in size_dynamic_sections so that we can get proper GOT entries. -- H.J.