From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id DFD5B3858D20 for ; Thu, 27 Jan 2022 02:11:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFD5B3858D20 Received: by mail-pl1-x62b.google.com with SMTP id k17so1295237plk.0 for ; Wed, 26 Jan 2022 18:11:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jm73KsHxwd5wuYSq7U5PeR7KOtYD9W5Zi0jp7m17q88=; b=Z7VedywNneQuIQ8cLZrY0B5VIU1IDWF+fikgh3L8BIaUXEfhSSC4KId2HaINZSU819 O6x9qhy29ob0WxG13ZfbTNuhuCC1HnGEX76WGkA/bZp6VV6uhM6O7or/KV5BkrDSkBme rkSyLHXFdMZovTm8Cb1raMCCVZ7vKrd2M79gTzEI6vQ/G3ehh0+deTZ8qupQRPAL7sgV e7NphRNkKVvyK0BKul3cMWH6t9ph07FSQUMkJk++Z6KKTMFUXXRjDP9ifyHaXANWmnPc diiVpcQ25N9iKQTvUsjkTmbDmO0AHOlbeQ1+hDndB4sBOv1t7FPJeIn8K+eNwnVT/Y7K lj+Q== X-Gm-Message-State: AOAM530oE9OdIgoBEQeX+n//P+opom8T7y2VQ9rnMTWQq/eN0O5lLSMu Ae6Z7IMHz+65JZRgwskeS3EYFrzZ0OFQowQWCwg= X-Google-Smtp-Source: ABdhPJzvbD483XmwBRJPs7oE+Oq3mFfVDBG5kqdO5z0YTo97RXYSEY12XqZvRxNx0hD4xaey/bubIMFCPLiB0v1VYA4= X-Received: by 2002:a17:90b:1b46:: with SMTP id nv6mr11504492pjb.143.1643249463975; Wed, 26 Jan 2022 18:11:03 -0800 (PST) MIME-Version: 1.0 References: <5448901b-167d-4423-c99e-557d8178e56d@redhat.com> <63e7ccbb-a69e-f38e-6e36-778b5fd39ad5@redhat.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 26 Jan 2022 18:10:28 -0800 Message-ID: Subject: Re: [PATCH v4] ld: Rewrite lang_size_relro_segment_1 To: Alan Modra Cc: Nick Clifton , Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3021.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 02:11:06 -0000 On Wed, Jan 26, 2022 at 4:48 PM Alan Modra wrote: > > On Wed, Jan 26, 2022 at 10:55:35AM +0000, Nick Clifton via Binutils wrote: > > Hi H.J. > > > > > Here is the v4 patch to align the PT_GNU_RELRO segment first and subtract > > > the maximum page size if therer is still a 1-page gap. This fixes: > > > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=28819 > > > > Looks good to me. Please apply. Branch and mainline. > > How was this patch tested? If it has not been tested on targets other > than x86 then it is not appropriate for the branch. Instead, I What kinds of tests are you looking for? Do you have a testcase to show there is still an issue? > believe commit 2f83249c13d ought to be reverted on the branch. A > wasted page in memory layout is not an important problem. We have > more serious relro issues on targets other than x86. See pr28824. > > I'm speaking up because I raised concerns over the design of the > previous patch, not just the implementation, and had those concerns > overridden by Nick. Or possibly Nick didn't see my email before the > previous patch was approved. Regardless of how it happened, I fear > we might have even worse relro support in 2.38. > > FWIW, I also think that any fix I might develop for pr28824 will > likely not be release branch quality until is has been tested for some > time on mainline. > > -- > Alan Modra > Australia Development Lab, IBM -- H.J.