From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by sourceware.org (Postfix) with ESMTPS id A42F9385840A for ; Tue, 29 Aug 2023 16:19:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A42F9385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-594f8a7125cso33953117b3.0 for ; Tue, 29 Aug 2023 09:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693325960; x=1693930760; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OJrrZfVpZ79Rv4iHrAkAE87qj/NUrP3DOI0iFh2Zj+c=; b=niso6Pl+n3Zi08lVAdroTTpMiT+qI168w2+JKpymfllxcRHkzqJmPEfn8oTCFsH8S2 uBq4vLVuadTf45Smog80VNeTFRaffEo9eX6eWemmbosMDNc46Ho281m1cPuJArua+j2a dbuvot5DxnqWLCiKHC0F3tVqijcU4tUYvt68AlG9cSPVQulZi8ZTGp9uTRYeMJ6lVKYx k0QN/hR0b4u7hyMapTcPoHIpDJndCqhLB75EsY/Np6Xru/V80f352EP95y9oGQsqXMAP Mct5Vc0W0h6AmrAzjJSD/gFgSLFElMk59wR4QyXsB2psTt/JrXvHDGyd68OtlY+uoIIU iTzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693325960; x=1693930760; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OJrrZfVpZ79Rv4iHrAkAE87qj/NUrP3DOI0iFh2Zj+c=; b=S0EWSW6r8MFy9nuD74R0klqbVOqNdgMhK14tWjHfS1WajJVxMkMIayixsBRCRRBEn1 WIDNt92+kX1os7N9ztGXhYE+FOjyUxtepbEz1CvbfX86ABldht/HT2PyeBsVWVosfoav JzFZtYKrX4EMNEYi76X3+0c/T09CQsv7LLlWvO9GfkUFoGSROzgv7+yf+5t97qd3JFhP JyeHh5hSDtd1dMUYxJv6DerkIISS6ckjfPc8EFdMrFxYr6M5D7u+6eC3ruVKUBxe+Yo2 Fq9C1V6O2NY4pbLjtn5kH29PsHaFkZFcJTryIAj/al6+unDEFNbi6cOzjx/INMP4eIKO ckEg== X-Gm-Message-State: AOJu0Yz6zvjJO2LktUz6GrEJX4FmR30tHXnqXPSh5zJ80ssM0ug+vEek Fjuro9UKV0zvKGDBaOx7YduXGKJa1xLNjUGQbbI= X-Google-Smtp-Source: AGHT+IFMdwwzExWAY0V5p5YT8UT7acE7jrfy5MdCexDt4au7XYr4LYG9bWFmvq/ZzBpnlWYYnKPS3v63BOVmKUSgta4= X-Received: by 2002:a0d:df57:0:b0:584:3f4a:b790 with SMTP id i84-20020a0ddf57000000b005843f4ab790mr29669102ywe.33.1693325959904; Tue, 29 Aug 2023 09:19:19 -0700 (PDT) MIME-Version: 1.0 References: <6f819651-36c0-1c69-8224-fe21f0f96a3f@suse.com> <3dc8a453-eb31-1caa-c003-4bee60bf0863@suse.com> In-Reply-To: <3dc8a453-eb31-1caa-c003-4bee60bf0863@suse.com> From: "H.J. Lu" Date: Tue, 29 Aug 2023 09:18:44 -0700 Message-ID: Subject: Re: [PATCH 3/5] x86: support AVX10.1/512 To: Jan Beulich Cc: "Jiang, Haochen" , Binutils Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3015.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 28, 2023 at 12:09=E2=80=AFAM Jan Beulich wr= ote: > > On 28.08.2023 08:59, Jiang, Haochen wrote: > >> But of course the question remains on whether this is needed in the fi= rst > >> place. Personally I'd favor making AES a prereq of VAES (and PCLMULQDQ= one > >> of VPCLMULQDQ); if we decided to go that route, I'd make that change a > > > > For PCLMULQDQ and VPCLMULQDQ, the imply should be ok. Actually, I have > > added that in GCC in April, but I forgot to check Binutils at that time= : > > > > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommitdiff;h=3D4246611d1915f16= 64c01f286dbeb946dd06e2a4d > > > > For AES/VAES, I am conservative on that at that time because not all th= e insts are > > included in VAES: > > > > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommitdiff;h=3D24a8acc1662c370= 03a7b54814bf840019fec2190 > > > > But I suppose the reason why AESIMC/AESKEYGENASSIST are not included mi= ght > > be one key length is 128 bit while generating/transforming two at the s= ame time > > and putting them into ymm register is not quite needed. > > Plus VAES is going to be of less use without those two insns, so assuming > AES to also be there if VAES is ought to be sufficiently "natural". Yet > as said, it would be quite nice if the SDM could make such "connections" > explicit. > > > I am both ok on whether to imply or not since it would be simple if imp= lied. > > Okay, I'll tentatively add a new prereq patch then, but before posting v2 > I'd like to give H.J. the opportunity to voice an opinion. > I don't think we need to make AVX10 to imply AES and VPCLMULQDQ in assembler. The AES and PCLMULQDQ changes aren't needed. --=20 H.J.