public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 3/4] x86: fold RegXMM/RegYMM/RegZMM into RegSIMD
Date: Fri, 15 Dec 2017 16:28:00 -0000	[thread overview]
Message-ID: <CAMe9rOrB0CkasvSJhtrbhOoQsrQDeJf_18HD88tV0GfDJXT=7A@mail.gmail.com> (raw)
In-Reply-To: <5A33F6DC02000078001219E0@prv-mh.provo.novell.com>

On Fri, Dec 15, 2017 at 8:22 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>>> "H.J. Lu" <hjl.tools@gmail.com> 12/15/17 1:50 PM >>>
>>On Fri, Dec 15, 2017 at 2:34 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> @@ -5930,20 +5958,6 @@ finalize_imm (void)
>>>  }
>>>
>>>  static int
>>> -bad_implicit_operand (int xmm)
>>> -{
>>> -  const char *ireg = xmm ? "xmm0" : "ymm0";
>>> -
>>> -  if (intel_syntax)
>>> -    as_bad (_("the last operand of `%s' must be `%s%s'"),
>>> -           i.tm.name, register_prefix, ireg);
>>> -  else
>>> -    as_bad (_("the first operand of `%s' must be `%s%s'"),
>>> -           i.tm.name, register_prefix, ireg);
>>> -  return 0;
>>> -}
>>> -
>>
>>Will we miss the assembly operand error checking?
>
> Not sure I understand what you mean. As the altered test case shows, error
> messages are still present, just that they don't mention %xmm0 anymore. If
> you mean something else, please explain. But keep in mind that things are
> now more similar to GPR accumulator (i.e. %al etc) or FPU (%st(0)) handling,
> where there is no such problem either. The template now requires %xmm0 to
> be used.

It is hard to tell what the error message is from

*:[0-9]*: Error: .*blendvpd.*

We used to get

The last operand of ....

What do we get now instead?

-- 
H.J.

  reply	other threads:[~2017-12-15 16:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  9:54 [PATCH 0/4] x86: operand handling consolidation Jan Beulich
2017-12-15 10:32 ` [PATCH 1/4] x86: replace Reg8, Reg16, Reg32, and Reg64 Jan Beulich
2017-12-15 12:46   ` H.J. Lu
2017-12-15 10:33 ` [PATCH 2/4] x86: drop FloatReg and FloatAcc Jan Beulich
2017-12-15 12:47   ` H.J. Lu
2017-12-15 10:34 ` [PATCH 3/4] x86: fold RegXMM/RegYMM/RegZMM into RegSIMD Jan Beulich
2017-12-15 12:50   ` H.J. Lu
2017-12-15 16:22     ` Jan Beulich
2017-12-15 16:28       ` H.J. Lu [this message]
2017-12-15 16:36         ` Jan Beulich
2017-12-15 16:41           ` H.J. Lu
2017-12-15 10:35 ` [PATCH 4/4] x86: fold certain AVX and AVX2 templates Jan Beulich
2017-12-15 13:10   ` H.J. Lu
2017-12-15 16:32     ` Jan Beulich
2017-12-15 16:49       ` H.J. Lu
2017-12-21 10:07   ` Jan Beulich
2017-12-22  8:54   ` Alan Modra
2018-01-02 10:49     ` Jan Beulich
2017-12-18  8:03 ` [PATCH 5/4] x86: helper changes to i386-gen.c Jan Beulich
2017-12-18 11:25   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOrB0CkasvSJhtrbhOoQsrQDeJf_18HD88tV0GfDJXT=7A@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).