From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id F1CB93853D75 for ; Thu, 17 Nov 2022 17:07:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F1CB93853D75 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62f.google.com with SMTP id t25so6628239ejb.8 for ; Thu, 17 Nov 2022 09:07:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6vfvhTuoONZm11OsnALWG5pk9iWsmaeCcQ88+2KiwVA=; b=INITdNTCtYu1BtplmzPp7wyfm5oIO/DW3xDO/erlZR1d/M2YKnB+rIXx8rN0HbEbWh OeR3kLVFD0hNxI8vVDk9bWshZEREOnkG4tqCVOtgDUowkx5BHXuztufPb2FY/CaWD++t Cce9qsCJ/PJFfcGMW6xhW9dxEQTcQlumpbzg1mXfA4jG2PSRdPU1mW8WV1MZQqsYA4Zz 0N7rto7dMdDYPr8XYoAq1ITP8vCPBQUOT6eqRjtGJe1tfHB60UfcFbJD3NQU/e8K3btH 9GO64ly+GI5KWrHY8+gSJmu9zLj4iuRciX/YREvsdmb/ZhXZ3vKvKpZl83Gr3oB3bb9E w07Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6vfvhTuoONZm11OsnALWG5pk9iWsmaeCcQ88+2KiwVA=; b=cec9ijpOiayxgKsF5btxhFYcy8ZG32R3vf2YPPAvX7wBK25xAtibAe76mRu1g/YyQ2 9CH8qY9aY0INj/gcBRVeiLbRizDdTyZ3VB6sc4HBievLaM56W78+RUgQoaW32mAl8CiT sVubiHp+DTlc0JyYlP3K/MuSWRHXJuuStvgugXutNiDDYNbTvFeqAnV5s+L1ud7QpyXW iOyEFiC3EZLVZOM4FS6zhPwy4/Y9KnyNxp5Y3X+S1OBlGp7DtUYpxFPxg8CmpVWUF/7r aZY70kFti+XWKNWyCEdHIOFdLS9RNWLVv0ETlKEir/VqQrnzn2g0GDfxVKEyzwbbR0SO uGAA== X-Gm-Message-State: ANoB5plsJgH5wGq4ETnSVS1qnGLkIJe/B5AKEo6ga5RfV3e5SjtMJvR6 +SA4YnOH1Qhs8GDbOZPY2ADWhxEw1hkZLiT7TCQ= X-Google-Smtp-Source: AA0mqf7SXsAc9wfM0bKt72WeMUl7RKXEsX7Q7wheY3nmobJ/8ZXX5YZLkMIZnOdNcXAzYTrprFZR4W/Eik3mgoOcTbc= X-Received: by 2002:a17:906:6b95:b0:781:e01e:951f with SMTP id l21-20020a1709066b9500b00781e01e951fmr3017969ejr.283.1668704865785; Thu, 17 Nov 2022 09:07:45 -0800 (PST) MIME-Version: 1.0 References: <5c07cdb4-ec26-c7bf-087a-4d0c75ef8549@suse.com> <1d94f66d-eb94-d148-0b7d-f4de8c3873e2@suse.com> <7593a96c-6895-9636-22ef-0a18bd5e5d1b@suse.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 17 Nov 2022 09:07:07 -0800 Message-ID: Subject: Re: [PATCH 2/2] x86: break gas dependency on libopcodes To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 17, 2022 at 9:01 AM H.J. Lu wrote: > > On Thu, Nov 17, 2022 at 8:59 AM Jan Beulich wrote: > > > > On 17.11.2022 17:55, H.J. Lu wrote: > > > On Thu, Nov 17, 2022 at 8:53 AM Jan Beulich wrote: > > >> > > >> On 17.11.2022 17:48, H.J. Lu wrote: > > >>> On Thu, Nov 17, 2022 at 5:29 AM Jan Beulich wrote: > > >>>> --- a/gas/configure.ac > > >>>> +++ b/gas/configure.ac > > >>>> @@ -420,7 +420,7 @@ changequote([,])dnl > > >>>> > > >>>> # Do we need the opcodes library? > > >>>> case ${cpu_type} in > > >>>> - vax | tic30) > > >>>> + vax | tic30 | i386) > > >>>> ;; > > >>> > > >>> This change isn't needed to move i386_seg_prefixes to gas. > > >> > > >> Correct, but it is needed to fulfill the purpose of the patch as per > > >> its title. Otherwise an unused NEEDED entry remains in gas'es .dynamic. > > > > > > This patch should be a standalone patch. > > > > I'll split, but I'm nevertheless curious as to why: With it in a separate > > It should be the first patch, not the last. I checked in a patch to move it. > > patch, there'll be an intermediate bogus state - gas will require > > libopcodes.so for no reason. Personally I'd consider such a (minor) bug. > > > > Jan > > > > -- > H.J. -- H.J.