From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 5B5F3385703B for ; Wed, 16 Dec 2020 14:49:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B5F3385703B Received: by mail-oi1-x231.google.com with SMTP id x13so18713245oic.5 for ; Wed, 16 Dec 2020 06:49:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2t4sRuZfDa43Wi84goMHBJUh6UzQCh8sM247V74zysw=; b=e0DqF1AauxdHQcHpDq+lSn034RT+BMGiZshgncxKZ90gK8z3BPukqPNsHnmF0tjm8M KOcJVGDPh32Put7KoUaDWg/9vvlQoXD1cCiTMPgJfZPhvkqjQGQEStJ1kPBgdvVr4R6W XCcASgw0MA1kjDFouCgMjf+TEdIKkopNnXvEYTIuaZO8GhpZWS3ky8Zid3jBRF6Hl/wO BYno70gsmlGZWHhVmsoKm6qXF3LYGNQiSiKiMukcRk+pVO30KenJD6Ih5sCme8w6H8EH KrSGCkq0iu3tJjwxHLQTjja7LrT6y/5TKCBQO2oJsrPDCb6a5WghirhzFflI2vULbDtB wttA== X-Gm-Message-State: AOAM533C11ThpmTqT5Km8E013kM4vIQvAbOz7YKB/jh5qli9eKkFkbWx 1UNYyJV7nCkJEbtxIy2vRtVPW/zSC+EG1bupZcs= X-Google-Smtp-Source: ABdhPJw9zPVm24fNQE2r3/mfxrZKzs+l46Mp1UkmGyJEJkstUm8TliF+/YZQRSZewmdgAy99sFSDKcQ6yvGhzrGHWwU= X-Received: by 2002:aca:f456:: with SMTP id s83mr2210837oih.58.1608130193780; Wed, 16 Dec 2020 06:49:53 -0800 (PST) MIME-Version: 1.0 References: <53b8973b-40a4-2550-3307-66d7f13707d5@symas.com> <31f9062e-175d-06e9-695a-797c7ee11420@symas.com> <58620dc1-3bb9-aaae-b476-ebb613ecb627@redhat.com> <1aaf4429-074c-7912-e6e6-4d2f82d6ef10@redhat.com> <7b118db2-9502-c45e-9f47-6b6f6a5f9646@symas.com> <7dba4046-3d50-c7e6-915d-08bf590bf057@redhat.com> <7b124cd4-529b-0069-3044-9d733a4e4e5c@symas.com> <20ad87a3-283d-7e49-9c2e-ed13001f6c87@symas.com> <70139665-0b8c-63dc-3a9d-b24a25bd8122@redhat.com> <2475d2a6-c63e-6dac-0f56-fa9acb6f20de@symas.com> <0e9925e6-512b-0ed6-8846-a86a40fb0a47@redhat.com> <3bfc2ea0-d49d-a194-18e0-57c007fd3746@redhat.com> <7ce0403d-00ac-d853-3af8-c612a6eaa1d0@redhat.com> In-Reply-To: <7ce0403d-00ac-d853-3af8-c612a6eaa1d0@redhat.com> From: "H.J. Lu" Date: Wed, 16 Dec 2020 06:49:17 -0800 Message-ID: Subject: [PATCH] ld: Call plugin hooks only if they are available To: Nick Clifton Cc: Howard Chu , Cary Coutant , Binutils Content-Type: multipart/mixed; boundary="000000000000f417d205b695fce7" X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2020 14:49:55 -0000 --000000000000f417d205b695fce7 Content-Type: text/plain; charset="UTF-8" On Wed, Dec 16, 2020 at 3:16 AM Nick Clifton via Binutils wrote: > > Hi Howard, > > >> Why not just make the new plugin disable itself if the host tool > >> doesn't provide the all_symbols_read entry point? > > > > Yeah, that'd be fine too. Just noop/silently exit if entry points are missing. > > I can write that up if folks agree it's better. > > Please do. > > It turns out that my proposed fix breaks the LTO plugin, so it is a no-go. :-( > I am going to check this in if there are no objections today. -- H.J. --000000000000f417d205b695fce7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ld-Call-plugin-hooks-only-if-they-are-available.patch" Content-Disposition: attachment; filename="0001-ld-Call-plugin-hooks-only-if-they-are-available.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kirj54il0 RnJvbSAzMmY3M2VhOTk1NWJjNGRkYWE4M2ZkNTQ3N2U3NjE5NmRjNGNkYjk2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFdlZCwgMTYgRGVjIDIwMjAgMDY6MjI6NDYgLTA4MDAKU3ViamVjdDogW1BBVENIXSBsZDogQ2Fs bCBwbHVnaW4gaG9va3Mgb25seSBpZiB0aGV5IGFyZSBhdmFpbGFibGUKCkNhbGwgdHZfcmVnaXN0 ZXJfYWxsX3N5bWJvbHNfcmVhZCBhbmQgdHZfcmVnaXN0ZXJfY2xlYW51cCBvbmx5IGlmIHRoZXkK YXJlIHNldC4KCglQUiBsZC8yNzA4MQoJKiBsaWJkZXBfcGx1Z2luLmMgKG9ubG9hZCk6IENhbGwg dHZfcmVnaXN0ZXJfYWxsX3N5bWJvbHNfcmVhZAoJYW5kIHR2X3JlZ2lzdGVyX2NsZWFudXAgb25s eSBpZiB0aGV5IGFyZSBzZXQuCgkqIHRlc3RzdWl0ZS9jb25maWcvZGVmYXVsdC5leHAgKGRlcF9w bHVnX29wdCk6IE5ldy4KCSogdGVzdHN1aXRlL2xkLWVsZi9lbGYuZXhwOiBQYXNzICRkZXBfcGx1 Z19vcHQgdG8gbm0uCgkqIHRlc3RzdWl0ZS9sZC1lbGYvcHIyNjM5MS5mZDogTmV3IGZpbGUuCi0t LQogbGQvbGliZGVwX3BsdWdpbi5jICAgICAgICAgICAgICB8IDE4ICsrKystLS0tLS0tLS0tLS0t LQogbGQvdGVzdHN1aXRlL2NvbmZpZy9kZWZhdWx0LmV4cCB8ICA4ICsrKysrKysrCiBsZC90ZXN0 c3VpdGUvbGQtZWxmL2VsZi5leHAgICAgIHwgIDUgKysrKy0KIGxkL3Rlc3RzdWl0ZS9sZC1lbGYv cHIyNjM5MS5mZCAgfCAgNCArKysrCiA0IGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyks IDE1IGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGxkL3Rlc3RzdWl0ZS9sZC1lbGYv cHIyNjM5MS5mZAoKZGlmZiAtLWdpdCBhL2xkL2xpYmRlcF9wbHVnaW4uYyBiL2xkL2xpYmRlcF9w bHVnaW4uYwppbmRleCAyYTdmZGM0ZDBiLi4zN2FkN2M3Zjk3IDEwMDY0NAotLS0gYS9sZC9saWJk ZXBfcGx1Z2luLmMKKysrIGIvbGQvbGliZGVwX3BsdWdpbi5jCkBAIC0zNDYsMjAgKzM0NiwxMCBA QCBvbmxvYWQgKHN0cnVjdCBsZF9wbHVnaW5fdHYgKnR2KQogICAgICAgcmV0dXJuIExEUFNfRVJS OwogICAgIH0KICAgKCp0dl9yZWdpc3Rlcl9jbGFpbV9maWxlKSAob25jbGFpbV9maWxlKTsKLSAg aWYgKCF0dl9yZWdpc3Rlcl9hbGxfc3ltYm9sc19yZWFkKQotICAgIHsKLSAgICAgIFRWX01FU1NB R0UgKExEUExfRkFUQUwsICJObyByZWdpc3Rlcl9hbGxfc3ltYm9sc19yZWFkIGhvb2siKTsKLSAg ICAgIGZmbHVzaCAoTlVMTCk7Ci0gICAgICByZXR1cm4gTERQU19FUlI7Ci0gICAgfQotICAoKnR2 X3JlZ2lzdGVyX2FsbF9zeW1ib2xzX3JlYWQpIChvbmFsbF9zeW1ib2xzX3JlYWQpOwotICBpZiAo IXR2X3JlZ2lzdGVyX2NsZWFudXApCi0gICAgewotICAgICAgVFZfTUVTU0FHRSAoTERQTF9GQVRB TCwgIk5vIHJlZ2lzdGVyX2NsZWFudXAgaG9vayIpOwotICAgICAgZmZsdXNoIChOVUxMKTsKLSAg ICAgIHJldHVybiBMRFBTX0VSUjsKLSAgICB9Ci0gICgqdHZfcmVnaXN0ZXJfY2xlYW51cCkgKG9u Y2xlYW51cCk7CisgIGlmICh0dl9yZWdpc3Rlcl9hbGxfc3ltYm9sc19yZWFkKQorICAgICgqdHZf cmVnaXN0ZXJfYWxsX3N5bWJvbHNfcmVhZCkgKG9uYWxsX3N5bWJvbHNfcmVhZCk7CisgIGlmICh0 dl9yZWdpc3Rlcl9jbGVhbnVwKQorICAgICgqdHZfcmVnaXN0ZXJfY2xlYW51cCkgKG9uY2xlYW51 cCk7CiAgIGZmbHVzaCAoTlVMTCk7CiAgIHJldHVybiBMRFBTX09LOwogfQpkaWZmIC0tZ2l0IGEv bGQvdGVzdHN1aXRlL2NvbmZpZy9kZWZhdWx0LmV4cCBiL2xkL3Rlc3RzdWl0ZS9jb25maWcvZGVm YXVsdC5leHAKaW5kZXggZjcxMWZiNzkyZS4uYThhZDFmZGI2ZiAxMDA2NDQKLS0tIGEvbGQvdGVz dHN1aXRlL2NvbmZpZy9kZWZhdWx0LmV4cAorKysgYi9sZC90ZXN0c3VpdGUvY29uZmlnL2RlZmF1 bHQuZXhwCkBAIC00NDMsMyArNDQzLDExIEBAIGlmIHsgW2NoZWNrX2NvbXBpbGVyX2F2YWlsYWJs ZV0gfSB7CiAJfQogICAgIH0KIH0KKworaWYge1tmaWxlIGV4aXN0cyAubGlicy9saWJkZXAuc29d fSB7CisgIHNldCBkZXBfcGx1Z19vcHQgIi0tcGx1Z2luIC5saWJzL2xpYmRlcC5zbyIKK30gZWxz ZWlmIHtbZmlsZSBleGlzdHMgLmxpYnMvbGliZGVwLmRsbF19IHsKKyAgc2V0IGRlcF9wbHVnX29w dCAiLS1wbHVnaW4gLmxpYnMvbGliZGVwLmRsbCIKK30gZWxzZSB7CisgICAgc2V0IGRlcF9wbHVn X29wdCAiIgorfQpkaWZmIC0tZ2l0IGEvbGQvdGVzdHN1aXRlL2xkLWVsZi9lbGYuZXhwIGIvbGQv dGVzdHN1aXRlL2xkLWVsZi9lbGYuZXhwCmluZGV4IGUwOGE2ZjVmZWIuLmE1OGIxN2I1MTIgMTAw NjQ0Ci0tLSBhL2xkL3Rlc3RzdWl0ZS9sZC1lbGYvZWxmLmV4cAorKysgYi9sZC90ZXN0c3VpdGUv bGQtZWxmL2VsZi5leHAKQEAgLTQxNSw3ICs0MTUsMTAgQEAgcnVuX2xkX2xpbmtfdGVzdHMgW2xp c3QgXAogCSIiIFwKIAkiIiBcCiAJe3ByMjYzOTFhLmMgcHIyNjM5MWIuYyBwcjI2MzkxYy5jIHBy MjYzOTFkLmN9IFwKLQl7e25tICIiIHByMjYzOTEubmR9fSBcCisJW2xpc3QgXAorCSAgICBbbGlz dCAibm0iICIkZGVwX3BsdWdfb3B0IiAicHIyNjM5MS5uZCJdIFwKKwkgICAgW2xpc3QgIm5tIiAi JGRlcF9wbHVnX29wdCIgInByMjYzOTEuZmQiXSBcCisJXSBcCiAJInByMjYzOTEtNS5vIiBcCiAJ Ii1mbm8tZnVuY3Rpb24tc2VjdGlvbnMiIFwKICAgICBdIFwKZGlmZiAtLWdpdCBhL2xkL3Rlc3Rz dWl0ZS9sZC1lbGYvcHIyNjM5MS5mZCBiL2xkL3Rlc3RzdWl0ZS9sZC1lbGYvcHIyNjM5MS5mZApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi4xOTIxY2Q2YzcwCi0tLSAvZGV2 L251bGwKKysrIGIvbGQvdGVzdHN1aXRlL2xkLWVsZi9wcjI2MzkxLmZkCkBAIC0wLDAgKzEsNCBA QAorI2ZhaWxpZgorIy4uLgorYmZkIHBsdWdpbjogTm8gcmVnaXN0ZXJfYWxsX3N5bWJvbHNfcmVh ZCBob29rCisjLi4uCi0tIAoyLjI5LjIKCg== --000000000000f417d205b695fce7--