From: "H.J. Lu" <hjl.tools@gmail.com>
To: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>,
Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] Cleanup mnemonicendp in swap_operand()
Date: Fri, 17 Dec 2021 17:56:18 -0800 [thread overview]
Message-ID: <CAMe9rOrF+TZrqQb1Seg0vHUhaDztjYTuA9TW5VqX+LfOOPUu7w@mail.gmail.com> (raw)
In-Reply-To: <2e2351bf-3737-7520-ed87-3ffacc0eb8f7@oracle.com>
On Fri, Dec 17, 2021 at 4:42 PM Vladimir Mezentsev
<vladimir.mezentsev@oracle.com> wrote:
>
>
>
> On 12/17/21 15:37, H.J. Lu wrote:
>
> On Fri, Dec 17, 2021 at 3:27 PM Vladimir Mezentsev via Binutils
> <binutils@sourceware.org> wrote:
>
> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> Tested on x86_64-pc-linux-gnu.
>
> opcodes/ChangeLog:
> 2021-12-17 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> * opcodes/i386-dis.c (swap_operand): Cleanup mnemonicendp
>
> This description isn't very clear. How about "Terminate mnemonicendp"?
>
>
> Ok to me.
>
> OK with this change.
>
>
> Thank you.
>
> What should be my next step ?
> I can fix a commit message ( to use "Terminate mnemonicendp" instead "Cleanup mnemonicendp") and resend a patch.
> Or someone else (who will apply my fixes) might change this.
>
>
> -Vladimir
>
I pushed it for you.
--
H.J.
prev parent reply other threads:[~2021-12-18 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 23:26 vladimir.mezentsev
2021-12-17 23:37 ` H.J. Lu
[not found] ` <2e2351bf-3737-7520-ed87-3ffacc0eb8f7@oracle.com>
2021-12-18 1:56 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOrF+TZrqQb1Seg0vHUhaDztjYTuA9TW5VqX+LfOOPUu7w@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=vladimir.mezentsev@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).