From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com
 [IPv6:2607:f8b0:4864:20::1035])
 by sourceware.org (Postfix) with ESMTPS id B362B3858407
 for <binutils@sourceware.org>; Sat, 18 Dec 2021 01:56:55 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B362B3858407
Received: by mail-pj1-x1035.google.com with SMTP id gj24so3808625pjb.0
 for <binutils@sourceware.org>; Fri, 17 Dec 2021 17:56:55 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=He69qq4X1LqWOeeJExe+4yC0v4EITznis1mR9qC1JZc=;
 b=yKHJZ7Dgo+xTNNHjg71rPY/CBEiSHXCOy//A4RHy+smWO8RToB7/TzLYa28refaICj
 IRNyApIWhFC2Z2Jpll88EDbPOWAala/SD/htpdHSsRY+3xC0FaqM9f1OIxYUIIQtiJ0G
 kYZ5vq1ZMjUaNPWg9TDQwJzyP5/+L/zABAer1At+mzUzy52X2yQ4WCuN0lZIlayNZBMk
 aQvM9IEnPj1kKfbO0S/D0kQZ4/e8eTpnwzNdCCxWz+HfAWREVoxVFk5qw1tu2kS8EGnv
 Cp/NTMeyMsS9+6i0+IwoAjfr4GoxInsvIAFxBCHdqz1JA/YUTz3dlKzVDHXMo1c22MAz
 vI9A==
X-Gm-Message-State: AOAM533kGs6rAvpdD7CZ3U01rjVPiqtSxGaF9sUMUTf6ksPKq0fJ03mU
 grV69R5zKgzzFOgo4fMUc24gzUFCiqcU8O6jwTQCgBqR
X-Google-Smtp-Source: ABdhPJxVC+BE5hcZzmy4Pz+YU9MKpPMYS5U0AQ19laRhERnd4k06Uom4vxdp3x/RFEaxlVl3bjgJoUkWNNQKIpJZL5o=
X-Received: by 2002:a17:90a:74f:: with SMTP id
 s15mr2445930pje.120.1639792614710; 
 Fri, 17 Dec 2021 17:56:54 -0800 (PST)
MIME-Version: 1.0
References: <20211217232654.1587021-1-vladimir.mezentsev@oracle.com>
 <CAMe9rOqccnQkaWWHA4GzK9iHEEmCOYEGcpzD8ZeHy9Ym6Tqoog@mail.gmail.com>
 <2e2351bf-3737-7520-ed87-3ffacc0eb8f7@oracle.com>
In-Reply-To: <2e2351bf-3737-7520-ed87-3ffacc0eb8f7@oracle.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Fri, 17 Dec 2021 17:56:18 -0800
Message-ID: <CAMe9rOrF+TZrqQb1Seg0vHUhaDztjYTuA9TW5VqX+LfOOPUu7w@mail.gmail.com>
Subject: Re: [PATCH] Cleanup mnemonicendp in swap_operand()
To: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>,
 Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2021 01:56:57 -0000

On Fri, Dec 17, 2021 at 4:42 PM Vladimir Mezentsev
<vladimir.mezentsev@oracle.com> wrote:
>
>
>
> On 12/17/21 15:37, H.J. Lu wrote:
>
> On Fri, Dec 17, 2021 at 3:27 PM Vladimir Mezentsev via Binutils
> <binutils@sourceware.org> wrote:
>
> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> Tested on x86_64-pc-linux-gnu.
>
> opcodes/ChangeLog:
> 2021-12-17 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
>         * opcodes/i386-dis.c (swap_operand): Cleanup mnemonicendp
>
> This description isn't very clear.  How about "Terminate mnemonicendp"?
>
>
>   Ok to me.
>
> OK with this change.
>
>
> Thank you.
>
> What should be my next step ?
> I can fix a commit message ( to use  "Terminate mnemonicendp" instead "Cleanup mnemonicendp") and resend a patch.
> Or someone else (who will apply my fixes) might change this.
>
>
> -Vladimir
>

I pushed it for you.

-- 
H.J.