From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27880 invoked by alias); 25 Feb 2014 16:03:04 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 27855 invoked by uid 89); 25 Feb 2014 16:03:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f52.google.com Received: from mail-oa0-f52.google.com (HELO mail-oa0-f52.google.com) (209.85.219.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 25 Feb 2014 16:03:02 +0000 Received: by mail-oa0-f52.google.com with SMTP id i4so604773oah.39 for ; Tue, 25 Feb 2014 08:03:00 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.60.174.77 with SMTP id bq13mr2024810oec.0.1393344180218; Tue, 25 Feb 2014 08:03:00 -0800 (PST) Received: by 10.76.151.164 with HTTP; Tue, 25 Feb 2014 08:03:00 -0800 (PST) In-Reply-To: References: <20140220151936.GA1312@msticlxl7.ims.intel.com> <20140224132223.GA39232@msticlxl7.ims.intel.com> <20140225094128.GB31394@msticlxl7.ims.intel.com> Date: Tue, 25 Feb 2014 16:03:00 -0000 Message-ID: Subject: Re: [PATCH, i386][3/3] Update to match latest AVX512 spec. From: "H.J. Lu" To: Ilya Tocar Cc: Binutils Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00146.txt.bz2 On Tue, Feb 25, 2014 at 7:54 AM, H.J. Lu wrote: > On Tue, Feb 25, 2014 at 1:41 AM, Ilya Tocar wrote: >> On 24 Feb 08:30, H.J. Lu wrote: >>> On Mon, Feb 24, 2014 at 5:22 AM, Ilya Tocar wrote: >>> > Hi, >>> > >>> > Currently support version of vctps2ph with sae and only 1 register >>> ^^^^^^^^^^^^^^ Please fix >>> commit log. It should be vcvtps2ph. >> Fixed. >>> > operand. This version is encoded as if missing operand was equal to >>> > ymm0. I didn't found any references to this variant in >>> > http://download-software.intel.com/sites/default/files/managed/50/1a/319433-018.pdf >>> > Attached patch removes it. Testing passes. Ok for trunk? >>> >>> vcvtps2ph supports memory destination. Please add AVX512F testcases >>> with memory destination. >>> >> We already have such tests. See e. g. on lines 6883-6890 in >> gas/testsuite/gas/i386/avx512f.s we have: >> >> vcvtps2ph $0xab, %zmm6, (%ecx) # AVX512F >> vcvtps2ph $0xab, %zmm6, (%ecx){%k7} # AVX512F >> vcvtps2ph $123, %zmm6, (%ecx) # AVX512F >> vcvtps2ph $123, %zmm6, -123456(%esp,%esi,8) # AVX512F >> vcvtps2ph $123, %zmm6, 4064(%edx) # AVX512F Disp8 >> vcvtps2ph $123, %zmm6, 4096(%edx) # AVX512F >> vcvtps2ph $123, %zmm6, -4096(%edx) # AVX512F Disp8 >> >> Do we need additional tests? > > Yes, please test with memory destination for: > > vcvtps2ph, 3, 0x661D, None, 1, CpuAVX512F, > Modrm|EVex=1|Masking=2|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE, > { Imm8, Imm8, RegZMM|RegMem } Also for vcvtps2ph, 4, 0x661D, None, 1, CpuAVX512F, Modrm|EVex=1|Masking=3|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE, { Imm8, Imm8, RegZMM, RegYMM|RegMem } -- H.J.