From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id EE28F385768D for ; Mon, 31 Oct 2022 16:31:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE28F385768D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12c.google.com with SMTP id p8so20016050lfu.11 for ; Mon, 31 Oct 2022 09:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nT7/aWdj0bcg8pQhyI+I5Ek43XLL/dMQyhafnDyor1w=; b=SK5hk9ahEzWU1doRnK7viTilpyU9hqq9y1eic+itw4wOm40QOiypvyUiaO02HTvV1S 5dZxXNDueb8jxEVz/N0CnCzZ6TvrQcdJ0zw58VzTGzQEvyyrFNdffcgu9WuyNyjgZHRo 25tZehLv4v3XlVHgMYnjBf6ij5+Vn4hv0cdr/wDQwOb76oPSk8zzEawQv5XRKLXWFK/c wQk/r1OhSSW7XgdpTWD9F9qvGsmNfYsT9mxNA74J1aaB+fSZiwQB3+2JI5NfHZdDPN2i tZkaJGrVwrgqie92+/GB00SeFEg7W9gt+oZazlRT8cdiQxM9aYi37WfNN0oYirGXn+QV gnAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nT7/aWdj0bcg8pQhyI+I5Ek43XLL/dMQyhafnDyor1w=; b=ZCppYF39QfYuWJplHxoxNl2XFnnqtu1YrFoKIPD0jVyHCznAxm8SCAmUwdQTOnJ9Xd P9CICrBewsBm3dSvuz7PYSTPUkcdTxTxOunmSqAice7SS3CqpPp+drIsOvGEnsOqMOGr X40TaXB5/qozNJOs0y/B+rOSZ+r2ZUgsYVmVcuF0cua+RwesYSZpkei09cio4n4ft932 e6a6h0P8UB27OPG9JdlTJeGG6gpeAPHO9saCDm0kUS+mykouz48Tpg9qBJQ3VQqKbYj/ 4cvb4/9AnqGN8jEOJ78UWItlGAXO2MaeZ6pfECjMPmVJWmitFQt0T6aLOp9bsIlqBT8d yu9w== X-Gm-Message-State: ACrzQf1CgxRbsnlmACP734TiDyGdySpzzZvVI8mCY9QCzfKWkQZhQomS 9VfpSBlFVCLDNYsbtOSTs3NQi2CcI0rF+jiHYsgIl3QZ X-Google-Smtp-Source: AMsMyM5J6+pfGC0ZF+YMfbqVf/X+wPYs3h4x32U7c+RW89pyTVbyDE5Xx0chnl44PNQriPMirdKfP3/5GZIhF0Z8rjA= X-Received: by 2002:a19:e009:0:b0:4b0:f376:2264 with SMTP id x9-20020a19e009000000b004b0f3762264mr545865lfg.144.1667233865478; Mon, 31 Oct 2022 09:31:05 -0700 (PDT) MIME-Version: 1.0 References: <20221031060601.38460-1-haochen.jiang@intel.com> <20221031060601.38460-2-haochen.jiang@intel.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 31 Oct 2022 09:30:29 -0700 Message-ID: Subject: Re: [PATCH 1/2] i386: Add and To: Jan Beulich Cc: Haochen Jiang , konglin1 , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 31, 2022 at 2:04 AM Jan Beulich wrote: > > On 31.10.2022 07:06, Haochen Jiang wrote: > > From: konglin1 > > > > opcodes/ > > * i386-opc.tbl: Add for VEX insn with x/y suffix, > > and for EVEX insn with x/y suffix. > > Code change looks good (and thanks for splitting it off), but the changelog > entry wants to use "rename" instead of "add", not the least to also mention Agreed. > the identifier which goes away. However, this kind of a change is where > personally I think the legacy changelog model is quite a bit worse than > the modern one with a proper textual commit message. > I prefer concise and accurate ChangeLog entries. It is easier to tell what the changes are. -- H.J.