From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15375 invoked by alias); 25 Apr 2016 16:03:19 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 15358 invoked by uid 89); 25 Apr 2016 16:03:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=mandatory, our X-HELO: mail-qk0-f173.google.com Received: from mail-qk0-f173.google.com (HELO mail-qk0-f173.google.com) (209.85.220.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 25 Apr 2016 16:03:08 +0000 Received: by mail-qk0-f173.google.com with SMTP id q76so48865211qke.2 for ; Mon, 25 Apr 2016 09:03:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=0uE4RjTtMsg9ZeBULTCWsmDzgXfZewe4QSv+u/SH6pw=; b=luC2ntPQf3a1wDI65pUNEYvSq0dTE0bX31GnC4Dbvf+LaanEWl9ivKA9832sKK5BQC DNWdOgroYdy2/ZDai7T8GlrSO7HANPv/YKgHH7g0jHx80E3j6XgPuqNoXNQELK/+ETy5 RUWDexryawUyCuyAyQoqQg+JQiQZuBfAGNXva+08IyvDgnmPc0psjXMRQBaiAf1jOKpv 8H4k9vP+ad6LdvjkbUi3o+Dl7Sh13C873V0/aL2z+2igoC5Xg67SSmEhXqCvGbV1daJS qFHWP2J3TS7fsMHKw1Nm2mU8NPCJByJ4BTcLFaHbIdfy0w9weoiOjilD6fnDDxKxItRn 11Vw== X-Gm-Message-State: AOPr4FVXUwedHgCO8e1xII9Ct5bRr6/0Dmo1etmHiNEiGhBQqu5Cgh2eJdP+nCcRvndFxIoJdPcIRpGjd068Bg== MIME-Version: 1.0 X-Received: by 10.55.146.199 with SMTP id u190mr19285388qkd.174.1461600186387; Mon, 25 Apr 2016 09:03:06 -0700 (PDT) Received: by 10.55.217.134 with HTTP; Mon, 25 Apr 2016 09:03:06 -0700 (PDT) In-Reply-To: <20160425134106.GI27353@bubble.grove.modra.org> References: <571AD1EE.1040005@imgtec.com> <571ADE8F.9000000@imgtec.com> <571B93C6.5030007@imgtec.com> <571BCC3A.6090700@imgtec.com> <571D7E59.4040802@imgtec.com> <20160425134106.GI27353@bubble.grove.modra.org> Date: Mon, 25 Apr 2016 16:03:00 -0000 Message-ID: Subject: Re: [committed, PATCH] Always create dynsym section with dynamic sections From: "H.J. Lu" To: Alan Modra Cc: Faraz Shahbazker , Binutils Content-Type: multipart/mixed; boundary=94eb2c08bd70ea08650531514fa7 X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00416.txt.bz2 --94eb2c08bd70ea08650531514fa7 Content-Type: text/plain; charset=UTF-8 Content-length: 1279 On Mon, Apr 25, 2016 at 6:41 AM, Alan Modra wrote: > On Mon, Apr 25, 2016 at 05:47:15AM -0700, H.J. Lu wrote: >> On Sun, Apr 24, 2016 at 7:18 PM, Faraz Shahbazker >> wrote: >> > On 04/23/16 18:42, H.J. Lu wrote: >> >> Here is a patch. Does it work for you? >> > Yes, this works. >> > >> >> Any other comments, feedbacks for my patch? > > I think you'd better look at all places that test dynsymcount. For > instance, bfd_elf_size_dynsym_hash_dynstr. I checked. They look OK. > This should really have been done when you committed > https://sourceware.org/ml/binutils/2016-02/msg00326.html and that > patch should have explained why the change was made. "We should > always create the dynsym section, even if it is empty, with dynamic > sections" doesn't explain anything about why the change was made. In > fact, the explanation for the patch was no better than "We should do > what this patch does". The issue is some dynamic tags (sections) are mandatory in .dynamic section even if they are empty. MIPS backend use dynsymcount, which is intended for the mandatory DT_SYMTAB (.dynsym section), to build static executable, which doesn't have dynamic section. Here is the updated patch. Is it OK for master? -- H.J. --94eb2c08bd70ea08650531514fa7 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Always-count-the-NULL-entry-in-dynamic-symbol-table.patch" Content-Disposition: attachment; filename="0001-Always-count-the-NULL-entry-in-dynamic-symbol-table.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ing6zida0 Content-length: 3006 RnJvbSA4ZDk0MWIzZjk5YTU3Zjg5ZjU2NGVkMTZmOTRkNWNkY2FkNmZlZGUz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IFNhdCwgMjMgQXByIDIwMTYgMTg6 Mzc6NTkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBBbHdheXMgY291bnQgdGhl IE5VTEwgZW50cnkgaW4gZHluYW1pYyBzeW1ib2wgdGFibGUKClRoZXJlIGlz IGFuIHVudXNlZCBOVUxMIGVudHJ5IGF0IHRoZSBoZWFkIG9mIGR5bmFtaWMg c3ltYm9sIHRhYmxlIHdoaWNoCndlIG11c3QgYWNjb3VudCBmb3IgaW4gb3Vy IGNvdW50IGV2ZW4gaWYgdGhlIHRhYmxlIGlzIGVtcHR5IG9yIHVudXNlZApz aW5jZSBpdCBpcyBpbnRlbmRlZCBmb3IgdGhlIG1hbmRhdG9yeSBEVF9TWU1U QUIgdGFnICguZHluc3ltIHNlY3Rpb24pCmluIC5keW5hbWljIHNlY3Rpb24u CgoJKiBlbGYtYmZkLmggKGVsZl9saW5rX2hhc2hfdGFibGUpOiBVcGRhdGUg Y29tbWVudHMgZm9yCglkeW5zeW1jb3VudC4KCSogZWxmbGluay5jIChfYmZk X2VsZl9saW5rX3JlbnVtYmVyX2R5bnN5bXMpOiBBbHdheXMgY291bnQgZm9y Cgl0aGUgdW51c2VkIE5VTEwgZW50cnkgYXQgdGhlIGhlYWQgb2YgZHluYW1p YyBzeW1ib2wgdGFibGUuCi0tLQogYmZkL2VsZi1iZmQuaCB8ICA0ICsrLS0K IGJmZC9lbGZsaW5rLmMgfCAxMCArKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9iZmQvZWxmLWJmZC5oIGIvYmZkL2VsZi1iZmQuaAppbmRleCA1ZGNl NzBlLi43NDQ3NjI5IDEwMDY0NAotLS0gYS9iZmQvZWxmLWJmZC5oCisrKyBi L2JmZC9lbGYtYmZkLmgKQEAgLTUyMCw4ICs1MjAsOCBAQCBzdHJ1Y3QgZWxm X2xpbmtfaGFzaF90YWJsZQogICB1bmlvbiBnb3RwbHRfdW5pb24gaW5pdF9n b3Rfb2Zmc2V0OwogICB1bmlvbiBnb3RwbHRfdW5pb24gaW5pdF9wbHRfb2Zm c2V0OwogCi0gIC8qIFRoZSBudW1iZXIgb2Ygc3ltYm9scyBmb3VuZCBpbiB0 aGUgbGluayB3aGljaCBtdXN0IGJlIHB1dCBpbnRvCi0gICAgIHRoZSAuZHlu c3ltIHNlY3Rpb24uICAqLworICAvKiBUaGUgbnVtYmVyIG9mIHN5bWJvbHMg Zm91bmQgaW4gdGhlIGxpbmsgd2hpY2ggaXMgaW50ZW5kZWQgZm9yIHRoZQor ICAgICBtYW5kYXRvcnkgRFRfU1lNVEFCIHRhZyAoLmR5bnN5bSBzZWN0aW9u KSBpbiAuZHluYW1pYyBzZWN0aW9uLiAgKi8KICAgYmZkX3NpemVfdHlwZSBk eW5zeW1jb3VudDsKIAogICAvKiBUaGUgc3RyaW5nIHRhYmxlIG9mIGR5bmFt aWMgc3ltYm9scywgd2hpY2ggYmVjb21lcyB0aGUgLmR5bnN0cgpkaWZmIC0t Z2l0IGEvYmZkL2VsZmxpbmsuYyBiL2JmZC9lbGZsaW5rLmMKaW5kZXggNmY2 NzI2Ni4uN2JhYmZiOSAxMDA2NDQKLS0tIGEvYmZkL2VsZmxpbmsuYworKysg Yi9iZmQvZWxmbGluay5jCkBAIC05MDUsMTEgKzkwNSwxMSBAQCBfYmZkX2Vs Zl9saW5rX3JlbnVtYmVyX2R5bnN5bXMgKGJmZCAqb3V0cHV0X2JmZCwKIAkJ CSAgZWxmX2xpbmtfcmVudW1iZXJfaGFzaF90YWJsZV9keW5zeW1zLAogCQkJ ICAmZHluc3ltY291bnQpOwogCi0gIC8qIFRoZXJlIGlzIGFuIHVudXNlZCBO VUxMIGVudHJ5IGF0IHRoZSBoZWFkIG9mIHRoZSB0YWJsZSB3aGljaAotICAg ICB3ZSBtdXN0IGFjY291bnQgZm9yIGluIG91ciBjb3VudC4gIFdlIGFsd2F5 cyBjcmVhdGUgdGhlIGR5bnN5bQotICAgICBzZWN0aW9uLCBldmVuIGlmIGl0 IGlzIGVtcHR5LCB3aXRoIGR5bmFtaWMgc2VjdGlvbnMuICAqLwotICBpZiAo ZWxmX2hhc2hfdGFibGUgKGluZm8pLT5keW5hbWljX3NlY3Rpb25zX2NyZWF0 ZWQpCi0gICAgKytkeW5zeW1jb3VudDsKKyAgLyogVGhlcmUgaXMgYW4gdW51 c2VkIE5VTEwgZW50cnkgYXQgdGhlIGhlYWQgb2YgdGhlIHRhYmxlIHdoaWNo IHdlCisgICAgIG11c3QgYWNjb3VudCBmb3IgaW4gb3VyIGNvdW50IGV2ZW4g aWYgdGhlIHRhYmxlIGlzIGVtcHR5IHNpbmNlIGl0CisgICAgIGlzIGludGVu ZGVkIGZvciB0aGUgbWFuZGF0b3J5IERUX1NZTVRBQiB0YWcgKC5keW5zeW0g c2VjdGlvbikgaW4KKyAgICAgLmR5bmFtaWMgc2VjdGlvbi4gICovCisgIGR5 bnN5bWNvdW50Kys7CiAKICAgZWxmX2hhc2hfdGFibGUgKGluZm8pLT5keW5z eW1jb3VudCA9IGR5bnN5bWNvdW50OwogICByZXR1cm4gZHluc3ltY291bnQ7 Ci0tIAoyLjUuNQoK --94eb2c08bd70ea08650531514fa7--