From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102619 invoked by alias); 20 Mar 2015 15:41:50 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 102608 invoked by uid 89); 20 Mar 2015 15:41:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 20 Mar 2015 15:41:47 +0000 Received: by oigv203 with SMTP id v203so94280031oig.3 for ; Fri, 20 Mar 2015 08:41:46 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.209.130 with SMTP id i124mr27665192oig.108.1426866105888; Fri, 20 Mar 2015 08:41:45 -0700 (PDT) Received: by 10.76.134.102 with HTTP; Fri, 20 Mar 2015 08:41:45 -0700 (PDT) In-Reply-To: References: <20140331200446.A09B074430@topped-with-meat.com> <20140331214025.E61517447E@topped-with-meat.com> <20140910225238.0B6362C39CF@topped-with-meat.com> <20141220135811.GA7161@gmail.com> <20150107131655.GA7818@gmail.com> <20150107144300.GA498@gmail.com> Date: Fri, 20 Mar 2015 15:41:00 -0000 Message-ID: Subject: Re: PATCH: PR gold/14675: No eh_frame info registered in exception_static_test From: "H.J. Lu" To: Cary Coutant Cc: Ian Lance Taylor , Roland McGrath , Alan Modra , Binutils , =?UTF-8?Q?Rafael_=C3=81vila_de_Esp=C3=ADndola?= Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00263.txt.bz2 On Mon, Mar 9, 2015 at 10:16 AM, Cary Coutant wrote: >> Any progress? > > I've committed the attached patch to fix this problem by delaying the > attachment of the optimized .eh_frame sections to the output section > until we see the end marker section (or to the end of pass 1 if we > never see an end marker). > > -cary > > > 2015-03-09 Cary Coutant > > gold/ > PR gold/14675 > * ehframe.cc (Eh_frame::add_ehframe_input_section): Change return type; > return enum indicating whether .eh_frame section is empty, optimizable, > unrecognized, or an end marker. Adjust explicit instantiations. > * ehframe.h (Eh_frame::Eh_frame_section_disposition): New enum type. > (Eh_frame::add_ehframe_input_section): Change return type. > * gold.cc (queue_middle_tasks): Call Layout::finalize_eh_frame_section. > * layout.cc (Layout::layout_eh_frame): Don't add optimized sections > to the .eh_frame output section until we see the end marker. > (Layout::finalize_eh_frame_section): New. > * layout.h: (Layout::finalize_eh_frame_section): New. This caused: https://sourceware.org/bugzilla/show_bug.cgi?id=18152 -- H.J.